Skip to content

Conversation

@smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch V00-34-XX.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • skip_test = static,header

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38517/summary.html
COMMIT: da7f64f
CMSSW: CMSSW_14_1_X_2024-03-31-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/205/38517/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

Pull request #205 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38518/summary.html
COMMIT: e1e87c6
CMSSW: CMSSW_14_1_X_2024-03-31-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/205/38518/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38519/summary.html
COMMIT: e1e87c6
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-03-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/pkgtools/205/38519/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38519/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38519/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 187 lines from the logs
  • Reco comparison results: 67995 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297469
  • DQMHistoTests: Total failures: 190380
  • DQMHistoTests: Total nulls: 286
  • DQMHistoTests: Total successes: 3106783
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.397 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.713 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 1.172 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.063 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.031 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.891 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.661 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -1.583 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 46 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

Pull request #205 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38530/summary.html
COMMIT: 6744c81
CMSSW: CMSSW_14_1_X_2024-04-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/205/38530/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_MULTIARCHS_X

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38541/summary.html
COMMIT: 6744c81
CMSSW: CMSSW_14_0_X_2024-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/205/38541/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38537/summary.html
COMMIT: 6744c81
CMSSW: CMSSW_14_1_MULTIARCHS_X_2024-03-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/pkgtools/205/38537/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38537/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20c3a6/38537/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test test_edmPickEvents had ERRORS
---> test SubmitPVsplit had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially removed 454 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 69925 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297391
  • DQMHistoTests: Total failures: 197231
  • DQMHistoTests: Total nulls: 280
  • DQMHistoTests: Total successes: 3099860
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.279 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -1.157 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 0.018 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13034.0 ): -0.108 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): 0.012 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.031 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.475 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.954 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): ...
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 19 / 46 workflows

@smuzaffar
Copy link
Contributor Author

+externals

looks good, does not trigger rebuilt of packages

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next V00-34-XX IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the order-vec-pgo branch May 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants