-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix PU for 2026 wfs [16_0_X] #49959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PU for 2026 wfs [16_0_X] #49959
Conversation
|
please test |
|
type bug-fix |
|
A new Pull Request was created by @AdrianoDee for CMSSW_16_0_X. It involves the following packages:
@AdrianoDee, @DickyChant, @antoniovagnerini, @miquork can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Failed BuildI found compilation error when building: *** Error compiling 'src/Configuration/PyReleaseValidation/python/relval_steps.py'... Sorry: TabError: inconsistent use of tabs and spaces in indentation (relval_steps.py, line 4898) gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:2059: CompilePython] Error 1 gmake[1]: Target 'PostBuild' not remade because of errors. gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_X_2026-01-27-2300' gmake: *** [config/SCRAM/GMake/Makefile.rules:1942: src] Error 2 gmake: Target 'all' not remade because of errors. gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2 Command exited with non-zero status 2 Command being timed: "scram build -v -k -j 16" User time (seconds): 393.48 |
|
please test |
|
Pull request #49959 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @miquork can you please check and sign again. |
|
-1 Failed Tests: RelVals Failed RelVals |
|
@smuzaffar something strange happened, and it seems to me it's connected to an unexpected (?) behavior of the bot. Please let me know if I'm wrong. In 14234.0 the step2 log shows an empyt pileup input And this is normal since the RelVal has long gone. But, this dataset should have been cached by the bot a long time ago (it was not touched here). Do you understand why the mechanism is not working here? |
|
please test |
|
Pull request #49959 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @miquork can you please check and sign again. |
|
@cms-sw/orp-l2, if this could enter in 16_0_0, it would be great (I should have solved the issue causing the failures) |
|
The 2026 tests have the right configuration now https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6085/50983/runTheMatrix-results/18634.0_TTbar_14TeV+2026PU/cmdLog |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Size: This PR adds an extra 68KB to repository Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 2 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
+1 |
PR description:
Plain backport of #49958