TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code #49932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated process modifiers (ticl_v5, clue3D, fastJetTICL, etc.). - Remove legacy python configurations (ticl_iterations, customize scripts). - Remove obsolete CNNv4 inference code. - Add ticl_dev and simTrackstersFromPU modifiers. - Clean up superclustering modifiers.
- Update iterativeTICL_cff.py to use TICLv5 chain by default. - Update C++ plugins (PatternRecognition, PFTICLProducer) to use v5 defaults (computeLocalTime=true). - Update Step configurations to remove legacy modifiers. - Switch CLUE3DHighStep to PFN inference.
- Update associator plugins to handle empty collections gracefully. - Update associator python configs to point to v5 collections (ticlCandidate). - Use simTrackstersFromPU modifier in association configurations.
- HGCalValidator: Default to ticlCandidate and v5 collections. - Update plotting scripts for v5. - Update EventContent to keep new v5 collections. - Fix bugs in validator plugins regarding empty collections.
- Update HLT 75e33 and Scouting menus to use TICLv5. - Remove obsolete HLT modules. - Update PyReleaseValidation workflows to reflect removal of ticl_v5 modifier. - Cleanup Run4 RelVal definitions.
Contributor
|
cms-bot internal usage |
Contributor
Author
|
@cmsbuild please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49932/47681
|
Contributor
|
A new Pull Request was created by @felicepantaleo for master. It involves the following packages:
@AdrianoDee, @DickyChant, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @civanch, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @mmusich, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
-1 Failed Tests: UnitTests Failed Unit TestsI found 1 errors in the following unit tests: ---> test testProduceNanoHLT had ERRORS Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 9 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
Contributor
|
Pull request #49932 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
Contributor
Author
|
@cmsbuild please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49932/47692
|
Contributor
|
Pull request #49932 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @civanch, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-started
code-checks-approved
labels
Contributor
Author
|
@cmsbuild please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49932/47693
|
Contributor
|
Pull request #49932 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @civanch, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @mmusich, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
Contributor
Author
|
now this PR includes also #49866 |
Contributor
Author
|
@cseez @pfs fyi |
Contributor
|
There's now a conflict to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes TICL v5 as the default reconstruction configuration, removing the need for explicit process modifiers and cleaning up significant amounts of legacy code associated with previous versions.
Key Changes:
Core Configuration:
Updated
RecoHGCal/TICL/python/iterativeTICL_cff.pyto use the TICL v5 chain (CLUE3DHigh->TracksterLinks->TICLCandidate) by default.Removed fallback logic for v4.
Switched
CLUE3DHighStepto use PFN inference by default.Introduced
ticl_devprocess modifier for future development.C++ Plugins:
PFTICLProducer: Simplified logic by removing the
isTICLv5_switch. The default behavior now assumes TICL v5 timing fromTICLCandidate.PatternRecognition: Enabled
computeLocalTimeby default inPatternRecognitionbyCLUE3DandPatternRecognitionbyCA. EnabledusePCACleaningby default inPatternRecognitionbyCLUE3D.Validation & DQM:
Updated
HGCalValidatorto validateticlCandidateandticlTracksterLinkscollections by default.Updated
makeHGCalValidationPlots.pyto plot v5 collections.Updated
RecoHGCal_EventContent_cff.pyto consolidate keep statements for v5 collections.Fixed handling of empty collections in validator plugins.
Cleanup:
Removed obsolete process modifiers:
ticl_v4,ticl_v5,clue3D,fastJetTICL,enableCPfromPU.Removed deprecated Python configurations:
ticl_iterations.py,customiseForTICLv5_cff.py,customiseTICLFromReco.py.Removed legacy
TracksterInferenceByCNNv4implementation.Removed deprecated
harvestHGCalValidationPlots.pyscript.HLT & Workflows:
Updated HLT 75e33 and Scouting menus to use TICL v5 components.
Removed obsolete HLT modules (
hltParticleFlowSuperClusterHGCalFromTICLL1Seeded,hltParticleFlowSuperClusterHGCalFromTICLUnseeded).Updated PyReleaseValidation workflows to reflect the removal of the
ticl_v5modifier.Testing:
Notes:
This PR represents a major consolidation of the TICL configuration, simplifying the codebase and establishing a clean baseline for future developments.