Skip to content

Conversation

@Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Jan 21, 2026

PR description:

  • avoid doing explicit forwarding of data products in the reco namespace in non DataFormats package.

This is needed for the EVOLUTION_X branch where the class names will be changing. Doing the change first in master may help avoid problems if additional changes occur in master.

PR validation:

Code compiles.

resolves cms-sw/framework-team#1812

These provide class forwarding support for classes which will move to a new namespace but have a using directive allowing the use of the old name.
If forward declaration still needed, include approprate Fwd file.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49889/47610

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • Alignment/CommonAlignmentAlgorithm (alca)
  • Alignment/ReferenceTrajectories (alca)
  • AnalysisDataFormats/TopObjects (analysis)
  • CommonTools/CandAlgos (reconstruction)
  • CommonTools/CandUtils (reconstruction)
  • DQM/Physics (dqm)
  • DQM/TrackingMonitor (dqm)
  • DQM/TrackingMonitorSource (dqm)
  • DataFormats/BeamSpot (reconstruction)
  • DataFormats/Candidate (reconstruction)
  • DataFormats/EgammaReco (reconstruction)
  • DataFormats/HLTReco (hlt)
  • DataFormats/JetReco (reconstruction)
  • DataFormats/MuonReco (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)
  • Fireworks/Calo (visualization)
  • Fireworks/Core (visualization)
  • Fireworks/Electrons (visualization)
  • Fireworks/Muons (visualization)
  • Fireworks/ParticleFlow (visualization)
  • HLTrigger/btau (hlt)
  • HeavyFlavorAnalysis/RecoDecay (analysis)
  • HeavyFlavorAnalysis/SpecificDecay (analysis)
  • PhysicsTools/Heppy (analysis)
  • PhysicsTools/PatAlgos (reconstruction, xpog)
  • PhysicsTools/RecoUtils (analysis)
  • RecoEgamma/EgammaElectronAlgos (reconstruction)
  • RecoEgamma/EgammaElectronProducers (reconstruction)
  • RecoEgamma/EgammaTools (reconstruction)
  • RecoEgamma/ElectronIdentification (reconstruction)
  • RecoHGCal/TICL (reconstruction)
  • RecoHI/HiTracking (reconstruction)
  • RecoJets/JetProducers (reconstruction)
  • RecoMuon/MuonIdentification (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)
  • RecoTracker/PixelTrackFitting (reconstruction)
  • RecoVertex/BeamSpotProducer (alca, reconstruction)
  • RecoVertex/PrimaryVertexProducer (reconstruction)
  • SimGeneral/DataMixingModule (simulation)
  • SimGeneral/PreMixingModule (simulation)
  • TrackingTools/GeomPropagators (reconstruction)
  • Validation/RecoEgamma (dqm)
  • Validation/RecoTrack (dqm)
  • Validation/RecoVertex (dqm)

@Alejandro1400, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @alja, @arunhep, @atpathak, @battibass, @civanch, @cmsbuild, @ctarricone, @ftorrresd, @gabrielmscampos, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @perrotta, @rseidita, @srimanob, @tvami can you please review it and eventually sign? Thanks.
@24LopezR, @AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @Ming-Yan, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @afiqaize, @ahinzmann, @alja, @amagitte, @andrzejnovak, @apsallid, @argiro, @arossi83, @azotz, @battibass, @bellan, @castaned, @cericeci, @clelange, @denizsun, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @fioriNTU, @forthommel, @francescobrivio, @fsimone91, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @idebruyn, @jainshilpi, @jandrea, @jazzitup, @jdamgov, @jdolen, @jhgoh, @kurtejung, @lecriste, @lgray, @llunerti, @makortel, @mandrenguyen, @mariadalfonso, @martinamalberti, @mbluj, @missirol, @mmarionncern, @mmasciov, @mmusich, @mtosi, @nhanvtran, @pakhotin, @pavlo-kashko, @philippgadow, @ram1123, @rappoccio, @rchatter, @richa2710, @rociovilar, @rovere, @rsreds, @salimcerci, @sameasy, @schoef, @seemasharmafnal, @slomeo, @sobhatta, @sroychow, @thomreis, @threus, @tlampen, @tocheng, @trocino, @valsdav, @varuns23, @venturia, @wang0jin, @wmtford, @yenjie, @yetkinyilmaz, @yslai, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jan 21, 2026

type evo

@Dr15Jones
Copy link
Contributor Author

@tvami I'm not 100% certain this is really EVO although it is future support of EVO.

@tvami
Copy link
Contributor

tvami commented Jan 21, 2026

@cmsbuild, please test

@makortel
Copy link
Contributor

type -evo

This PR is for the master branch and should follow the usual review by everyone.

@Moanwar
Copy link
Contributor

Moanwar commented Jan 22, 2026

+1

@battibass
Copy link

+xpog

@perrotta
Copy link
Contributor

+alca

@Dr15Jones
Copy link
Contributor Author

+visualization

@mmusich
Copy link
Contributor

mmusich commented Jan 22, 2026

+hlt

@kpedro88
Copy link
Contributor

+simulation

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link

+1

@cmsbuild cmsbuild merged commit a187786 into cms-sw:master Jan 22, 2026
10 checks passed
@Dr15Jones Dr15Jones deleted the forwardReco branch January 26, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment