`runHLTTiming`: add checking for errors in logs #49887

mmusich · 2026-01-21T15:36:54Z

PR description:

Add checking for log errors in runHLTTiming.sh script, to avoid silently failing in IB and PR tets.

PR validation:

needs to use the bot.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It will need to be backported to 16_0_X, to make cms-sw/cms-bot#2662 work.

cmsbuild · 2026-01-21T15:37:16Z

cms-bot internal usage

cmsbuild · 2026-01-21T15:38:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49887/47604

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33/test/runHLTTiming.sh modified in PR(s): update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821

mmusich · 2026-01-21T15:38:41Z

test parameters:

enable = hlt_p2_timing

mmusich · 2026-01-21T15:38:47Z

please test

cmsbuild · 2026-01-21T18:07:16Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85158c/50786/summary.html
COMMIT: d33d9ca
CMSSW: CMSSW_16_1_X_2026-01-21-1100/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49887/50786/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4025536
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4025501
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

mmusich · 2026-01-21T20:19:45Z

@cmsbuild, please test with cms-sw/cms-bot#2662

cmsbuild · 2026-01-21T23:06:30Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85158c/50794/summary.html
COMMIT: d33d9ca
CMSSW: CMSSW_16_1_X_2026-01-21-1100/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49887/50794/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4025536
DQMHistoTests: Total failures: 43
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4025473
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

mmusich · 2026-01-22T09:05:08Z

@cmsbuild, please test with cms-sw/cms-bot#2662

cmsbuild · 2026-01-22T11:29:57Z

-1

Failed Tests: HLTP2Timing
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85158c/50806/summary.html
COMMIT: d33d9ca
CMSSW: CMSSW_16_1_X_2026-01-21-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49887/50806/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4025536
DQMHistoTests: Total failures: 27
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4025489
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

cmsbuild · 2026-01-23T09:43:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49887/47645

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33/test/runHLTTiming.sh modified in PR(s): update phase-2 HLT timing script and use alpaka modifier in NGT workflows #49821

cmsbuild · 2026-01-23T09:44:14Z

Pull request #49887 was updated.

mmusich · 2026-01-23T09:45:15Z

@cmsbuild, please test

cmsbuild · 2026-01-23T12:09:46Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85158c/50831/summary.html
COMMIT: 8ce0a6c
CMSSW: CMSSW_16_1_X_2026-01-22-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49887/50831/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially added 2 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4025536
DQMHistoTests: Total failures: 25
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4025491
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

cmsbuild · 2026-01-23T12:12:51Z

A new Pull Request was created by @mmusich for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2026-01-23T12:13:43Z

+hlt

tests are successfull, this is needed for P2 HLT timing: check on all expected json files to declare success cms-bot#2662

cmsbuild · 2026-01-23T12:14:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

ftenchini · 2026-01-23T13:37:00Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Jan 21, 2026

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jan 21, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 21, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 21, 2026

mmusich changed the title ~~runHLTTiming: add checking for erorrs in logs~~ runHLTTiming: add checking for errors in logs Jan 21, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 21, 2026

cmsbuild added requires-external tests-started and removed tests-approved labels Jan 21, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 21, 2026

cmsbuild added tests-started and removed tests-approved labels Jan 22, 2026

cmsbuild removed the tests-started label Jan 22, 2026

cmsbuild added tests-pending code-checks-pending and removed tests-rejected requires-external code-checks-approved labels Jan 23, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 23, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 23, 2026

mmusich mentioned this pull request Jan 23, 2026

P2 HLT timing: check on all expected json files to declare success cms-sw/cms-bot#2662

Open

cmsbuild added tests-approved and removed tests-started labels Jan 23, 2026

mmusich marked this pull request as ready for review January 23, 2026 12:11

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Jan 23, 2026

mmusich mentioned this pull request Jan 23, 2026

[16.0.X] runHLTTiming: add checking for errors in logs #49909

Open

cmsbuild added orp-approved and removed orp-pending labels Jan 23, 2026

cmsbuild merged commit 8a0c8be into cms-sw:master Jan 23, 2026
12 checks passed

mmusich deleted the mm_check_hlt_timing_errors branch January 23, 2026 13:38

runHLTTiming: add checking for errors in logs #49887

runHLTTiming: add checking for errors in logs #49887

Conversation

mmusich commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 21, 2026

Uh oh!

mmusich commented Jan 21, 2026

Uh oh!

mmusich commented Jan 21, 2026

Uh oh!

cmsbuild commented Jan 21, 2026

Comparison Summary

Uh oh!

mmusich commented Jan 21, 2026

Uh oh!

cmsbuild commented Jan 21, 2026

Comparison Summary

Uh oh!

mmusich commented Jan 22, 2026

Uh oh!

cmsbuild commented Jan 22, 2026

Comparison Summary

Uh oh!

cmsbuild commented Jan 23, 2026

Uh oh!

cmsbuild commented Jan 23, 2026

Uh oh!

mmusich commented Jan 23, 2026

Uh oh!

cmsbuild commented Jan 23, 2026

Comparison Summary

Uh oh!

cmsbuild commented Jan 23, 2026

Uh oh!

mmusich commented Jan 23, 2026

Uh oh!

cmsbuild commented Jan 23, 2026

Uh oh!

ftenchini commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`runHLTTiming`: add checking for errors in logs #49887

`runHLTTiming`: add checking for errors in logs #49887

mmusich commented Jan 21, 2026 •

edited

Loading

cmsbuild commented Jan 21, 2026 •

edited

Loading