-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[L1T] Update recommended geometry tag in Phase2 L1TNanoAOD producer README to D121 (Phase2) #49870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49870/47570 |
|
A new Pull Request was created by @RobertJWard for master. It involves the following packages:
@BenjaminRS, @battibass, @cmsbuild, @ftorrresd, @quinnanm can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49870/47575
|
|
Pull request #49870 was updated. @BenjaminRS, @battibass, @cmsbuild, @ftorrresd, @quinnanm can you please check and sign again. |
|
@RobertJWard, can you please collapse your commits into a single one (as described here) before we approve the PR? |
ede9297 to
ff05c25
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49870/47626 |
|
Pull request #49870 was updated. @BenjaminRS, @battibass, @cmsbuild, @ftorrresd, @quinnanm can you please check and sign again. |
|
Hi @battibass I've now squashed the commits (though an extra merge commit was added as the conditions update T33 -> T35 was also made in parallel in #49790, resulting in a conflict) |
|
please test |
|
+1 |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
PR description:
Updates the recipe in the README for the Phase 2 L1TNanoAOD producer tool to the latest phase 2 recommended geometry of D121 (previously D110).
PR validation:
None required - simple text change to a markdown file, with no impact on the code itself.