Skip to content

Conversation

@rclark99
Copy link

PR description:

Updating NanoDQM PFCand plots to include separate plots for each PFCand type for validation of NanoAOD. As proposed in recent PF group meeting link.

PR validation:

Ran on TTbar, QCD, ZEE RelVals, also performed code-checks and code-format.

@laurenhay @hatakeyamak @ahinzmann @stahlleiton

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49803/47447

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rclark99 for CMSSW_16_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@battibass, @ftorrresd can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d72e0/50735/summary.html
COMMIT: 37a7b4e
CMSSW: CMSSW_16_0_X_2026-01-19-1100/el8_amd64_gcc13
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49803/50735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4149103
  • DQMHistoTests: Total failures: 77
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4149006
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 132.62500000000009 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 5.305 KiB Physics/NanoAODDQM
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.085 3.085 0.000 ( +0.0% ) 3.62 3.68 -1.5% 2.568 2.551
NANOmc106Xul16APVv2 2500.0002 3.041 3.041 0.000 ( +0.0% ) 3.63 3.65 -0.4% 2.612 2.611
NANOmc106Xul17v2 2500.0003 3.144 3.144 0.000 ( +0.0% ) 3.38 3.43 -1.5% 3.009 3.006
NANOmc106Xul18v2 2500.0004 3.097 3.097 0.000 ( +0.0% ) 3.43 3.50 -2.0% 2.997 2.989
NANOdata106Xul16v2 2500.0101 1.539 1.539 0.000 ( +0.0% ) 6.06 6.14 -1.4% 2.667 2.686
NANOdata106Xul17v2 2500.0102 1.926 1.926 0.000 ( +0.0% ) 4.04 4.10 -1.3% 2.812 2.821
NANOdata106Xul18v2 2500.0103 1.890 1.890 0.000 ( +0.0% ) 4.84 4.85 -0.1% 2.753 2.761
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.81 1.78 +1.3% 2.565 2.552
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.75 1.73 +1.4% 2.570 2.568
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.61 1.63 -1.1% 2.707 2.699
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.58 1.57 +0.6% 2.729 2.725
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.57 1.55 +0.8% 2.623 2.615
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.55 1.56 -0.2% 2.553 2.551
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.50 1.48 +1.2% 2.655 2.654
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.52 1.52 +0.2% 2.641 2.639
NANOmcUL16APVMini2Mini 2500.0401 0.023 0.023 0.000 ( +0.0% ) 2.52 2.45 +2.9% 2.106 2.110
NANOmcUL16Mini2Mini 2500.0402 0.023 0.023 0.000 ( +0.0% ) 2.45 2.27 +8.2% 2.135 2.135
NANOmcUL17Mini2Mini 2500.0403 0.023 0.023 0.000 ( +0.0% ) 2.32 2.32 -0.2% 2.151 2.148
NANOmcUL18Mini2Mini 2500.0404 0.023 0.023 0.000 ( +0.0% ) 2.40 2.39 +0.4% 2.150 2.149
NANOdataUL16Mini2Mini 2500.0501 0.039 0.039 0.000 ( +0.0% ) 3.52 3.41 +3.3% 2.023 2.019
NANOdataUL17Mini2Mini 2500.0502 0.040 0.040 0.000 ( +0.0% ) 2.57 2.56 +0.6% 2.079 2.083
NANOdataUL18Mini2Mini 2500.0503 0.039 0.039 0.000 ( +0.0% ) 2.93 3.06 -4.2% 2.073 2.076
NANOmc130X 2500.1001 3.220 3.220 0.000 ( +0.0% ) 4.12 4.18 -1.6% 2.936 2.932
NANOdata130Xrun3 2500.1101 1.790 1.790 0.000 ( +0.0% ) 6.23 6.39 -2.4% 2.652 2.643
NANOmc23Mini2Mini 2500.1201 0.022 0.022 0.000 ( +0.0% ) 2.67 2.79 -4.5% 2.029 2.030
NANOdata23Mini2Mini 2500.1301 0.041 0.041 0.000 ( +0.0% ) 3.52 3.50 +0.6% 2.319 2.307
ScoutingNANOdata124Xrun3 2500.1501 0.772 0.772 0.000 ( +0.0% ) 33.18 34.24 -3.1% 1.479 1.464
ScoutingNANOmonitordata124Xrun3 2500.1502 0.862 0.862 0.000 ( +0.0% ) 14.31 14.55 -1.7% 1.403 1.396
ScoutingNANOdata130Xrun3 2500.1503 1.251 1.251 0.000 ( +0.0% ) 24.50 24.84 -1.4% 1.452 1.439
ScoutingNANOmonitordata130Xrun3 2500.1504 1.297 1.297 0.000 ( +0.0% ) 10.82 10.93 -1.0% 1.382 1.381
muPOGNANOmc140X 2500.2201 2.065 2.065 0.000 ( +0.0% ) 5.53 5.66 -2.3% 2.023 2.025
EGMNANOmc140X 2500.2202 3.849 3.849 0.000 ( +0.0% ) 3.90 4.00 -2.5% 2.358 2.357
BTVNANOmc140X 2500.2203 10.466 10.466 0.000 ( +0.0% ) 2.51 2.53 -1.1% 2.540 2.542
jmeNANOmc140X 2500.2204 6.630 6.630 0.000 ( +0.0% ) 1.10 1.13 -2.6% 2.441 2.441
lepTrackInfoNANOmc140X 2500.2206 3.543 3.543 0.000 ( +0.0% ) 3.90 3.98 -2.0% 2.352 2.350
ScoutingNANOmc140X 2500.2207 1.488 1.488 0.000 ( +0.0% ) 14.24 14.31 -0.5% 1.814 1.794
ScoutingNANOwithPromptmc140X 2500.2208 4.452 4.452 0.000 ( +0.0% ) 3.16 3.17 -0.3% 2.726 2.736
muPOGNANO140Xrun3 2500.2301 1.469 1.469 0.000 ( +0.0% ) 7.76 7.84 -1.0% 2.286 2.293
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 5.59 5.68 -1.5% 2.611 2.608
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.58 3.62 -1.1% 2.794 2.796
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.42 1.45 -2.1% 2.665 2.669
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.62 5.63 -0.2% 2.612 2.606
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 29.21 29.93 -2.4% 1.460 1.458
ScoutingNANOmonitordata140Xrun3 2500.2308 2.784 2.784 0.000 ( +0.0% ) 4.96 5.02 -1.1% 2.936 2.943
ScoutingNANOmonitorWithPromptdata140Xrun3 2500.2309 2.784 2.784 0.000 ( +0.0% ) 4.94 4.99 -1.1% 2.943 2.926
L1ScoutingSelectionNANOdata140Xrun3 2500.2311 0.081 0.081 0.000 ( +0.0% ) 45.14 46.14 -2.2% 0.677 0.676
L1ScoutingNANOdata140Xrun3 2500.231 0.082 0.082 0.000 ( +0.0% ) 3.92 3.96 -1.1% 0.828 0.826
l1DPGNANO140Xrun3 2500.2401 9.404 9.404 0.000 ( +0.0% ) 7.34 7.23 +1.5% 1.748 1.741
muDPGNANO140Xrun3 2500.2402 10.377 10.377 0.000 ( +0.0% ) 1.65 1.65 +0.0% 1.619 1.618
muDPGNANOBkg140Xrun3 2500.2403 6.401 6.401 0.000 ( +0.0% ) 16.08 15.77 +1.9% 1.163 1.162
hcalDPGNANO140Xrun3 2500.2404 486.015 486.015 0.000 ( +0.0% ) 1.15 1.16 -0.9% 1.567 1.599
hcalDPGCalibNANO140Xrun3 2500.2405 826.418 826.418 0.000 ( +0.0% ) 1.50 1.51 -0.3% 1.552 1.566
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.64 1.65 -0.6% 1.664 1.661
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.91 1.90 +0.6% 2.614 2.613
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.88 1.91 -1.7% 2.562 2.566
NANOmc150X 2500.3001 3.217 3.217 0.000 ( +0.0% ) 17.37 17.38 -0.1% 2.508 2.505
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 33.19 34.16 -2.8% 2.219 2.215
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 27.00 28.39 -4.9% 2.233 2.228
muPOGNANOmc150X 2500.3201 2.255 2.255 0.000 ( +0.0% ) 16.32 16.40 -0.5% 2.336 2.338
EGMNANOmc150X 2500.3202 4.111 4.111 0.000 ( +0.0% ) 13.99 14.30 -2.1% 2.450 2.445
BTVNANOmc150X 2500.3203 10.552 10.552 0.000 ( +0.0% ) 4.78 4.77 +0.2% 2.648 2.646
jmeNANOmc150X 2500.3204 6.595 6.595 0.000 ( +0.0% ) 1.31 1.33 -1.5% 2.631 2.627
jmeNANOrePuppimc150X 2500.3205 6.598 6.598 0.000 ( +0.0% ) 1.24 1.25 -1.2% 2.878 2.875
lepTrackInfoNANOmc150X 2500.3206 3.721 3.721 0.000 ( +0.0% ) 14.96 14.86 +0.7% 2.443 2.444
ScoutingNANOmc150X 2500.3207 1.563 1.563 0.000 ( +0.0% ) 19.43 19.85 -2.1% 2.255 2.256
ScoutingNANOwithPromptmc150X 2500.3208 4.775 4.775 0.000 ( +0.0% ) 10.45 10.54 -0.9% 2.713 2.702
BPHNANOmc150X 2500.3209 4.127 4.127 0.000 ( +0.0% ) 16.84 17.07 -1.4% 2.539 2.540
muPOGNANO150Xrun3 2500.3301 1.125 1.125 0.000 ( +0.0% ) 31.29 31.73 -1.4% 2.051 2.045
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 25.58 25.99 -1.6% 2.135 2.136
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 5.78 5.91 -2.2% 2.335 2.341
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.61 1.64 -1.6% 2.296 2.295
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.41 1.43 -1.0% 2.546 2.558
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 27.44 28.27 -2.9% 2.133 2.133
ScoutingNANOdata150Xrun3 2500.3307 1.738 1.738 0.000 ( +0.0% ) 31.08 31.82 -2.3% 1.464 1.467
ScoutingNANOmonitordata150Xrun3 2500.3308 1.400 1.400 0.000 ( +0.0% ) 26.95 27.23 -1.0% 2.100 2.107
ScoutingNANOmonitorWithPromptdata150Xrun3 2500.3309 2.602 2.602 0.000 ( +0.0% ) 17.98 17.87 +0.6% 2.486 2.473
BPHNANOdata150Xrun3 2500.331 2.632 2.632 0.000 ( +0.0% ) 32.72 33.33 -1.8% 2.253 2.246
TTbarMINIAOD10.6_UL18v2 2500.9001 1.819 1.819 0.000 ( +0.0% ) 34.58 35.26 -1.9% 1.743 1.744
TTbarMINIAOD14.0 2500.9002 1.665 1.665 0.000 ( +0.0% ) 33.08 33.99 -2.7% 1.367 1.366
DYToLL_M-50_13TeV_pythia8 2500.9101 15.163 15.163 0.000 ( +0.0% ) 6.62 7.79 -15.0% 1.033 1.033
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.171 0.199 -0.029 ( -14.5% ) 2.31 1.83 +26.5% 0.820 0.819
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.45 2.37 +3.5% 0.822 0.821

NANO Comparison Summary

Summary:

  • You potentially added 384 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 41718
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 41718
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 164.45500000000013 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 2500.0001,... ): 5.305 KiB Physics/NanoAODDQM
  • Checked 181 log files, 106 edm output root files, 32 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants