Skip to content

SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU [16_0_X] #49800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 2 commits into from
Jan 21, 2026
Merged

SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU [16_0_X] #49800

cmsbuild merged 2 commits into from
Jan 21, 2026
+2,365 −17

Conversation

@pietroGru
Copy link
Contributor

@pietroGru pietroGru commented Jan 13, 2026

PR description:

Backport of #47629. Summary of the original description

Pull request to merge an heterogeneous implementation of the silicon strip unpacker/clusterizer SiStripClusterizerFromRaw module (legacy), whose purpose is producing strip clusters from raw FED data.

Legacy and heterogeneous implementations of the unpacker/clusterizer share both unpacking and clustering algorithms, with the heter. version having the needed generalizations to allow for parallel implementation.

Further informations in #47629 and comments.

PR validation:

None beyond #47629.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #47629, rebased on top of the CMSSW_16_0_X branch.

pietroGru and others added 2 commits January 13, 2026 17:42
@pietroGru @fwyzard
Dataformats for heterogeneous strip clusterizer
361a2b8 
Co-authored-by: Andrea Bocci <[email protected]>
@pietroGru @fwyzard
Heterogeneous strip clusterizer and converter to legacy
f52a2c5 
- Kernels work divider of 256u from optimization (cms-sw#47629 (comment))
- Bug fix for events with `nStrips` = 0 (https://gist.github.com/mmusich/a7928a000b4eb6ea00ac5ab9cfa2238e)
-- Fix for packet code of non-lite ZS buffers (https://gist.github.com/mmusich/a7928a000b4eb6ea00ac5ab9cfa2238e)
- Use Acc1D directly (cms-sw#47629 (comment))
- Fix errors in static analysis (cms-sw#47629 (comment))

Co-authored-by: Andrea Bocci <[email protected]>
@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Jan 13, 2026
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2026 •
edited
Loading

A new Pull Request was created by @pietroGru for CMSSW_16_0_X.

It involves the following packages:

  • DataFormats/SiStripCluster (reconstruction)
  • DataFormats/SiStripClusterSoA (heterogeneous, reconstruction)
  • DataFormats/SiStripDigiSoA (heterogeneous, reconstruction)
  • EventFilter/SiStripRawToDigi (reconstruction)
  • RecoLocalTracker/SiStripClusterizer (reconstruction)

@Moanwar, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @alesaggio, @echabert, @elusian, @felicepantaleo, @gbenelli, @gpetruc, @jlidrych, @missirol, @mmasciov, @mmusich, @mtosi, @robervalwalsh, @rovere, @threus, @yduhm this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2026 •
edited
Loading

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Jan 13, 2026

enable gpu

@fwyzard
Copy link
Contributor

fwyzard commented Jan 13, 2026

please test

@fwyzard
Copy link
Contributor

fwyzard commented Jan 13, 2026

+heterogeneous

@mmusich
Copy link
Contributor

mmusich commented Jan 13, 2026

backport of #47629

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2026

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2088b0/50581/summary.html
COMMIT: f52a2c5
CMSSW: CMSSW_16_0_X_2026-01-13-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49800/50581/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280553
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280519
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 239 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 149371
  • DQMHistoTests: Total failures: 31877
  • DQMHistoTests: Total nulls: 11
  • DQMHistoTests: Total successes: 117483
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 241 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 149371
  • DQMHistoTests: Total failures: 27926
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 121438
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 258 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 149371
  • DQMHistoTests: Total failures: 29813
  • DQMHistoTests: Total nulls: 10
  • DQMHistoTests: Total successes: 119548
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jan 14, 2026

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2026

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Jan 21, 2026

+1

@cmsbuild cmsbuild merged commit 86c8c4d into cms-sw:CMSSW_16_0_X Jan 21, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-ok changes-dataformats fully-signed heterogeneous-approved orp-approved reconstruction-approved tests-approved trk

Projects

None yet

Milestone

CMSSW_16_0_X

Development

Successfully merging this pull request may close these issues.

6 participants

@pietroGru @cmsbuild @fwyzard @mmusich @jfernan2 @mandrenguyen