Remove legacy CUDA pixel EventSetup modules #49799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
enable gpu |
Contributor
Author
|
please test |
Contributor
|
cms-bot internal usage |
52 tasks
Contributor
Contributor
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@Alejandro1400, @JanChyczynski, @Martin-Grunewald, @Moanwar, @arunhep, @atpathak, @civanch, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @perrotta, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
-1 Failed Tests: UnitTests RelVals RelVals-AMD_W7900 AddOn Failed Unit TestsI found 1 errors in the following unit tests: ---> test createDBObjects had ERRORS Failed RelValsExpand to see more relval errors ...Failed RelVals-AMD_W7900
Failed AddOn Tests |
Contributor
Author
Contributor
|
Pull request has been put on hold by @fwyzard |
mmusich
reviewed
Jan 14, 2026
| @@ -1,49 +0,0 @@ | |||
| #include "CalibTracker/SiPixelESProducers/interface/SiPixelGainCalibrationForHLTGPU.h" | |||
Contributor
There was a problem hiding this comment.
this one is still used in the HLT menu.
Contributor
Author
There was a problem hiding this comment.
Do you know if it's actually needed, or a leftover from the past ?
Contributor
There was a problem hiding this comment.
I checked with:
#!/bin/bash -ex
hltGetConfiguration /dev/CMSSW_16_0_0/GRun \
--globaltag 151X_dataRun3_HLT_v1 \
--data \
--unprescale \
--output minimal \
--max-events 100 \
--eras Run3_2025 --l1-emulator uGT --l1 L1Menu_Collisions2025_v1_3_0_xml \
--input /store/data/Run2025G/EphemeralHLTPhysics0/RAW/v1/000/398/183/00000/002bbd0c-b9ed-4758-b7a6-e2e13149ca34.root \
> hltData.py
cat <<@EOF >> hltData.py
# --- Remove problematic ESProducer if present ---
if hasattr(process, "siPixelGainCalibrationForHLTGPU"):
del process.siPixelGainCalibrationForHLTGPU
@EOF
edmConfigDump hltData.py > dump.py
cmsRun dump.py >& hltData.logon an online-like machine (with GPUs) and I don't observe problems, so it's just a leftover indeed.
You might want to customize your way out directly in customizeHLTforCMSSW to get this approved faster (unless you want to wait STORM to remove the module from the menu in confDB first). @Martin-Grunewald FYI.
Contributor
Author
There was a problem hiding this comment.
I'll add a customisation.
Contributor
|
+hlt
|
cmsbuild
added
hlt-approved
and removed
hlt-pending
simulation-pending
changes-dataformats
labels
Contributor
Author
|
unhold |
Contributor
|
+1 |
Contributor
|
+alca |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 |
mmusich
added a commit
to mmusich/cmssw
that referenced
this pull request
Jan 24, 2026
These updates correspond to the updates towards the first version "V1.0" of the GRun menu for the 2025 pp data-taking. This update includes the integration of the following JIRA tickets: - [CMSHLT-3652](https://its.cern.ch/jira/browse/CMSHLT-3652) [ECAL,EGM,Scouting] exclude the bad ECAL crystals from the ECAL RecHits producer - [CMSHLT-3710](https://its.cern.ch/jira/browse/CMSHLT-3710) [DQM,TRK] Revert CMSHLT-3691: complete removal of DQM plugins from DQM_{HI}PixelReconstruction_v (revert the revert) - [CMSHLT-3712](https://its.cern.ch/jira/browse/CMSHLT-3712) [DQM,NGT] Change HLT Event Content of LocalTestDataScouting (renamed to DQMTestDataScouting) It also contains the removal of obsolete CUDA ES modules `SiPixelGainCalibrationForHLTGPUESProducer` and `SiPixelROCsStatusAndMappingWrapperESProducer` removed in PR cms-sw#49799
mmusich
added a commit
to mmusich/cmssw
that referenced
this pull request
Jan 24, 2026
These updates correspond to the updates towards the first version "V1.0" of the GRun menu for the 2025 pp data-taking. This update includes the integration of the following JIRA tickets: - [CMSHLT-3652](https://its.cern.ch/jira/browse/CMSHLT-3652) [ECAL,EGM,Scouting] exclude the bad ECAL crystals from the ECAL RecHits producer - [CMSHLT-3710](https://its.cern.ch/jira/browse/CMSHLT-3710) [DQM,TRK] Revert CMSHLT-3691: complete removal of DQM plugins from DQM_{HI}PixelReconstruction_v (revert the revert) - [CMSHLT-3712](https://its.cern.ch/jira/browse/CMSHLT-3712) [DQM,NGT] Change HLT Event Content of LocalTestDataScouting (renamed to DQMTestDataScouting) It also contains the removal of obsolete CUDA ES modules `SiPixelGainCalibrationForHLTGPUESProducer` and `SiPixelROCsStatusAndMappingWrapperESProducer` removed in PR cms-sw#49799
mmusich
added a commit
to cms-tsg-storm/cmssw
that referenced
this pull request
Jan 24, 2026
These updates correspond to the updates towards the first version "V1.0" of the GRun menu for the 2025 pp data-taking. This update includes the integration of the following JIRA tickets: - [CMSHLT-3652](https://its.cern.ch/jira/browse/CMSHLT-3652) [ECAL,EGM,Scouting] exclude the bad ECAL crystals from the ECAL RecHits producer - [CMSHLT-3710](https://its.cern.ch/jira/browse/CMSHLT-3710) [DQM,TRK] Revert CMSHLT-3691: complete removal of DQM plugins from DQM_{HI}PixelReconstruction_v (revert the revert) - [CMSHLT-3712](https://its.cern.ch/jira/browse/CMSHLT-3712) [DQM,NGT] Change HLT Event Content of LocalTestDataScouting (renamed to DQMTestDataScouting) It also contains the removal of obsolete CUDA ES modules `SiPixelGainCalibrationForHLTGPUESProducer` and `SiPixelROCsStatusAndMappingWrapperESProducer` removed in PR cms-sw#49799
This was referenced Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Remove legacy CUDA pixel EventSetup modules.
PR validation:
All unit and matrix tests should pass.