-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[Backport to 16_0_X (#49724)] Use Pedestal Width for ZS During HBHE TP Formation #49743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: CMSSW_16_0_X
Are you sure you want to change the base?
Conversation
|
A new Pull Request was created by @JHiltbrand for CMSSW_16_0_X. It involves the following packages:
@Alejandro1400, @BenjaminRS, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @quinnanm can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
Pull request #49743 was updated. @Alejandro1400, @BenjaminRS, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @quinnanm can you please check and sign again. |
9b8123b to
29ef3ec
Compare
|
Pull request #49743 was updated. @Alejandro1400, @BenjaminRS, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @quinnanm can you please check and sign again. |
|
backport of #49724 |
PR description:
This PR adds functionality to perform zero suppression during trigger primitive formation for the HCAL barrel and endcap. The ZS threshold is configured as some amount of pedestal widths (per-channel), where the widths are simply taken from the conditions database. The amount of widths to use is anticipated to be stored in the third byte of the
auxi1parameter of theHcalTPParameterscondition. The value extracted from this condition parameter is assumed to be fixed-point with a scale factor of 16 to allow for a final fractional value to be used as the number of widths. E.g. a third byte value of 21 results in a number of widths of 1.3125.Historically, the third byte (and all) of
auxi1ofHcalTPParametershas been unused and set to 0 (only recently as of PR #49012 has the first and second bytes been used). Thus, with the default value of 0 for the third byte, the aforementioned functionality is not activated and no changes are expected in TPs or LUT XMLs. Once the third byte of theHcalTPParameterauxi1parameter is filled, the new functionality is activated. Python configuration overrides are also made available, but they are also off by default.PR validation:
Ran the local LUT XML production workflow and manipulated the third byte of
auxi1ofHcalTPParametersto yield changes in the LUT consistent with the effect of zero suppression.A talk was given to L1T DPG over-viewing this development with example impact on TPs for a number of pedestal widths of 3
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a backport of #49724 to 16_0_X
ATTN: @akhukhun