Skip to content

Conversation

@JHiltbrand
Copy link

PR description:

This PR adds functionality to perform zero suppression during trigger primitive formation for the HCAL barrel and endcap. The ZS threshold is configured as some amount of pedestal widths (per-channel), where the widths are simply taken from the conditions database. The amount of widths to use is anticipated to be stored in the third byte of the auxi1 parameter of the HcalTPParameters condition. The value extracted from this condition parameter is assumed to be fixed-point with a scale factor of 16 to allow for a final fractional value to be used as the number of widths. E.g. a third byte value of 21 results in a number of widths of 1.3125.

Historically, the third byte (and all) of auxi1 of HcalTPParameters has been unused and set to 0 (only recently as of PR #49012 has the first and second bytes been used). Thus, with the default value of 0 for the third byte, the aforementioned functionality is not activated and no changes are expected in TPs or LUT XMLs. Once the third byte of the HcalTPParameter auxi1 parameter is filled, the new functionality is activated. Python configuration overrides are also made available, but they are also off by default.

PR validation:

Ran the local LUT XML production workflow and manipulated the third byte of auxi1 of HcalTPParameters to yield changes in the LUT consistent with the effect of zero suppression.

A talk was given to L1T DPG over-viewing this development with example impact on TPs for a number of pedestal widths of 3

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #49724 to 16_0_X

ATTN: @akhukhun

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2026

A new Pull Request was created by @JHiltbrand for CMSSW_16_0_X.

It involves the following packages:

  • CalibCalorimetry/HcalTPGAlgos (alca, l1)
  • CalibCalorimetry/HcalTPGEventSetup (alca, l1)
  • SimCalorimetry/HcalTrigPrimProducers (l1)

@Alejandro1400, @BenjaminRS, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @quinnanm can you please review it and eventually sign? Thanks.
@abdoulline, @bsunanda, @missirol, @mmusich, @rovere, @rsreds, @sameasy, @tocheng, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2026

cms-bot internal usage

@quinnanm
Copy link
Contributor

quinnanm commented Jan 9, 2026

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2026

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d43844/50485/summary.html
COMMIT: d8e4690
CMSSW: CMSSW_16_0_X_2026-01-08-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49743/50485/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280553
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280522
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #49743 was updated. @Alejandro1400, @BenjaminRS, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @quinnanm can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #49743 was updated. @Alejandro1400, @BenjaminRS, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @quinnanm can you please check and sign again.

@perrotta
Copy link
Contributor

backport of #49724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants