Remove most dictionaries of CUDADataFormats #49656

makortel · 2025-12-17T14:25:53Z

PR description:

These caused rootcling to hang in CPP23 build (where CUDA was disabled). At this point (of CUDA-to-Alpaka migration) the dictionaries are not needed anymore.

The dictionaries of CUDADataFormats/Common is still kept because of #49656 (comment).

Resolves #49653
Resolves cms-sw/framework-team#1726

PR validation:

None

cmsbuild · 2025-12-17T14:26:24Z

cms-bot internal usage

cmsbuild · 2025-12-17T14:27:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49656/47201

cmsbuild · 2025-12-17T14:27:48Z

A new Pull Request was created by @makortel for master.

It involves the following packages:

CUDADataFormats/BeamSpot (heterogeneous, reconstruction)
CUDADataFormats/CaloCommon (heterogeneous, reconstruction)
CUDADataFormats/Common (heterogeneous)
CUDADataFormats/EcalDigi (heterogeneous, reconstruction)
CUDADataFormats/EcalRecHitSoA (heterogeneous, reconstruction)
CUDADataFormats/HGCal (heterogeneous, reconstruction)
CUDADataFormats/PortableTestObjects (heterogeneous)
CUDADataFormats/SiPixelCluster (heterogeneous, reconstruction)
CUDADataFormats/SiPixelDigi (heterogeneous, reconstruction)
CUDADataFormats/SiStripCluster (heterogeneous, reconstruction)
CUDADataFormats/StdDictionaries (heterogeneous)
CUDADataFormats/Track (heterogeneous, reconstruction)
CUDADataFormats/TrackingRecHit (heterogeneous, reconstruction)
CUDADataFormats/Vertex (heterogeneous, reconstruction)

@Moanwar, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @jlidrych, @missirol, @mmusich, @rchatter, @rovere, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2025-12-17T14:28:16Z

enable gpu

makortel · 2025-12-17T14:28:21Z

@cmsbuild, please test

fwyzard · 2025-12-17T14:29:29Z

CUDADataFormats/StdDictionaries is left empty, leaving only the BuildFile.xml.
Can you remove full package ?

makortel · 2025-12-17T14:30:24Z

@cmsbuild, please abort

cmsbuild · 2025-12-17T14:32:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49656/47202

There are other open Pull requests which might conflict with changes you have proposed:
- File CUDADataFormats/BeamSpot/src/classes.h modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/BeamSpot/src/classes_def.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/SiPixelCluster/src/classes.h modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/SiPixelCluster/src/classes_def.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/SiPixelDigi/src/classes.h modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/SiPixelDigi/src/classes_def.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/Track/src/classes.h modified in PR(s): New Heterogeneous Memory Pool #37952, Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): New Heterogeneous Memory Pool #37952, Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/TrackingRecHit/src/classes.h modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/TrackingRecHit/src/classes_def.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/Vertex/src/classes.h modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File CUDADataFormats/Vertex/src/classes_def.xml modified in PR(s): New Heterogeneous Memory Pool #37952, Remove legacy CUDA modules for pixel track and vertex reconstruction #45853

cmsbuild · 2025-12-18T15:43:02Z

Pull request #49656 was updated. @Moanwar, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please check and sign again.

makortel · 2025-12-18T15:43:32Z

test parameters:

gpu = nvidia_l40s,amd_w7900

makortel · 2025-12-18T15:43:37Z

@cmsbuild, please test

cmsbuild · 2025-12-18T21:45:45Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffd65a/50345/summary.html
COMMIT: 5acc55e
CMSSW: CMSSW_16_0_X_2025-12-18-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_W7900,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49656/50345/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 9 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4513798
DQMHistoTests: Total failures: 78
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4513700
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
Checked 235 log files, 208 edm output root files, 55 DQM output files
TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

You potentially removed 15 lines from the logs
Reco comparison results: 257 differences found in the comparisons
Reco comparison had 6 failed jobs
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 149371
DQMHistoTests: Total failures: 31403
DQMHistoTests: Total nulls: 12
DQMHistoTests: Total successes: 117956
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 236 differences found in the comparisons
Reco comparison had 6 failed jobs
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 149371
DQMHistoTests: Total failures: 28665
DQMHistoTests: Total nulls: 7
DQMHistoTests: Total successes: 120699
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: no differences found

makortel · 2025-12-18T22:00:54Z

CPU comparison differences are related to #47071

makortel · 2025-12-18T22:01:18Z

+heterogeneous

Per #49653 (comment)

jfernan2 · 2025-12-19T12:07:36Z

+1

cmsbuild · 2025-12-19T12:08:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-12-19T21:46:18Z

+1

mandrenguyen · 2025-12-22T07:45:35Z

@makortel There are a few dictionary not found type errors in recent IBs.
This PR seems likely to be implicated.

makortel · 2025-12-22T15:11:50Z

Thanks, investigating

makortel · 2025-12-22T15:35:15Z

The CUDA-based DQM modules are still being pulled into the configurations...

makortel · 2025-12-22T17:06:22Z

Fixed in #49697

cmsbuild added this to the CMSSW_16_0_X milestone Dec 17, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending tracking trk changes-dataformats labels Dec 17, 2025

makortel mentioned this pull request Dec 17, 2025

[CPP23]: rootcling hangs for few packages #49653

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 17, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 17, 2025

cmsbuild added tests-pending and removed tests-started labels Dec 17, 2025

makortel force-pushed the cudaDataFormatsDictionary branch from 954b8a4 to c7e37f6 Compare December 17, 2025 14:30

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 17, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 17, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 18, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 18, 2025

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels Dec 18, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Dec 19, 2025

cmsbuild added orp-approved and removed orp-pending labels Dec 19, 2025

cmsbuild merged commit 1019074 into cms-sw:master Dec 19, 2025
16 checks passed

makortel deleted the cudaDataFormatsDictionary branch December 19, 2025 22:34

cmsbuild mentioned this pull request Dec 20, 2025

Infrastructure for HCAL channel-dependent pulse shapes using database configurations #49556

Open

makortel mentioned this pull request Dec 22, 2025

Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous #49697

Merged

makortel mentioned this pull request Dec 22, 2025

Drop support for native CUDA code #45844

Open

56 tasks

Remove most dictionaries of CUDADataFormats #49656

Remove most dictionaries of CUDADataFormats #49656

Uh oh!

Conversation

makortel commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 17, 2025

Uh oh!

makortel commented Dec 17, 2025

Uh oh!

makortel commented Dec 17, 2025

Uh oh!

fwyzard commented Dec 17, 2025

Uh oh!

makortel commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 18, 2025

Uh oh!

makortel commented Dec 18, 2025

Uh oh!

makortel commented Dec 18, 2025

Uh oh!

cmsbuild commented Dec 18, 2025

Comparison Summary

AMD_W7900 Comparison Summary

NVIDIA_L40S Comparison Summary

Uh oh!

makortel commented Dec 18, 2025

Uh oh!

makortel commented Dec 18, 2025

Uh oh!

jfernan2 commented Dec 19, 2025

Uh oh!

cmsbuild commented Dec 19, 2025

Uh oh!

mandrenguyen commented Dec 19, 2025

Uh oh!

Uh oh!

mandrenguyen commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

makortel commented Dec 17, 2025 •

edited

Loading

cmsbuild commented Dec 17, 2025 •

edited

Loading