Rename AdaptorConfig to TFileAdaptor #49654

Dr15Jones · 2025-12-17T14:04:48Z

PR description:

removed unnecessary specification of the service
renamed the service to match its C++ class name

PR validation:

Code compiles. Framework unit tests pass.

resolves cms-sw/framework-team#1717

No code in CMSSW can now read these configurations.

The framework already adds AdaptorConfig to all configurations.

cmsbuild · 2025-12-17T14:05:17Z

cms-bot internal usage

Dr15Jones · 2025-12-17T14:06:05Z

please test

cmsbuild · 2025-12-17T14:07:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49654/47198

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): Move dqmoffline_step from EndPath to Path #49385
- File DQM/Integration/python/clients/csc_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_approx_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2025-12-17T14:07:25Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

Configuration/Applications (operations)
DQM/CSCMonitorModule (dqm)
DQM/Integration (dqm)
DQM/MuonMonitor (dqm)
DQM/SiPixelCommon (dqm)
DQM/SiPixelMonitorClient (dqm)
DQM/SiPixelMonitorTrack (dqm)
DQM/SiPixelPhase1Config (dqm)
DQM/SiStripMonitorClient (dqm)
DQM/SiStripMonitorCluster (dqm)
DQM/SiStripMonitorDigi (dqm)
DQM/SiStripMonitorTrack (dqm)
DQM/TrackingMonitor (dqm)
FWCore/Framework (core)
FWCore/MessageService (core)
FWStorage/Services (core)
FWStorage/StorageFactory (core)
FWStorage/TFileAdaptor (core)
FWStorage/XrdAdaptor (core)
IOPool/Common (core)
IOPool/Input (core)
SimTracker/TrackerFilters (simulation)

@Dr15Jones, @civanch, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @nothingface0, @rseidita, @smuzaffar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @arossi83, @barvic, @batinkov, @dgulhan, @elusian, @fabiocos, @fioriNTU, @francescobrivio, @idebruyn, @jandrea, @makortel, @mmasciov, @mmusich, @mtosi, @ptcox, @richa2710, @rovere, @sroychow, @threus, @venturia, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-12-17T16:07:38Z

+1

Size: This PR adds an extra 220KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfd945/50316/summary.html
COMMIT: bff31a8
CMSSW: CMSSW_16_0_X_2025-12-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49654/50316/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 5 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4513634
DQMHistoTests: Total failures: 81
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4513533
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
Checked 235 log files, 208 edm output root files, 55 DQM output files
TriggerResults: no differences found

civanch · 2025-12-17T19:18:00Z

+1

makortel

Looks good. I think this PR is for 16_1_X (given the closeness of the build of 16_0_0_pre4).

FWStorage/TFileAdaptor/test/test_AdaptorConfig.C

cmsbuild · 2025-12-17T21:46:19Z

+1

Size: This PR adds an extra 164KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfd945/50326/summary.html
COMMIT: 3690d77
CMSSW: CMSSW_16_0_X_2025-12-17-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49654/50326/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 9 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4513798
DQMHistoTests: Total failures: 61
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4513717
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
Checked 235 log files, 208 edm output root files, 55 DQM output files
TriggerResults: no differences found

nothingface0 · 2025-12-18T08:45:07Z

DQM/CSCMonitorModule/python/test/csc_dqm_sourceclient-file_cfg.py

 #--------------------------

 process.ModuleWebRegistry = cms.Service("ModuleWebRegistry")
-process.AdaptorConfig = cms.Service("AdaptorConfig")


Excuse the ignorance, but why are all those lines removed?

process.AdaptorConfig = cms.Service("AdaptorConfig

Are they not needed, in the sense that the service is added/instantiated by default somewhere else?

Yes, since the very beginning of CMSSW, that service has been automatically added to the system.

cmsbuild · 2025-12-18T13:00:46Z

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

makortel · 2025-12-18T15:10:33Z

Comparison differences are related to #47071

makortel · 2025-12-18T15:10:49Z

+core

Now that master branch moved to 16_1_X

nothingface0 · 2025-12-19T09:33:52Z

+dqm

cmsbuild · 2025-12-19T09:34:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-12-19T21:50:43Z

+1

Dr15Jones added 2 commits December 17, 2025 07:49

Removed old configuration language configuration

4061d63

No code in CMSSW can now read these configurations.

Removed declaration of AdaptorConfig Service

47551b9

The framework already adds AdaptorConfig to all configurations.

cmsbuild added this to the CMSSW_16_0_X milestone Dec 17, 2025

cmsbuild added simulation-pending dqm-pending core-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending tracking trk labels Dec 17, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 17, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 17, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Dec 17, 2025

cmsbuild added simulation-approved and removed simulation-pending labels Dec 17, 2025

makortel reviewed Dec 17, 2025

View reviewed changes

FWStorage/TFileAdaptor/test/test_AdaptorConfig.C Outdated Show resolved Hide resolved

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Dec 17, 2025

nothingface0 reviewed Dec 18, 2025

View reviewed changes

cmsbuild modified the milestones: CMSSW_16_0_X, CMSSW_16_1_X Dec 18, 2025

cmsbuild added core-approved and removed core-pending labels Dec 18, 2025

cmsbuild mentioned this pull request Dec 18, 2025

Make --secondfilein and on-the-fly pileup workflows to use RNTuple when --use-rntuple is specified #49674

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Dec 19, 2025

cmsbuild added orp-approved and removed orp-pending labels Dec 19, 2025

cmsbuild merged commit a01ed44 into cms-sw:master Dec 19, 2025
10 checks passed

cmsbuild mentioned this pull request Dec 20, 2025

Infrastructure for HCAL channel-dependent pulse shapes using database configurations #49556

Open

Dr15Jones deleted the TFileAdaptor branch January 26, 2026 14:30

Rename AdaptorConfig to TFileAdaptor #49654

Rename AdaptorConfig to TFileAdaptor #49654

Uh oh!

Conversation

Dr15Jones commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr15Jones commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 17, 2025

Uh oh!

cmsbuild commented Dec 17, 2025

Comparison Summary

Uh oh!

civanch commented Dec 17, 2025

Uh oh!

makortel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cmsbuild commented Dec 17, 2025

Comparison Summary

Uh oh!

nothingface0 Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dr15Jones Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Dec 18, 2025

Uh oh!

makortel commented Dec 18, 2025

Uh oh!

makortel commented Dec 18, 2025

Uh oh!

nothingface0 commented Dec 19, 2025

Uh oh!

cmsbuild commented Dec 19, 2025

Uh oh!

mandrenguyen commented Dec 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Dr15Jones commented Dec 17, 2025 •

edited

Loading

cmsbuild commented Dec 17, 2025 •

edited

Loading

nothingface0 Dec 18, 2025 •

edited

Loading