Skip to content

Conversation

@Moanwar
Copy link
Contributor

@Moanwar Moanwar commented Dec 17, 2025

This PR introduces a new GNN-based linking method between tracks and tracksters within TICLv5. The method builds a graph consisting of tracks and their surrounding tracksters, and then uses a Graph Neural Network (GNN) to evaluate whether each track-trackster edge is valid. Tracksters that are predicted to be linked to a given track are then stored accordingly.

In the current implementation, the linking selection is prioritized using the track pT and the DeltaR between the track and tracksters. This strategy may be refined in the future for further optimization.

A new procmodifier has been added to enable this method in workflows *.211. The process modifier is named ticlv5_TrackLinkingGNN.

This PR should be tested with TICL workflows such as 29888.211 and 29688.211, using the GNN models uploaded here:
cms-data/RecoHGCal-TICL#11

Adding : @felicepantaleo @hatakeyamak @waredjeb @AuroraPerego

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2025

cms-bot internal usage

@Moanwar
Copy link
Contributor Author

Moanwar commented Dec 17, 2025

test parameters:
pull_request = cms-data/RecoHGCal-TICL#11
workflow_opts = -w upgrade
workflows = 29888.211,29688.211

@Moanwar
Copy link
Contributor Author

Moanwar commented Dec 17, 2025

please test

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49652/47196

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@Moanwar
Copy link
Contributor Author

Moanwar commented Dec 17, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49652/47197

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2026

Pull request #49652 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @miquork, @mmusich, @srimanob can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jan 6, 2026

+hlt

  • provided the bot agrees

@Moanwar
Copy link
Contributor Author

Moanwar commented Jan 7, 2026

+1

@Moanwar
Copy link
Contributor Author

Moanwar commented Jan 11, 2026

@cms-sw/pdmv-l2 can you please check , and sign please ?

@AdrianoDee
Copy link
Contributor

+pdmv

@mmusich
Copy link
Contributor

mmusich commented Jan 11, 2026

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-553e9c/50506/summary.html
COMMIT: 9f2c67c
CMSSW: CMSSW_16_1_X_2026-01-11-0000/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49652/50506/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart
DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4167425
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4167402
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/RecoHGCal-TICL#11

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fc98c65 into cms-sw:master Jan 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants