Skip to content

Conversation

@ariostas
Copy link
Contributor

This is a port of #49239 to master. I missed this commit while porting the developments of the NanoAODRNtupleOutputModule in #49551, which is now causing a conflict between the master and RNTUPLE_X branches.

This allows all the values in ROOT::RNTupleWriteOptions to be
set from the configuration.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49641/47180

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ariostas for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@battibass, @cmsbuild, @ftorrresd can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@ariostas
Copy link
Contributor Author

@smuzaffar @Dr15Jones fyi

@makortel
Copy link
Contributor

@cmsbuild, please test

@makortel
Copy link
Contributor

@cms-sw/xpog-l2 @cms-sw/orp-l2 It would be great if this PR manages to get in pre4, but I would not hold pre4 for this PR alone.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5472e2/50008/summary.html
COMMIT: 518125c
CMSSW: CMSSW_16_0_X_2025-12-16-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49641/50008/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280229
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280200
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@ftorrresd
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit be4a4bf into cms-sw:master Dec 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants