-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add rntupleWriteOptions param to NanoAODRNtupleOutputModule [port from RNTUPLE_X] #49641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rntupleWriteOptions param to NanoAODRNtupleOutputModule [port from RNTUPLE_X] #49641
Conversation
This allows all the values in ROOT::RNTupleWriteOptions to be set from the configuration.
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49641/47180
|
|
A new Pull Request was created by @ariostas for master. It involves the following packages:
@battibass, @cmsbuild, @ftorrresd can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@smuzaffar @Dr15Jones fyi |
|
@cmsbuild, please test |
|
@cms-sw/xpog-l2 @cms-sw/orp-l2 It would be great if this PR manages to get in pre4, but I would not hold pre4 for this PR alone. |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+xpog |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This is a port of #49239 to master. I missed this commit while porting the developments of the NanoAODRNtupleOutputModule in #49551, which is now causing a conflict between the
masterandRNTUPLE_Xbranches.