[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

jfernan2 · 2025-12-10T10:41:55Z

PR description:

This PR implements recent changes with bug fixes and upgrades in the L1T DT Trigger Phase-2 emulator:

Fix to DT Digis plugin from Karol Bunkowski ( @kbunkow ) which prevents crashes due to pointers to local variables stored in vectors, and then these vectors (so also the pointers) were used outside those methods
Removed t0 Phi replacement in theta Digis at the ThetaMatching filter to preserve original t0 for the Barrel Filter objects pairing
New DataFormat collection for DT Phase Phi-Theta matched pairs L1Phase2MuDTExtPhiThetaPair and its container L1Phase2MuDTExtPhiThetaPairContainer to be used by the Phase2 Barrel Filter
Create new plugin DTTrigPhase2PairsProd which takes Phi and Theta DT Phase-2 digi Extended collections[1] and creates a new class container of the 4 best closest Phi-Theta digi pairs per DT chamber based on the time-position phase-space distance and ordered by Phi quality. For those cases where there is no Phi/Theta partner, 4 best quality single Phi/Theta digis are saved and counterpart in pair is set to default values of the constructor digi class (quality = -1, positions = 0).
[1] Requires df_extended>0 in L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc
Add DT Phase-2 Digi pair production to the standard L1 Trigger sequence
Add DT Phase-2 Digi and Digi pair collections to the L1 Trigger default Event Content
General cleaning of the code

Link to the presentation in the Phase-2 L1T Muon Subsystem group meeting on 22/01/2026

PR validation:

Local validation within CMSSW and w.r.t. firmware (w.i.p.)

…ring

cmsbuild · 2025-12-10T10:42:30Z

cms-bot internal usage

cmsbuild · 2025-12-10T10:43:59Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-22T16:18:54Z

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DataFormats/L1DTTrackFinder (l1)
L1Trigger/Configuration (l1)
L1Trigger/DTTriggerPhase2 (l1)

@BenjaminRS, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2026-01-22T18:30:09Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e088c/50815/summary.html
COMMIT: 773c3ac
CMSSW: CMSSW_16_1_X_2026-01-22-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49589/50815/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4167547
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4167527
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

jfernan2 · 2026-01-28T18:04:51Z

@cms-sw/l1-l2 kind ping, the PR es ready to review

jfernan2 · 2026-02-04T17:30:00Z

@cms-sw/l1-l2 kind ping, the PR es ready to review

DataFormats/L1DTTrackFinder/interface/L1Phase2MuDTExtPhiThetaPairContainer.h

L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2PairsProd.cc

jfernan2 · 2026-02-10T19:05:05Z

please test

cmsbuild · 2026-02-10T19:07:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/48001

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): Updates L1T OMTF for Phase 2 #50032

cmsbuild · 2026-02-10T19:07:48Z

Pull request #49589 was updated. @BenjaminRS, @quinnanm can you please check and sign again.

cmsbuild · 2026-02-10T21:19:00Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e088c/51241/summary.html
COMMIT: d64ece3
CMSSW: CMSSW_16_1_X_2026-02-10-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49589/51241/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4173926
DQMHistoTests: Total failures: 168
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4173738
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

jfernan2 · 2026-02-12T12:06:04Z

Failure is unrelated

jfernan2 · 2026-02-12T12:10:59Z

please test

cmsbuild · 2026-02-12T14:22:40Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e088c/51293/summary.html
COMMIT: d64ece3
CMSSW: CMSSW_16_1_X_2026-02-11-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49589/51293/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4173926
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4173903
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

jfernan2 added 16 commits November 21, 2025 11:23

Fix to plugin from Karol Bunkowski

dd679bd

Removed unused collection

02555c7

First plugin version

d1f475e

Changes to avoid warning from deperecation

d31c206

Additional changes

5ce8cfd

Additional changes

279edd4

Add Digis and Pairs of digis to event content

cdf059b

First cleaning

3cc7167

Add Pair Digi produciton to the L1 sequence

39fcd97

Changes to debug a crash

6f443aa

Working version

d84da11

Add filter on possible duplicates

da9d079

Code format

d2c192d

Added description

18c0f39

Fixed small bug

b78a050

Removed t0 replacement for thetaDigis to preserve original t0 for pai…

3c95d2d

…ring

cmsbuild added this to the CMSSW_16_0_X milestone Dec 10, 2025

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Dec 10, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 10, 2025

Last code format

ec4ff95

cmsbuild added code-checks-pending and removed code-checks-rejected labels Dec 10, 2025

cmsbuild added tests-started and removed tests-approved labels Jan 22, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 22, 2026

mbluj mentioned this pull request Feb 4, 2026

Updates L1T OMTF for Phase 2 #50032

Open

quinnanm reviewed Feb 6, 2026

View reviewed changes

Comments from Melissa Quinnan

d64ece3

cmsbuild added tests-started code-checks-pending and removed tests-approved code-checks-approved labels Feb 10, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 10, 2026

cmsbuild added tests-rejected and removed tests-started labels Feb 10, 2026

cmsbuild added tests-started and removed tests-rejected labels Feb 12, 2026

cmsbuild added tests-approved and removed tests-started labels Feb 12, 2026

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

Are you sure you want to change the base?

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

Uh oh!

Conversation

jfernan2 commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 10, 2025

Uh oh!

cmsbuild commented Jan 22, 2026

Uh oh!

cmsbuild commented Jan 22, 2026

Comparison Summary

Uh oh!

jfernan2 commented Jan 28, 2026

Uh oh!

jfernan2 commented Feb 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jfernan2 commented Feb 10, 2026

Uh oh!

cmsbuild commented Feb 10, 2026

Uh oh!

cmsbuild commented Feb 10, 2026

Uh oh!

cmsbuild commented Feb 10, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

jfernan2 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfernan2 commented Feb 12, 2026

Uh oh!

cmsbuild commented Feb 12, 2026

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jfernan2 commented Dec 10, 2025 •

edited

Loading

cmsbuild commented Dec 10, 2025 •

edited

Loading

jfernan2 commented Feb 12, 2026 •

edited

Loading