Skip to content

[RECONSTRUCTION] [LLVM21] Apply clang-tidy changes #49496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 1 commit into from
Nov 29, 2025
Merged

[RECONSTRUCTION] [LLVM21] Apply clang-tidy changes #49496

cmsbuild merged 1 commit into from
Nov 29, 2025

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 26, 2025

This PR suggests to apply the clang-tidy changes proposed by LLVM21 ( from CLANG_X IB).

@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Nov 26, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49496/46979

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2025

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DataFormats/JetReco (reconstruction)
  • DataFormats/ParticleFlowCandidate (reconstruction)
  • DataFormats/TauReco (reconstruction)
  • EventFilter/CSCRawToDigi (reconstruction)
  • JetMETCorrections/Modules (reconstruction)
  • MagneticField/GeomBuilder (reconstruction)
  • RecoBTag/SecondaryVertex (reconstruction)
  • RecoEcal/EgammaClusterAlgos (reconstruction)
  • RecoEcal/EgammaClusterProducers (reconstruction)
  • RecoEcal/EgammaCoreTools (reconstruction)
  • RecoEgamma/EgammaElectronProducers (reconstruction)
  • RecoEgamma/EgammaIsolationAlgos (reconstruction)
  • RecoEgamma/EgammaPhotonAlgos (reconstruction)
  • RecoEgamma/EgammaPhotonProducers (reconstruction)
  • RecoEgamma/EgammaTools (reconstruction)
  • RecoHGCal/TICL (reconstruction)
  • RecoHI/HiJetAlgos (reconstruction)
  • RecoJets/JetAlgorithms (reconstruction)
  • RecoJets/JetProducers (reconstruction)
  • RecoLocalCalo/CaloTowersCreator (reconstruction)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalCalo/HcalLaserReco (reconstruction)
  • RecoLocalMuon/CSCEfficiency (reconstruction)
  • RecoLocalMuon/DTSegment (reconstruction)
  • RecoLuminosity/LumiProducer (reconstruction)
  • RecoMET/METPUSubtraction (reconstruction)
  • RecoMuon/MuonIdentification (reconstruction)
  • RecoMuon/MuonSeedGenerator (reconstruction)
  • RecoMuon/TrackingTools (reconstruction)
  • RecoPPS/Local (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoParticleFlow/PFProducer (reconstruction)
  • RecoParticleFlow/PFTracking (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)
  • RecoTracker/DeDx (reconstruction)
  • RecoTracker/FinalTrackSelectors (reconstruction)
  • RecoTracker/PixelTrackFitting (reconstruction)
  • RecoTracker/SingleTrackPattern (reconstruction)
  • RecoTracker/SpecialSeedGenerators (reconstruction)
  • RecoTracker/TkDetLayers (reconstruction)
  • RecoTracker/TkSeedGenerator (reconstruction)
  • RecoTracker/TrackProducer (reconstruction)
  • RecoVertex/KinematicFit (reconstruction)
  • RecoVertex/LinearizationPointFinders (reconstruction)
  • RecoVertex/PrimaryVertexProducer (reconstruction)
  • TrackingTools/TrackRefitter (reconstruction)
  • TrackingTools/TrajectoryState (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@24LopezR, @AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @Ming-Yan, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @abdoulline, @afiqaize, @ahinzmann, @andrzejnovak, @apsallid, @argiro, @azotz, @barvic, @battibass, @bellan, @bsunanda, @castaned, @cericeci, @clelange, @denizsun, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @forthommel, @fsimone91, @gkasieczka, @gouskos, @gpetruc, @grzanka, @hatakeyamak, @jainshilpi, @jazzitup, @jdamgov, @jdolen, @jhgoh, @kurtejung, @lecriste, @lgray, @llunerti, @mandrenguyen, @mariadalfonso, @martinamalberti, @mbluj, @missirol, @mmarionncern, @mmasciov, @mmusich, @mtosi, @namapane, @nhanvtran, @pavlo-kashko, @philippgadow, @ptcox, @ram1123, @rappoccio, @rchatter, @rociovilar, @rovere, @salimcerci, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @thomreis, @trocino, @valsdav, @varuns23, @wang0jin, @yenjie, @yetkinyilmaz, @youyingli, @yslai this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 28, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-044cee/49727/summary.html
COMMIT: 7863ba0
CMSSW: CMSSW_16_0_X_2025-11-27-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49496/49727/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4502606
  • DQMHistoTests: Total failures: 66
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4502520
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 235 log files, 208 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 28, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Nov 29, 2025

+1

@cmsbuild cmsbuild merged commit 902742c into cms-sw:master Nov 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved tracking

Projects

None yet

Milestone

CMSSW_16_0_X

Development

Successfully merging this pull request may close these issues.

4 participants

@smuzaffar @cmsbuild @jfernan2 @mandrenguyen