-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Include Eigen core library before the SoA definitions #49445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Eigen core library before the SoA definitions #49445
Conversation
|
please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49445/46923
|
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Size: This PR adds an extra 36KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Remove the inclusion of Eigen from the SoA data formats that do not use it, and add it in the files that include multiple SoA data formats so it always comes before the SoA definitions.
PR validation:
None.