-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Avoid ROOT auto parsing for PortableHostMultiCollection #49422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Memory increases when moving to ROOT 6.36 pointed to these two classes not having dictionaries explicitly defined.
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49422/46887 |
|
please test |
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
Invalid: please test for CMSSW_16_0_X_2025-11-14-2300 Just to compare the memory usage with the release where we had root 6.32 |
|
(from #49422 (comment))
(2025.0010001_RunJetMET02025C_10k is similar) 16834.0_TTbar_14TeV+2025 shows
(17034.0_TTbar_14TeV+2025PU is similar) |
|
abort test this in CMSSW_16_0_X_2025-11-14-2300 will not give any useful results as in this case both will be comparing root 6.32 vs 6.32 plus this change in CMSSW_16_0_X_2025-11-14-2300 |
|
please test sorry for starting the tests against an old IB (which was not needed). Rerunning the default tests to get the commits statuses properly updated |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
+heterogeneous |
|
@Dr15Jones so the take away message is that one should always declare the dictionary for the Normally I would suggest adding this to the |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
The best answer we can give is 'probably' as we really do not understand the actual ROOT requirements and we are just going on 'what seems to work'. |
|
The need for the Why the omission of |


PR description:
Memory increases when moving to ROOT 6.36 pointed to these two classes not having dictionaries explicitly defined.
PR validation:
Using the MaxMemoryAllocMonitor shows that running workflow 16834.0 step 2 with this change brought down overall memory by more than 500MB, to approximately the ROOT 6.32 level.
resolves cms-sw/framework-team#1692