Add bareProduct() const method

[fwyzard]

PR description:

Add bareProduct() const method to edm::Wrapper.

PR validation:

None.

[fwyzard]

please test

[fwyzard]

@makortel this should be fine ?

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49415/46870

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/Common/interface/Wrapper.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233, Add a const overload of bareProduct() and a markAsPresent() method to Wrapper.h #49236

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• DataFormats/Common (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3267d/49534/summary.html
COMMIT: 1e536e1
CMSSW: CMSSW_16_0_X_2025-11-18-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49415/49534/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @denizsun [HCAL-DQM] Additional plots: mask channels in HEP07 (RM 3, RMfib 4) affected by sporadic bad data #49394

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3267d/49534/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3267d/49534/git-merge-result

Failed Unit Tests

I found 2 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test test_edmPickEvents had ERRORS

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3896448
• DQMHistoTests: Total failures: 35
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3896393
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 188 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[fwyzard]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3267d/49536/summary.html
COMMIT: 1e536e1
CMSSW: CMSSW_16_0_X_2025-11-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49415/49536/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 2 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test test_edmPickEvents had ERRORS

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3896448
• DQMHistoTests: Total failures: 106
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3896322
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 188 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[fwyzard]

please test

[makortel]

I have no reservations for this one. I'll sign after the latest test finish.

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3267d/49550/summary.html
COMMIT: 1e536e1
CMSSW: CMSSW_16_0_X_2025-11-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49415/49550/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3896448
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3896422
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 188 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[ftenchini]

+1