Skip to content

Conversation

@kpedro88
Copy link
Contributor

PR description:

Addresses #49331:

  1. Remove now-extraneous (after Fix bugs and logic in ibeos das client #48432) ibeos-lfn-sort call from MatrixUtils
  2. Modify ibeos-lfn-sort to handle repeated calls
  3. Change default behavior to print all results (only print limited results when called by cmsDriver.py)

PR validation:

Both commands in #49331 (comment) now return identical output.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. #48432 entered 15_1, so it is probably worth backporting this to that release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)
  • Utilities/General (core)

@AdrianoDee, @DickyChant, @Dr15Jones, @antoniovagnerini, @cmsbuild, @makortel, @miquork, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

@kpedro88 , #49402 is another way to fix the recursive calls to ibeos-lfn-sort.

@kpedro88
Copy link
Contributor Author

@smuzaffar that looks the same as my solution here. (I just defined a variable for the prefix to ensure consistency and avoid repetition)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ac7d0/49512/summary.html
COMMIT: f266339
CMSSW: CMSSW_16_0_X_2025-11-17-1200/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49401/49512/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3896448
  • DQMHistoTests: Total failures: 74
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3896354
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@kpedro88
Copy link
Contributor Author

@cms-sw/pdmv-l2 @cms-sw/core-l2 ping

@AdrianoDee
Copy link
Contributor

+pdmv

@smuzaffar
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 829de75 into cms-sw:master Nov 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants