Skip to content

Conversation

@soureek
Copy link
Contributor

@soureek soureek commented Nov 12, 2025

PR description:

Updating fillDescriptions for RecoBTag/Skimming following #29265

PR validation:

Local compilation successful without any warnings.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @soureek for master.

It involves the following packages:

  • RecoBTag/Skimming (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @pavlo-kashko, @philippgadow this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8344/49429/summary.html
COMMIT: 446fee6
CMSSW: CMSSW_16_0_X_2025-11-12-1200/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49379/49429/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8344/49429/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8344/49429/git-merge-result

Comparison Summary

Summary:

  • You potentially added 187 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10022 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3880468
  • DQMHistoTests: Total failures: 69353
  • DQMHistoTests: Total nulls: 33
  • DQMHistoTests: Total successes: 3811062
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 4 / 49 workflows

@soureek
Copy link
Contributor Author

soureek commented Nov 13, 2025

@jfernan2 Please merge if everything is fine.

@jfernan2
Copy link
Contributor

+1
Differences in RECO due to commits included on top of IB + this PR after doing git cms-merge-topic

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link

+1

@cmsbuild cmsbuild merged commit d335b0b into cms-sw:master Nov 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants