Skip to content

Conversation

@Parsifal-2045
Copy link
Contributor

PR description

As a follow up to #49288 (comment) this PR drops the outdated custom parameters used for "offline" Phase 2 Alpaka PixelTracks in workflows *.402, *.403, and *.404.
The customisation itself is not needed anymore since all relevant parameters are defined in separate TrackerTraits (Phase1, Phase1HI, Phase2, and Phase2OT), meaning that the default fillDescription parameters can be used in all cases (except for the RecHits label that changes between HLT and offline-like workflows).

PR validation:

Ran over 100 events for workflows 29834,29834.402,29834.403,29834.404 with the CA_WARNINGS flag enabled and observed no issues both on plain CMSSW_16_0_X_2025-11-03-2300 and including #49282

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Nov 4, 2025

type ngt, bug-fix

@mmusich
Copy link
Contributor

mmusich commented Nov 4, 2025

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49314/46672

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2025

A new Pull Request was created by @Parsifal-2045 for master.

It involves the following packages:

  • RecoTracker/PixelTrackFitting (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @gpetruc, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Nov 4, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89636e/49250/summary.html
COMMIT: 512b527
CMSSW: CMSSW_16_0_X_2025-11-04-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49314/49250/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4172318
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4172298
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 226 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 233 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 147869
  • DQMHistoTests: Total failures: 30698
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 117162
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 3 / 10 workflows

AMD_W7900 Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

NVIDIA_L40S Comparison Summary

Summary:

NVIDIA_T4 Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 266 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 147869
  • DQMHistoTests: Total failures: 31351
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 116511
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 3 / 10 workflows

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 5, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fe7c0ff into cms-sw:master Nov 5, 2025
25 checks passed
@Parsifal-2045 Parsifal-2045 deleted the fixOfflinePixelTracksParameters branch December 19, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants