[Do not merge] LLVM21 clang-tidy changes

[smuzaffar]

These are the changes which clang-tidy from LLVM 21.1.4 suggested. Mostly it suggest

• make variable const &
• reserving std::vector size before the for loop
• added missing override

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49297/46658

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/ParticleFlowCandidate/src/PFCandidate.cc modified in PR(s): PFCandidate no longer inherits from CompositeCandidate #38999
  • File Geometry/HGCalMapping/plugins/alpaka/HGCalMappingModuleESProducer.cc modified in PR(s): Assorted fixes post HGCAL test beam #49148
  • File L1Trigger/VertexFinder/src/VertexFinder.cc modified in PR(s): [L1T] Peak Finding Algorithm for Vertex Reconstruction (Phase 2) #47020
  • File RecoBTag/SecondaryVertex/plugins/TemplatedSecondaryVertexProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319
  • File RecoHGCal/TICL/plugins/TracksterLinkingbySkeletons.cc modified in PR(s): Add directories for TICL-EGM code development #48319
  • File RecoHGCal/TICL/plugins/TrackstersPCA.h modified in PR(s): Add directories for TICL-EGM code development #48319
  • File RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoVertex/PrimaryVertexProducer/src/DAClusterizerInZ_vect.cc modified in PR(s): Parallelized offline vertexing reconstruction #46663

[cmsbuild]

+1

Size: This PR adds an extra 2092KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01728a/49210/summary.html
COMMIT: 6d0ce36
CMSSW: CMSSW_16_0_X_2025-11-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49297/49210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4172318
• DQMHistoTests: Total failures: 48
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4172250
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 226 log files, 198 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[makortel]

On a cursory read looks ok to me