-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[15.1.X] Pixel GPU Online DQM Client changes for CMSHLT-3147 #49296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.1.X] Pixel GPU Online DQM Client changes for CMSHLT-3147 #49296
Conversation
…he pixelgpu_dqm_sourceclient-live_cfg.py
…e change of event content - See [CMSHLT-3147](https://its.cern.ch/jira/browse/CMSHLT-3147) for more details.
|
test parameters: |
|
A new Pull Request was created by @mmusich for CMSSW_15_1_X. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
test parameters: |
|
please test |
|
+1 Size: This PR adds an extra 20KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
urgent |
|
thanks for the prompt action, can you confirm this will be integrated in |
while it is highly desireable to have a release including it, DQM online can still pick it up on the fly (@gabrielmscampos @nothingface0 kind ping) |
to be clear, with the menu we are going to put online, it's absolutely mandatory to have this PR included in the online DQM. |
Of course, no problem |
|
+dqm
|
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
REMINDER @sextonkennedy, @ftenchini, @mandrenguyen: This PR was tested with cms-sw/cmsdist#10169, please check if they should be merged together |
|
+1 |
|
Merging post-patch3 targeting next full build. |
backport of #49237
PR description:
This PR is opened in preparation of the integration of the ticket CMSHLT-3147.
In a nutshell that ticket suggests that the DQM plugins which are currently in the Path
DQM_PixelReconstruction_v(Sequence:HLTDQMPixelReconstruction) and in the PathDQM_PixelReconstruction_v(SequeceHLTDQMPixelReconstruction) can be removed from the HLT combined table, as long as the Tracker-DPG and/or Tracking-POG experts move the corresponding monitoring sequence into the appropriate online-DQM client (which reads theDQMGPUvsCPUstreamer files).This latter point is proposed in this PR, in which we change the client
DQM/Integration/python/clients/pixelgpu_dqm_sourceclient-live_cfg.pyto include directly the modules responsible of monitoring of the GPU vs CPU comparisons, as the input data to feed them will be sent by the inputDQMGPUvsCPUstream.PR validation:
In addition to the tests in #49237 (comment) I created a suitable set of streamer files using the following script to test the Heavy Ion menu:
and then placed the resulting files under the path
$CMSSW_BASE/src/DQM/Integration/data/run362321.After applying the following extra changes to the package:
I then run the unit test of the package via:
and I did not observe any issues.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #49237 for 2025 PbPb operations.