Skip to content

Conversation

@Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Nov 3, 2025

PR description:

  • Switch from RNTuple* to RNTupleTemp* as the latter more closely behave like their Pool* counterparts.

PR validation:

A simple test of runTheMatrix.py showed the change worked.

resolves cms-sw/framework-team#1559

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

A new Pull Request was created by @Dr15Jones for CMSSW_16_0_RNTUPLE_X.

It involves the following packages:

  • Configuration/Applications (operations)

@davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d11c41/49204/summary.html
COMMIT: adca8c4
CMSSW: CMSSW_16_0_RNTUPLE_X_2025-11-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49294/49204/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test TestConfigurationApplicationsConfigBuilder had ERRORS

Failed RelVals

  • 1306.0A fatal system signal has occurred: abort signal
  • 2025.0000001A fatal system signal has occurred: abort signal
  • 2024.0070001A fatal system signal has occurred: abort signal
Expand to see more relval errors ...

-Switch from RNTuple* to RNTupleTemp* as the latter more closely
behave like their Pool* counterparts.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

Pull request #49294 was updated. @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please check and sign again.

@makortel
Copy link
Contributor

makortel commented Nov 3, 2025

It seems to me these changes could go into the master branch.

@Dr15Jones
Copy link
Contributor Author

If the tests pass, I'll close this PR and do one to master

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d11c41/49208/summary.html
COMMIT: 5d8b53d
CMSSW: CMSSW_16_0_RNTUPLE_X_2025-11-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49294/49208/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 1306.0A fatal system signal has occurred: abort signal
  • 2025.0000001A fatal system signal has occurred: abort signal
  • 2024.0070001A fatal system signal has occurred: abort signal
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

Pull request #49294 was updated. @Dr15Jones, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @makortel, @mandrenguyen, @nothingface0, @rseidita, @smuzaffar can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Nov 3, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d11c41/49214/summary.html
COMMIT: 55c5599
CMSSW: CMSSW_16_0_RNTUPLE_X_2025-11-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49294/49214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants