-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Switch to use RNTupleTemp* plugins #49294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: CMSSW_16_0_RNTUPLE_X
Are you sure you want to change the base?
Switch to use RNTupleTemp* plugins #49294
Conversation
|
please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49294/46654 |
|
A new Pull Request was created by @Dr15Jones for CMSSW_16_0_RNTUPLE_X. It involves the following packages:
@davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: UnitTests RelVals Failed Unit TestsI found 1 errors in the following unit tests: ---> test TestConfigurationApplicationsConfigBuilder had ERRORS Failed RelVals
Expand to see more relval errors ...
|
-Switch from RNTuple* to RNTupleTemp* as the latter more closely behave like their Pool* counterparts.
adca8c4 to
5d8b53d
Compare
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49294/46657 |
|
Pull request #49294 was updated. @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please check and sign again. |
|
It seems to me these changes could go into the |
|
If the tests pass, I'll close this PR and do one to |
|
-1 Failed Tests: RelVals Failed RelVals
Expand to see more relval errors ...
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49294/46660 |
|
Pull request #49294 was updated. @Dr15Jones, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @makortel, @mandrenguyen, @nothingface0, @rseidita, @smuzaffar can you please check and sign again. |
|
please test |
|
hold |
|
Pull request has been put on hold by @Dr15Jones |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d11c41/49214/summary.html Comparison SummarySummary:
|
PR description:
PR validation:
A simple test of
runTheMatrix.pyshowed the change worked.resolves cms-sw/framework-team#1559