[Do not merge] LLVM21 clang-format suggestions #49293
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsbuild
added
reconstruction-pending
simulation-pending
dqm-pending
l1-pending
hlt-pending
core-pending
analysis-pending
alca-pending
daq-pending
fastsim-pending
db-pending
generators-pending
geometry-pending
visualization-pending
pending-signatures
tests-pending
orp-pending
code-checks-pending
xpog-pending
heterogeneous-pending
tracking
trk
labels
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49293/46653 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
fwyzard
reviewed
Nov 4, 2025
| uint16_t fed_crc_error_ : 1, /* FED CRC error was detected by DTH and corrected */ | ||
| slink_crc_error_ : 1, /* Set when the slink receviver finds a mistmatch between calculated crc and daq_crc. It should never happen */ | ||
| slink_crc_error_ | ||
| : 1, /* Set when the slink receviver finds a mistmatch between calculated crc and daq_crc. It should never happen */ |
|
On a cursory look looks ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the clang-format changes we will get once we backport llvm21 (already integrated in CLANG_X IBs) to default IBs. Note that currently we have
DerivePointerAlignment: truein default IBs but llvm21/google style has changed it toDerivePointerAlignment: false. UsingDerivePointerAlignment: falsereformat over 5K files. That is why I have explicitly set it toDerivePointerAlignment: trueto avoid a big code-formatting.Note that we can not apply these changes without first integrating LLVM21 in default IBs. LLVM18 reverts most of these changes