Proper Clamping for CA Doublets Histogram #49282

AdrianoDee · 2025-11-03T08:38:23Z

PR description:

This PR proposes a small fix for the crash reported in #49186. The crash there happens because we fill the outerHitHisto histo beyond its capacity (that is defined as nHitsToCells = nHits * avgCellsPerHit). The check there is only done for maxDoublets. Now, technically, maxDoublets and nHitsToCells should be the same (given the one-to-one correspondence between a doublet and its outer hit). Having two distinct variables is inherited from how the structures were defined before #47611 (one OuterHitOfCell array per hit). In the longer term, these two numbers should be merged. For the moment, I'm just adding a small fix to have it quickly integrated in 15_1_X for HI operations.

PR validation:

Reproducer in #49186 runs without error (and we get the warnings if CA_WARNINGS is defined).

cmsbuild · 2025-11-03T08:38:49Z

cms-bot internal usage

AdrianoDee · 2025-11-03T08:40:15Z

type bug-fix

AdrianoDee · 2025-11-03T08:40:19Z

enable gpu

cmsbuild · 2025-11-03T08:41:03Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49282/46645

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49282/46645/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49282/46645/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

AdrianoDee · 2025-11-03T08:46:16Z

please test

cmsbuild · 2025-11-03T08:46:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49282/46646

cmsbuild · 2025-11-03T08:46:36Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

RecoTracker/PixelSeeding (reconstruction)

@jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @gpetruc, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2025-11-03T08:50:54Z

Sorry, this PR changes a cout and a printf - so how is this affecting code executed in order to cure the crash?

mmusich · 2025-11-03T08:53:44Z

Sorry, this PR changes a cout and a printf - so how is this affecting code executed in order to cure the crash?

I guess (based on the PR description) this is the actual fix:

-          if (ind >= maxNumOfDoublets) {
+          if (ind >= maxNumOfDoublets or ind >= uint32_t(outerHitHisto->capacity())) {

Martin-Grunewald · 2025-11-03T08:57:43Z

Ah yes, thanks!

jfernan2 · 2025-11-03T10:06:56Z

This PR is being supersed by #49286 right?

AdrianoDee · 2025-11-03T10:15:21Z

This PR is being supersed by #49286 right?

Sort of, but I would anyway integrate this as is since it's a bug fix and it would be better to have it in quickly (for HI).

cmsbuild · 2025-11-03T22:28:02Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3ab92/49192/summary.html
COMMIT: 49b8b8a
CMSSW: CMSSW_16_0_X_2025-11-02-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49282/49192/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4172318
DQMHistoTests: Total failures: 77
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4172221
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 226 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

AMD_MI300X Comparison Summary

There are some workflows for which there are errors in the baseline:
29834.402 step 3
29834.403 step 3
29834.404 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 281 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 176 differences found in the comparisons
DQMHistoTests: Total files compared: 9
DQMHistoTests: Total histograms compared: 116142
DQMHistoTests: Total failures: 10845
DQMHistoTests: Total nulls: 7
DQMHistoTests: Total successes: 105290
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
Checked 40 log files, 45 edm output root files, 9 DQM output files
TriggerResults: found differences in 1 / 8 workflows

AMD_W7900 Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 250 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 147869
DQMHistoTests: Total failures: 33244
DQMHistoTests: Total nulls: 9
DQMHistoTests: Total successes: 114616
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

There are some workflows for which there are errors in the baseline:
29834.402 step 3
29834.403 step 3
29834.404 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 251 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 174 differences found in the comparisons
DQMHistoTests: Total files compared: 9
DQMHistoTests: Total histograms compared: 116142
DQMHistoTests: Total failures: 11291
DQMHistoTests: Total nulls: 10
DQMHistoTests: Total successes: 104841
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
Checked 40 log files, 45 edm output root files, 9 DQM output files
TriggerResults: found differences in 1 / 8 workflows

NVIDIA_L40S Comparison Summary

There are some workflows for which there are errors in the baseline:
29834.402 step 3
29834.403 step 3
29834.404 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 243 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 158 differences found in the comparisons
DQMHistoTests: Total files compared: 9
DQMHistoTests: Total histograms compared: 116142
DQMHistoTests: Total failures: 16376
DQMHistoTests: Total nulls: 8
DQMHistoTests: Total successes: 99758
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
Checked 40 log files, 45 edm output root files, 9 DQM output files
TriggerResults: found differences in 1 / 8 workflows

NVIDIA_T4 Comparison Summary

There are some workflows for which there are errors in the baseline:
29834.402 step 3
29834.403 step 3
29834.404 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 278 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 186 differences found in the comparisons
DQMHistoTests: Total files compared: 9
DQMHistoTests: Total histograms compared: 116142
DQMHistoTests: Total failures: 11393
DQMHistoTests: Total nulls: 13
DQMHistoTests: Total successes: 104736
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
Checked 40 log files, 45 edm output root files, 9 DQM output files
TriggerResults: found differences in 2 / 8 workflows

mandrenguyen · 2025-11-04T08:27:22Z

urgent
Would be nice to have this in for the 11AM IB.

jfernan2 · 2025-11-04T09:11:28Z

+1

cmsbuild · 2025-11-04T09:11:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-11-04T09:19:49Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Nov 3, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Nov 3, 2025

AdrianoDee mentioned this pull request Nov 3, 2025

Proper Clamping for CA Doublets Histogram [15_1_X] #49283

Open

cmsbuild added the bug-fix label Nov 3, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 3, 2025

AdrianoDee mentioned this pull request Nov 3, 2025

Non-reproducibility and crashes related to pixel tracking (CAHitNtupletAlpakaHIonPhase1) in the HIon integration tests #49186

Open

Proper clamping for CA doublets

49b8b8a

AdrianoDee force-pushed the nHitsToCells_clamp_fix_160X branch from e0e61c0 to 49b8b8a Compare November 3, 2025 08:44

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 3, 2025

cmsbuild added tests-started code-checks-approved and removed tests-pending code-checks-pending labels Nov 3, 2025

AdrianoDee mentioned this pull request Nov 3, 2025

Not Running the CA When Starting Layers are Empty #49286

Open

cmsbuild added tests-approved and removed tests-started labels Nov 3, 2025

cmsbuild added the urgent label Nov 4, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Nov 4, 2025

cmsbuild added orp-approved and removed orp-pending labels Nov 4, 2025

cmsbuild merged commit 9a509cd into cms-sw:master Nov 4, 2025
25 checks passed

Proper Clamping for CA Doublets Histogram #49282

Proper Clamping for CA Doublets Histogram #49282

Conversation

AdrianoDee commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AdrianoDee commented Nov 3, 2025

Uh oh!

AdrianoDee commented Nov 3, 2025

Uh oh!

cmsbuild commented Nov 3, 2025

Uh oh!

AdrianoDee commented Nov 3, 2025

Uh oh!

cmsbuild commented Nov 3, 2025

Uh oh!

cmsbuild commented Nov 3, 2025

Uh oh!

Martin-Grunewald commented Nov 3, 2025

Uh oh!

mmusich commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Martin-Grunewald commented Nov 3, 2025

Uh oh!

jfernan2 commented Nov 3, 2025

Uh oh!

AdrianoDee commented Nov 3, 2025

Uh oh!

cmsbuild commented Nov 3, 2025

Comparison Summary

AMD_MI300X Comparison Summary

AMD_W7900 Comparison Summary

NVIDIA_H100 Comparison Summary

NVIDIA_L40S Comparison Summary

NVIDIA_T4 Comparison Summary

Uh oh!

mandrenguyen commented Nov 4, 2025

Uh oh!

jfernan2 commented Nov 4, 2025

Uh oh!

cmsbuild commented Nov 4, 2025

Uh oh!

mandrenguyen commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AdrianoDee commented Nov 3, 2025 •

edited

Loading

cmsbuild commented Nov 3, 2025 •

edited

Loading

mmusich commented Nov 3, 2025 •

edited

Loading