Skip to content

Conversation

@alaperto
Copy link
Contributor

@alaperto alaperto commented Oct 29, 2025

PR description:

Update number of disabled ROCs (used in calculation of the fraction of "good" ROCs for the Online DQM Pixel Summary map, see May 2024 PR #45027 ).
Since May 2024, new dead modules, i.e. Disk -1 region, DCDC modules in Ring 1, ...

PR validation:

Just update number on request of Pixel Ops team.

Backport

This PR is intended for 2025 data taking.
Backport to 15_1_X of original PR: #49305

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2025

A new Pull Request was created by @alaperto for CMSSW_15_1_X.

It involves the following packages:

  • DQM/SiPixelPhase1Summary (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @richa2710, @sroychow, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2025

cms-bot internal usage

@gabrielmscampos
Copy link
Member

test parameters:

  • addpkg = DQM/Integration

@gabrielmscampos
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-320e06/48894/summary.html
COMMIT: ac67b3d
CMSSW: CMSSW_15_1_X_2025-10-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49247/48894/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123984
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@gabrielmscampos
Copy link
Member

+dqm

  • P5 tests OK

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

I'm confused. Is this a backport?

@mandrenguyen
Copy link
Contributor

hold
Just so it doesn't get accidentally merged, while I'm waiting for an answer to my question:

I'm confused. Is this a backport?

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@alaperto
Copy link
Contributor Author

alaperto commented Nov 3, 2025

@mandrenguyen it is intended towards 2025 data taking
I'm not sure if I should target 15_0_X or 15_1_X (as pp collisions is done tomorrow)
Should I target directly 15_1_X for HI runs? and do backport towards 16_0_X ?
Sorry, could not find anywhere this info....

@mandrenguyen
Copy link
Contributor

@mandrenguyen it is intended towards 2025 data taking I'm not sure if I should target 15_0_X or 15_1_X (as pp collisions is done tomorrow) Should I target directly 15_1_X for HI runs? and do backport towards 16_0_X ? Sorry, could not find anywhere this info....

The standard recipe is to first make a PR into the master release, in this case 16_0_X. Then a backport should have been made to 15_1_X. So what is missing is a PR to the master release. Without such a PR, your changes will not propagate to future release cycles.

@alaperto alaperto changed the title Update Disabled ROCs for Online DQM Pixel Summary Update Disabled ROCs for Online DQM Pixel Summary [15_1_X] Nov 4, 2025
@gabrielmscampos
Copy link
Member

backport of #49305

@dzuolo
Copy link
Contributor

dzuolo commented Nov 4, 2025

Dear colleagues,
from the operation point of view it would be very appreciated if this merge request can be included in the software version that will be used for HI data taking. The number that are currents in the code do not reflect the reality of the detector and are misleading for DQM shifters.
Thanks a lot,
Davide
Pixel Deputy Run Coordinator

@mandrenguyen
Copy link
Contributor

Dear colleagues, from the operation point of view it would be very appreciated if this merge request can be included in the software version that will be used for HI data taking. The number that are currents in the code do not reflect the reality of the detector and are misleading for DQM shifters. Thanks a lot, Davide Pixel Deputy Run Coordinator

Of course. Just as soon as @cms-sw/dqm-l2 signs of on the master PR we can proceed with the backport.

@nothingface0
Copy link
Contributor

Of course. Just as soon as @cms-sw/dqm-l2 signs of on the master PR we can proceed with the backport.

@mandrenguyen done!

@ftenchini
Copy link

+1

@ftenchini
Copy link

unhold

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 11b6d23 into cms-sw:CMSSW_15_1_X Nov 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants