-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update Disabled ROCs for Online DQM Pixel Summary [15_1_X] #49247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Disabled ROCs for Online DQM Pixel Summary [15_1_X] #49247
Conversation
|
A new Pull Request was created by @alaperto for CMSSW_15_1_X. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
test parameters:
|
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+dqm
|
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
I'm confused. Is this a backport? |
|
hold
|
|
Pull request has been put on hold by @mandrenguyen |
|
@mandrenguyen it is intended towards 2025 data taking |
The standard recipe is to first make a PR into the master release, in this case 16_0_X. Then a backport should have been made to 15_1_X. So what is missing is a PR to the master release. Without such a PR, your changes will not propagate to future release cycles. |
|
backport of #49305 |
|
Dear colleagues, |
Of course. Just as soon as @cms-sw/dqm-l2 signs of on the master PR we can proceed with the backport. |
@mandrenguyen done! |
|
+1 |
|
unhold |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will be automatically merged. |
PR description:
Update number of disabled ROCs (used in calculation of the fraction of "good" ROCs for the Online DQM Pixel Summary map, see May 2024 PR #45027 ).
Since May 2024, new dead modules, i.e. Disk -1 region, DCDC modules in Ring 1, ...
PR validation:
Just update number on request of Pixel Ops team.
Backport
This PR is intended for 2025 data taking.
Backport to 15_1_X of original PR: #49305