-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Introduce ngt::AnyBuffer
#49235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ngt::AnyBuffer
#49235
Conversation
|
please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49235/46582
|
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@makortel @Dr15Jones the use case for Examples are the various variations of adding MPI support to CMSSW in #32632 or #49233, and the stand-alone tests in #47504 or #49152. |
|
type ngt |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
While this PR looks seemingly straightforward, I want to understand the wider context (again) first before commenting (especially #49152). It will probably take me something along a week or two to have a good moment to start digesting them. |
|
OK, understood, though we would appreciate not having to rebuild about 1000 packages every time 🤷🏻♂️ |
|
+1 |
|
Will be moved to |
ngt::AnyBuffer behaves like std::any, with two differences: it can only be used with trivially copyable types, and provides access to the underlying memory buffer to allow memcpy'ing its content.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49235/46993
|
|
@cms-sw/core-l2 we are still thinking about the new package name, but let me know if you would prefer to have this under |
|
please test |
|
+1 Size: This PR adds an extra 20KB to repository DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
|
Included in #49475. |
PR description:
ngt::AnyBufferbehaves likestd::any, with two differences: it can only be used with trivially copyable types, and provides access to the underlying memory buffer to allowmemcpy'ing its content.