[mkFit] procModifier for Phase-2 HLT tracking and track candidates selections #49231

bdanzi · 2025-10-28T09:38:47Z

PR description:

This is a procModifier-based implementation of the mkFit tracking building algorithm at HLT Phase-2. It reuses the trackingMkFitCommon procModifier to configure the internal mkFit geometry setup, and introduces the new procModifier hltTrackingMkFitInitialStep to test the mkFit building primarly in a single-iteration HLT Phase-2 tracking configuration. The mkFit tracking building algorithm can also be tested at hltInitialStep.

The PR adds support for applying selection thresholds on the transverse momentum (MinPtCut) and the minimum number of hits (MinNHitsCut) for track candidates after the forward and backward search steps of the mkFit tracking building algorithm.

The PR also fixes an inconsistency in the workflow numbering between runTheMatrix.py and upgradeWorkflowComponents.py, where the offset value did not match the corresponding workflow ID in the runTheMatrix.py comments.

A new variation of the HLT timing workflow has been added, including Patatrack seeding and a single tracking iteration with mkFit building. The implementation makes use of existing procModifiers, and can be executed through the corresponding procModifier sequence alpaka,singleIterPatatrack,trackingLST,seedingLST,trackingMkFitCommon,hltTrackingMkFitInitialStep. The workflow .7571 is being introduced to monitor this configuration.

A follow-up PR will extend this work to implement the proposed HLT Phase-2 baseline single-iteration tracking configuration (configuration 3) as presented at the HLT Upgrade meeting. The developments in this PR are independent and provide the necessary framework for ongoing mkFit-related HLT studies. The main results related to the hltInitialStep configuration have been presented in JIRA ticket CMSHLT-3613, and in this DP note, where the configuration was executed via customisers.

FYI @mmasciov @slava77 @VourMa

cmsbuild · 2025-10-28T09:39:12Z

cms-bot internal usage

cmsbuild · 2025-10-28T09:40:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49231/46574

cmsbuild · 2025-10-28T09:40:57Z

A new Pull Request was created by @bdanzi for master.

It involves the following packages:

Configuration/ProcessModifiers (operations)
Configuration/PyReleaseValidation (pdmv)
HLTrigger/Configuration (hlt)
RecoTracker/MkFit (reconstruction)

@AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @miquork, @mmusich, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @SohamBhattacharya, @VinInn, @VourMa, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmasciov, @mmusich, @mtosi, @rovere, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich

some graphics suggestions, just to keep the configuration tidier.

HLTrigger/Configuration/python/HLT_75e33/modules/hltInitialStepTrackCandidatesMkFit_cfi.py

HLTrigger/Configuration/python/HLT_75e33/modules/hltInitialStepTrackCandidates_cfi.py

HLTrigger/Configuration/python/HLT_75e33/modules/hltMkFitSiPhase2Hits_cfi.py

HLTrigger/Configuration/python/HLT_75e33/modules/hltMkFitSiPixelHits_cfi.py

HLTrigger/Configuration/python/HLT_75e33/modules/hltMkFitSiStripHits_cfi.py

mmusich · 2025-10-28T10:05:07Z

test parameters:

enable = gpu, hlt_p2_integration, hlt_p2_timing
workflows = ph2_hlt

mmusich · 2025-10-28T10:26:43Z

The PR also fixes an inconsistency in the workflow numbering between runTheMatrix.py and upgradeWorkflowComponents.py, where the offset value did not match the corresponding workflow ID.

just to be clear, the inconsistency is just in the comment, no?

bdanzi · 2025-10-28T10:44:27Z

The PR also fixes an inconsistency in the workflow numbering between runTheMatrix.py and upgradeWorkflowComponents.py, where the offset value did not match the corresponding workflow ID.

just to be clear, the inconsistency is just in the comment, no?

yes, added in the PR description

mmusich · 2025-10-28T10:52:11Z

please test

cmsbuild · 2025-10-28T18:18:43Z

+1

Size: This PR adds an extra 108KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0043/48854/summary.html
COMMIT: e1515b3
CMSSW: CMSSW_16_0_X_2025-10-27-2300/el8_amd64_gcc13
Additional Tests: GPU,HLT_P2_INTEGRATION,HLT_P2_TIMING,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49231/48854/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@stahlleiton Reduce size of dEdx estimators in PbPb MiniAOD #49218

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0043/48854/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0043/48854/git-merge-result

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 66
DQMHistoTests: Total histograms compared: 4526074
DQMHistoTests: Total failures: 18
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4526036
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 65 files compared)
Checked 271 log files, 233 edm output root files, 66 DQM output files
TriggerResults: found differences in 2 / 64 workflows

AMD_MI300X Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 215 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 147869
DQMHistoTests: Total failures: 31730
DQMHistoTests: Total nulls: 7
DQMHistoTests: Total successes: 116132
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: found differences in 1 / 10 workflows

AMD_W7900 Comparison Summary

Summary:

You potentially removed 7 lines from the logs
Reco comparison results: 224 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 147869
DQMHistoTests: Total failures: 33095
DQMHistoTests: Total nulls: 7
DQMHistoTests: Total successes: 114767
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 230 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 147869
DQMHistoTests: Total failures: 24751
DQMHistoTests: Total nulls: 11
DQMHistoTests: Total successes: 123107
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

You potentially added 22 lines to the logs
Reco comparison results: 214 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 147869
DQMHistoTests: Total failures: 33433
DQMHistoTests: Total nulls: 8
DQMHistoTests: Total successes: 114428
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: found differences in 2 / 10 workflows

NVIDIA_T4 Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 248 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 147869
DQMHistoTests: Total failures: 24102
DQMHistoTests: Total nulls: 7
DQMHistoTests: Total successes: 123760
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 42 log files, 45 edm output root files, 11 DQM output files
TriggerResults: found differences in 2 / 10 workflows

mmusich · 2025-10-31T09:40:07Z

strictly speaking nothing of the added code here would run on GPU, so let's test without the GPU matrix.

mmusich · 2025-10-31T09:40:40Z

test parameters:

enable = hlt_p2_integration, hlt_p2_timing
workflows = ph2_hlt

mmusich · 2025-10-31T09:40:48Z

@cmsbuild, please test

cmsbuild · 2025-10-31T15:20:48Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0043/49120/summary.html
COMMIT: 7bfaef2
CMSSW: CMSSW_16_0_X_2025-10-30-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49231/49120/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 4614017
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4613976
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 280 log files, 239 edm output root files, 69 DQM output files
TriggerResults: no differences found

mmusich · 2025-10-31T15:26:59Z

+hlt

for bdanzi@7bfaef2
PR according to description and follow-up review

jfernan2 · 2025-10-31T18:06:49Z

+1

mmasciov · 2025-11-03T11:07:17Z

Just a ping, @cms-sw/pdmv-l2

AdrianoDee · 2025-11-03T12:08:07Z

+pdmv

cmsbuild · 2025-11-03T12:08:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-11-03T12:32:15Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Oct 28, 2025

cmsbuild added reconstruction-pending hlt-pending operations-pending pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending tracking labels Oct 28, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 28, 2025

bdanzi changed the title ~~[mkFit] procModifier for Phase-2 HLT tracking~~ [mkFit] procModifier for Phase-2 HLT tracking and track candidates selections Oct 28, 2025

mmusich reviewed Oct 28, 2025

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Oct 28, 2025

This was referenced Oct 28, 2025

[NGT] Extension of CA Pixel Tracking to Phase 2 Outer Tracker barrel #48921

Merged

MTD Geometry: Update ETL numbering scheme, add corresponding new geometry scenarios #49234

Merged

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Oct 28, 2025

cmsbuild added tests-started and removed tests-rejected labels Oct 31, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Oct 31, 2025

cmsbuild added hlt-approved and removed hlt-pending labels Oct 31, 2025

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 31, 2025

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Nov 3, 2025

cmsbuild added orp-approved and removed orp-pending labels Nov 3, 2025

cmsbuild merged commit a66e723 into cms-sw:master Nov 3, 2025
27 checks passed

This was referenced Nov 3, 2025

Use RNTupleTemp* modules #49299

Merged

Update ROCm to version 7.0.2 cms-sw/cmsdist#10106

Merged

mmasciov mentioned this pull request Nov 13, 2025

Update mkFit-related processModifier for LST-seeded phase-2 HLT single tracking iteration #49383

Merged

[mkFit] procModifier for Phase-2 HLT tracking and track candidates selections #49231

[mkFit] procModifier for Phase-2 HLT tracking and track candidates selections #49231

Uh oh!

Conversation

bdanzi commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

Uh oh!

cmsbuild commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 28, 2025

Uh oh!

cmsbuild commented Oct 28, 2025

Uh oh!

mmusich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmusich commented Oct 28, 2025

Uh oh!

mmusich commented Oct 28, 2025

Uh oh!

bdanzi commented Oct 28, 2025

Uh oh!

mmusich commented Oct 28, 2025

Uh oh!

cmsbuild commented Oct 28, 2025

Comparison Summary

AMD_MI300X Comparison Summary

AMD_W7900 Comparison Summary

NVIDIA_H100 Comparison Summary

NVIDIA_L40S Comparison Summary

NVIDIA_T4 Comparison Summary

Uh oh!

mmusich commented Oct 31, 2025

Uh oh!

mmusich commented Oct 31, 2025

Uh oh!

mmusich commented Oct 31, 2025

Uh oh!

cmsbuild commented Oct 31, 2025

Comparison Summary

Uh oh!

mmusich commented Oct 31, 2025

Uh oh!

jfernan2 commented Oct 31, 2025

Uh oh!

mmasciov commented Nov 3, 2025

Uh oh!

AdrianoDee commented Nov 3, 2025

Uh oh!

cmsbuild commented Nov 3, 2025

Uh oh!

mandrenguyen commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

bdanzi commented Oct 28, 2025 •

edited

Loading

cmsbuild commented Oct 28, 2025 •

edited

Loading