[RECONSTRUCTION] Fix for virtual method inside a final class #49212

smuzaffar · 2025-10-24T15:04:18Z

LLVM21 has a new warning virtual method inside a final class and can never be overridden. This PR is to fix these warning. If these methods should remain virtual then may be we can then remove the final keyword for the class.

See #49208

cmsbuild · 2025-10-24T15:04:44Z

cms-bot internal usage

cmsbuild · 2025-10-24T15:06:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49212/46542

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/TkNavigation/plugins/NavigationSchoolESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2025-10-24T15:07:00Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

DataFormats/TrackerRecHit2D (reconstruction)
EventFilter/SiStripRawToDigi (reconstruction)
RecoMuon/TransientTrackingRecHit (reconstruction)
RecoTracker/CkfPattern (reconstruction)
RecoTracker/TkDetLayers (reconstruction)
RecoTracker/TkNavigation (reconstruction)
RecoTracker/TrackProducer (reconstruction)
RecoTracker/TransientTrackingRecHit (reconstruction)
RecoVertex/KinematicFitPrimitives (reconstruction)
TrackingTools/GeomPropagators (reconstruction)
TrackingTools/GsfTracking (reconstruction)
TrackingTools/PatternTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @VinInn, @VourMa, @abbiendi, @bellan, @cericeci, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @fsimone91, @gpetruc, @jhgoh, @llunerti, @martinamalberti, @missirol, @mmasciov, @mmusich, @mtosi, @robervalwalsh, @rociovilar, @rovere, @trocino this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2025-10-24T15:21:58Z

please test

smuzaffar · 2025-10-24T15:22:32Z

please test for CMSSW_16_0_CLANG_X

cmsbuild · 2025-10-24T15:39:07Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c4e4c/48804/summary.html
COMMIT: 5ad8b65
CMSSW: CMSSW_16_0_CLANG_X_2025-10-24-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49212/48804/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

cmsbuild · 2025-10-24T15:43:22Z

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c4e4c/48801/summary.html
COMMIT: 5ad8b65
CMSSW: CMSSW_16_0_X_2025-10-24-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49212/48801/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2025-10-27T11:15:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49212/46553

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/TkNavigation/plugins/NavigationSchoolESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2025-10-27T11:16:16Z

Pull request #49212 was updated. @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

smuzaffar · 2025-10-27T11:18:49Z

please test for CMSSW_16_0_CLANG_X

smuzaffar · 2025-10-27T11:43:55Z

please test

cmsbuild · 2025-10-27T15:26:56Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c4e4c/48830/summary.html
COMMIT: 5109bc3
CMSSW: CMSSW_16_0_X_2025-10-27-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49212/48830/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4172318
DQMHistoTests: Total failures: 61
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4172237
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 226 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-10-27T16:50:56Z

REMINDER @ftenchini, @sextonkennedy, @mandrenguyen: This PR was tested with #49211, please check if they should be merged together

jfernan2 · 2025-10-27T18:18:34Z

+1

cmsbuild · 2025-10-27T18:18:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2025-10-27T18:30:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c4e4c/48828/summary.html
COMMIT: 5109bc3
CMSSW: CMSSW_16_0_CLANG_X_2025-10-26-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49212/48828/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 200 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 99262 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4172318
DQMHistoTests: Total failures: 469422
DQMHistoTests: Total nulls: 324
DQMHistoTests: Total successes: 3702552
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.8600000000000003 KiB( 52 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.075 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -2.970 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 17034.0 ): 4.203 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 2024.0010001 ): 0.020 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.650 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -3.688 KiB SiStrip/MechanicalView
Checked 226 log files, 198 edm output root files, 53 DQM output files
TriggerResults: found differences in 16 / 51 workflows

ftenchini · 2025-10-28T10:43:58Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Oct 24, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending tracking trk labels Oct 24, 2025

smuzaffar mentioned this pull request Oct 24, 2025

llvm21: virtual method inside a final class and can never be overridden #49208

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 24, 2025

cmsbuild added tests-started and removed tests-pending labels Oct 24, 2025

cmsbuild added tests-rejected and removed tests-started labels Oct 24, 2025

[RECONSTRUCTION] Fix for virtual method inside a final class

5109bc3

smuzaffar force-pushed the reconstruction-llvm21-virtual-method-final-class branch from 5ad8b65 to 5109bc3 Compare October 27, 2025 11:13

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Oct 27, 2025

cmsbuild removed the code-checks-pending label Oct 27, 2025

cmsbuild added the code-checks-approved label Oct 27, 2025

cmsbuild added tests-started and removed tests-pending labels Oct 27, 2025

smuzaffar mentioned this pull request Oct 27, 2025

[SIMULATION] To virtual method inside a final class; make classes non-final #49211

Merged

iarspider mentioned this pull request Oct 27, 2025

[test_process_pr] Fill in missing repo name in test command iarspider-cmssw/cmssw#46

Open

cmsbuild added tests-approved and removed tests-started labels Oct 27, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Oct 27, 2025

cmsbuild added orp-approved and removed orp-pending labels Oct 28, 2025

cmsbuild merged commit b1eebbd into cms-sw:master Oct 28, 2025
16 checks passed

[RECONSTRUCTION] Fix for virtual method inside a final class #49212

[RECONSTRUCTION] Fix for virtual method inside a final class #49212

Uh oh!

Conversation

smuzaffar commented Oct 24, 2025

Uh oh!

cmsbuild commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 24, 2025

Uh oh!

cmsbuild commented Oct 24, 2025

Uh oh!

smuzaffar commented Oct 24, 2025

Uh oh!

smuzaffar commented Oct 24, 2025

Uh oh!

cmsbuild commented Oct 24, 2025

Build

Uh oh!

cmsbuild commented Oct 24, 2025

Clang Build

Uh oh!

cmsbuild commented Oct 27, 2025

Uh oh!

cmsbuild commented Oct 27, 2025

Uh oh!

smuzaffar commented Oct 27, 2025

Uh oh!

smuzaffar commented Oct 27, 2025

Uh oh!

cmsbuild commented Oct 27, 2025

Comparison Summary

Uh oh!

cmsbuild commented Oct 27, 2025

Uh oh!

jfernan2 commented Oct 27, 2025

Uh oh!

cmsbuild commented Oct 27, 2025

Uh oh!

cmsbuild commented Oct 27, 2025

Comparison Summary

Uh oh!

ftenchini commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Oct 24, 2025 •

edited

Loading