Skip to content

Conversation

@Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Oct 9, 2025

PR description:

  • moved to new header '"catch2/catch_all.hpp"'
  • moved to new listener API
  • moved away from Approx as it was removed in v3
  • moved Matchers to their new namespace

PR validation:

  • this builds with the version of catch2 v3 that I built and then redirected scram to use.

resolves #49109
resolves cms-sw/framework-team#1607

@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Oct 9, 2025
@Dr15Jones
Copy link
Contributor Author

hold

this can't be built without the corresponding change to the catch2 tool

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49121/46393

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • Alignment/HIPAlignmentAlgorithm (alca)
  • Alignment/OfflineValidation (alca)
  • CUDADataFormats/Common (heterogeneous)
  • CalibFormats/SiStripObjects (alca)
  • CalibTracker/SiPixelESProducers (alca)
  • CommonTools/BaseParticlePropagator (fastsim, reconstruction)
  • CondCore/CondHDF5ESSource (db)
  • CondFormats/EcalObjects (alca, db)
  • CondFormats/SerializationHelper (db)
  • CondFormats/SiStripObjects (alca, db)
  • DQM/BeamMonitor (db, dqm)
  • DQM/EcalCommon (dqm)
  • DQM/TrackerRemapper (dqm)
  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Trigger (dqm)
  • DataFormats/Common (core)
  • DataFormats/HGCalReco (reconstruction, upgrade)
  • DataFormats/Histograms (core, dqm)
  • DataFormats/L1TGlobal (l1)
  • DataFormats/ParticleFlowReco (reconstruction)
  • DataFormats/Portable (heterogeneous)
  • DataFormats/Provenance (core)
  • DataFormats/SoATemplate (heterogeneous)
  • FWCore/Catalog (core)
  • FWCore/Common (core)
  • FWCore/Concurrency (core)
  • FWCore/Framework (core)
  • FWCore/Integration (core)
  • FWCore/Modules (core)
  • FWCore/ParameterSet (core)
  • FWCore/Services (core)
  • FWCore/SharedMemory (core)
  • FWCore/Utilities (core)
  • GeneratorInterface/LHEInterface (generators)
  • GeneratorInterface/Pythia8Interface (generators)
  • Geometry/CaloGeometry (geometry)
  • HLTrigger/HLTcore (hlt)
  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • HeterogeneousCore/AlpakaMath (heterogeneous)
  • HeterogeneousCore/CUDACore (heterogeneous)
  • HeterogeneousCore/CUDAServices (heterogeneous)
  • HeterogeneousCore/CUDATest (heterogeneous)
  • HeterogeneousCore/CUDAUtilities (heterogeneous)
  • HeterogeneousCore/ROCmServices (heterogeneous)
  • HeterogeneousCore/ROCmUtilities (heterogeneous)
  • HeterogeneousTest/AlpakaDevice (heterogeneous)
  • HeterogeneousTest/AlpakaKernel (heterogeneous)
  • HeterogeneousTest/AlpakaOpaque (heterogeneous)
  • HeterogeneousTest/AlpakaWrapper (heterogeneous)
  • HeterogeneousTest/CUDADevice (heterogeneous)
  • HeterogeneousTest/CUDAKernel (heterogeneous)
  • HeterogeneousTest/CUDAOpaque (heterogeneous)
  • HeterogeneousTest/CUDAWrapper (heterogeneous)
  • HeterogeneousTest/ROCmDevice (heterogeneous)
  • HeterogeneousTest/ROCmKernel (heterogeneous)
  • HeterogeneousTest/ROCmOpaque (heterogeneous)
  • HeterogeneousTest/ROCmWrapper (heterogeneous)
  • IOPool/Common (core)
  • L1Trigger/GlobalMuonTrigger (l1)
  • PerfTools/AllocMonitor (core)
  • PhysicsTools/NanoAOD (xpog)
  • RecoEgamma/PhotonIdentification (reconstruction)
  • RecoLocalCalo/HGCalRecProducers (reconstruction, upgrade)
  • RecoParticleFlow/PFTracking (reconstruction)
  • RecoTracker/PixelTrackFitting (reconstruction)
  • RecoTracker/TkSeedingLayers (reconstruction)
  • RecoVertex/BeamSpotProducer (alca, reconstruction)
  • SimG4CMS/Calo (simulation)
  • SimG4Core/Application (simulation)

@BenjaminRS, @Dr15Jones, @Martin-Grunewald, @Moanwar, @arunhep, @atpathak, @battibass, @bsunanda, @civanch, @cmsbuild, @ctarricone, @francescobrivio, @ftorrresd, @fwyzard, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @nothingface0, @perrotta, @quinnanm, @rseidita, @sensrcn, @smuzaffar, @srimanob, @ssekmen, @subirsarkar, @theofil can you please review it and eventually sign? Thanks.
@Fedespring, @GiacomoSguazzoni, @HuguesBrun, @JanChyczynski, @Martin-Grunewald, @PonIlya, @Prasant1993, @ReyerBand, @Sam-Harper, @VinInn, @VourMa, @a-kapoor, @afiqaize, @alberto-sanchez, @apsallid, @argiro, @arossi83, @bsunanda, @cericeci, @cseez, @denizsun, @dgulhan, @dkotlins, @edjtscott, @elusian, @erikbutz, @fabiocos, @felicepantaleo, @ferencek, @fioriNTU, @francescobrivio, @fwyzard, @gpetruc, @hatakeyamak, @idebruyn, @jainshilpi, @jandrea, @jhgoh, @lecriste, @lgray, @makortel, @martinamalberti, @missirol, @mkirsano, @mmarionncern, @mmasciov, @mmusich, @mroguljic, @mtosi, @pfs, @ram1123, @rchatter, @richa2710, @rociovilar, @rovere, @rsreds, @salimcerci, @sameasy, @sbein, @seemasharmafnal, @sethzenz, @slomeo, @sobhatta, @sroychow, @thomreis, @threus, @tlampen, @tocheng, @trocino, @tsusa, @tvami, @valsdav, @vandreev11, @varuns23, @wang0jin, @wddgit, @youyingli, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Oct 9, 2025

+1

preemptive

@battibass
Copy link

+1

@lviliani
Copy link
Contributor

+generators

@jfernan2
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

smuzaffar commented Oct 13, 2025

@cms-sw/orp-l2 , this should be merged along with cms-sw/cmsdist#10119 and merging should be done just before 23h IB e.g. at 22h55 so that we minimize the failure of other cmssw PRs which might pick up this cmssw change

@cmsbuild
Copy link
Contributor

REMINDER @ftenchini, @mandrenguyen, @sextonkennedy: This PR was tested with cms-sw/cmsdist#10119, please check if they should be merged together

@BenjaminRS
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#10119

@Dr15Jones
Copy link
Contributor Author

@cms-sw/orp-l2 what is the plan for merging this as the previous window suggested by @smuzaffar was missed?

@smuzaffar
Copy link
Contributor

now that this PR is fully signed, may be we can try to get this in tonight's 23h00 IB

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 631c4b2 into cms-sw:master Oct 14, 2025
10 checks passed
iarspider added a commit to iarspider/cmssw that referenced this pull request Oct 15, 2025
cmsbuild added a commit that referenced this pull request Oct 15, 2025
Migrate skeletons to catch2 v3 (follow-up on #49121)
@Dr15Jones Dr15Jones deleted the catch2_v3 branch October 20, 2025 10:20
ghyls pushed a commit to ghyls/cmssw that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment