-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Moved catch2 tests to the v3 API #49121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hold this can't be built without the corresponding change to the |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49121/46393
|
|
Pull request has been put on hold by @Dr15Jones |
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@BenjaminRS, @Dr15Jones, @Martin-Grunewald, @Moanwar, @arunhep, @atpathak, @battibass, @bsunanda, @civanch, @cmsbuild, @ctarricone, @francescobrivio, @ftorrresd, @fwyzard, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @nothingface0, @perrotta, @quinnanm, @rseidita, @sensrcn, @smuzaffar, @srimanob, @ssekmen, @subirsarkar, @theofil can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 preemptive |
|
+1 |
|
+generators |
|
+1 |
|
@cms-sw/orp-l2 , this should be merged along with cms-sw/cmsdist#10119 and merging should be done just before 23h IB e.g. at 22h55 so that we minimize the failure of other cmssw PRs which might pick up this cmssw change |
|
REMINDER @ftenchini, @mandrenguyen, @sextonkennedy: This PR was tested with cms-sw/cmsdist#10119, please check if they should be merged together |
|
+l1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
@cms-sw/orp-l2 what is the plan for merging this as the previous window suggested by @smuzaffar was missed? |
|
now that this PR is fully signed, may be we can try to get this in tonight's 23h00 IB |
|
+1 |
Migrate skeletons to catch2 v3 (follow-up on #49121)
PR description:
Approxas it was removed in v3Matchersto their new namespacePR validation:
resolves #49109
resolves cms-sw/framework-team#1607