Skip to content

Conversation

@ferencek
Copy link
Contributor

@ferencek ferencek commented Oct 6, 2025

PR description:

Backport of #49065 to CMSSW_15_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

A new Pull Request was created by @ferencek for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/Eras (operations)

@cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2025

backport of #49065

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2025

@cmsbuild, please test

@vlimant
Copy link
Contributor

vlimant commented Oct 6, 2025

assign ppd

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

New categories assigned: ppd

@abenecke,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

@vlimant
Copy link
Contributor

vlimant commented Oct 6, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdbd47/48483/summary.html
COMMIT: 8d679e9
CMSSW: CMSSW_15_0_X_2025-10-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49067/48483/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beampixel_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

Pull request #49067 was updated. @abenecke, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @mandrenguyen, @nothingface0, @rseidita, @vlimant can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdbd47/48493/summary.html
COMMIT: 9e47c19
CMSSW: CMSSW_15_0_X_2025-10-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49067/48493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2656 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4031982
  • DQMHistoTests: Total failures: 5534
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4026428
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@ftenchini
Copy link

urgent

@cmsbuild cmsbuild added the urgent label Oct 6, 2025
@vlimant
Copy link
Contributor

vlimant commented Oct 7, 2025

+1

@mandrenguyen
Copy link
Contributor

+1
@cms-sw/dqm-l2 Please have a look

@nothingface0
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 6478d1d into cms-sw:CMSSW_15_0_X Oct 7, 2025
8 checks passed
@mmusich
Copy link
Contributor

mmusich commented Oct 7, 2025

Rushed checks of histo comparison probably OK

see #49065 (comment)

@ferencek ferencek deleted the SiPixelDigiMorphing_enabledFrom2025-15_0_X branch October 7, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants