Skip to content

Conversation

@ferencek
Copy link
Contributor

@ferencek ferencek commented Oct 6, 2025

PR description:

Backport of #49065 to CMSSW_15_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

A new Pull Request was created by @ferencek for CMSSW_15_1_X.

It involves the following packages:

  • Configuration/Eras (operations)

@cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2025

backport of #49065

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2025

@cmsbuild, please test

@mandrenguyen
Copy link
Contributor

backport of #49065

@nothingface0
Copy link
Contributor

Question: why isn't this modifying the DQM modules like the PR to master is? Is it not meant to go into production until next year?

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2025

Question: why isn't this modifying the DQM modules like the PR to master is? Is it not meant to go into production until next year?

I guess the commit was just not yet backported :D

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92e553/48482/summary.html
COMMIT: 25c2297
CMSSW: CMSSW_15_1_X_2025-10-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49066/48482/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMOnlineClient-beampixel_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2549 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 978
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123049
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@ferencek
Copy link
Contributor Author

ferencek commented Oct 6, 2025

Question: why isn't this modifying the DQM modules like the PR to master is? Is it not meant to go into production until next year?

I guess the commit was just not yet backported :D

Indeed. The fix was just made and I first want to be sure that it works. If it does, it will be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

Pull request #49066 was updated. @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @mandrenguyen, @nothingface0, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92e553/48492/summary.html
COMMIT: 1718761
CMSSW: CMSSW_15_1_X_2025-10-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49066/48492/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2560 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 982
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123045
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@nothingface0
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Oct 7, 2025

Rushed checks of histo comparison probably OK

see #49065 (comment)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 86be732 into cms-sw:CMSSW_15_1_X Oct 7, 2025
8 checks passed
@ferencek ferencek deleted the SiPixelDigiMorphing_enabledFrom2025-15_1_X branch October 7, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants