Remove unused DetSetVector test in FWCore/Integration #48902

Dr15Jones · 2025-09-11T19:01:41Z

PR description:

The test code has never been run automatically. These test do not do anything unique so are not necessary.

PR validation:

Code compiles.

resolves cms-sw/framework-team#1576

The test code has never been run automatically. These test do not do anything unique so are not necessary.

cmsbuild · 2025-09-11T19:02:07Z

cms-bot internal usage

Dr15Jones · 2025-09-11T19:02:39Z

please test

cmsbuild · 2025-09-11T19:03:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48902/46064

There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/test/stubs/ToyAnalyzers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Framework/test/stubs/ToyModules.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2025-09-11T19:04:12Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

FWCore/Framework (core)
FWCore/Integration (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-09-11T19:59:11Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70db5b/48071/summary.html
COMMIT: e4b542f
CMSSW: CMSSW_16_0_X_2025-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

29634.75

----- Begin Fatal Exception 11-Sep-2025 21:40:18 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/met/l1met_ptphi2pxpy_poly2_v1.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29634.75_TTbar_14TeV+Run4D110_HLT75e33Timing


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1170): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1394): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

29834.999

----- Begin Fatal Exception 11-Sep-2025 21:45:00 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_DIGI_DATAMIX_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/met/l1met_ptphi2pxpy_poly2_v1.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29834.999_TTbar_14TeV+Run4D110PU_PMXS1S2PR


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1170): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1394): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

24834.911

----- Begin Fatal Exception 11-Sep-2025 21:44:12 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/met/l1met_ptphi2pxpy_poly2_v1.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48071/CMSSW_16_0_X_2025-09-11-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-11-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24834.911_TTbar_14TeV+Run4D98_DD4hep


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1170): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1394): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

makortel · 2025-09-11T20:08:43Z

The errors are related to #48897

Dr15Jones · 2025-09-12T15:09:07Z

please test

cmsbuild · 2025-09-12T16:57:50Z

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70db5b/48089/summary.html
COMMIT: e4b542f
CMSSW: CMSSW_16_0_X_2025-09-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48902/48089/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4113751
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4113710
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

makortel · 2025-09-12T19:21:25Z

Comparison differences are related to #47071

makortel · 2025-09-12T19:21:27Z

+core

cmsbuild · 2025-09-12T19:21:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-09-12T20:25:25Z

+1

Remove unused DetSetVector test in FWCore/Integration

e4b542f

The test code has never been run automatically. These test do not do anything unique so are not necessary.

cmsbuild added this to the CMSSW_16_0_X milestone Sep 11, 2025

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 11, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 11, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 11, 2025

cmsbuild added tests-rejected and removed tests-started labels Sep 11, 2025

cmsbuild added tests-started and removed tests-rejected labels Sep 12, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 12, 2025

cmsbuild added core-approved and removed core-pending pending-signatures labels Sep 12, 2025

cmsbuild added the fully-signed label Sep 12, 2025

cmsbuild added orp-approved and removed orp-pending labels Sep 12, 2025

cmsbuild merged commit 8226edd into cms-sw:master Sep 12, 2025
10 checks passed

Dr15Jones deleted the removeDSVunusedTests branch September 12, 2025 20:36

Remove unused DetSetVector test in FWCore/Integration #48902

Remove unused DetSetVector test in FWCore/Integration #48902

Uh oh!

Conversation

Dr15Jones commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr15Jones commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

RelVals

Uh oh!

makortel commented Sep 11, 2025

Uh oh!

Dr15Jones commented Sep 12, 2025

Uh oh!

cmsbuild commented Sep 12, 2025

Comparison Summary

Uh oh!

makortel commented Sep 12, 2025

Uh oh!

makortel commented Sep 12, 2025

Uh oh!

cmsbuild commented Sep 12, 2025

Uh oh!

mandrenguyen commented Sep 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dr15Jones commented Sep 11, 2025 •

edited

Loading

cmsbuild commented Sep 11, 2025 •

edited

Loading