Skip to content

Conversation

@slava77
Copy link
Contributor

@slava77 slava77 commented Aug 8, 2025

new MC_TRK path with tracking sequence only in phase-2 HLT, is going to be available as a 75e33_trackingOnly table and as @relvalRun4_trk in autoHLT.
A reference workflow is .7501

@VourMa @cms-sw/tracking-pog-l2

Edit (post-submission): the topic branch name is a misnomer, it's not 15.1.0.pre4 anymore, since I had to rebase

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48706/45743

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

A new Pull Request was created by @slava77 for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • HLTrigger/Configuration (hlt)

@AdrianoDee, @Martin-Grunewald, @Moanwar, @cmsbuild, @DickyChant, @miquork, @mmusich, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @fabiocos, @makortel, @missirol, @mmusich, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Aug 8, 2025

@slava77 please add an entry here:

'relvalRun4' : '75e33',
'relvalRun4_timing' : '75e33_timing',
'relvalRun4_scouting' : 'NGTScouting',

such that we can run integration tests over the new menu.

@slava77
Copy link
Contributor Author

slava77 commented Aug 8, 2025

@slava77 please add an entry here:

'relvalRun4' : '75e33',
'relvalRun4_timing' : '75e33_timing',
'relvalRun4_scouting' : 'NGTScouting',

such that we can run integration tests over the new menu.

ah, this is a new feature from a few days ago.
I thought I could get away without a rebase.

should I add a plain relvalRun4_trackingOnly or smth more compact like relvalRun4_trk ?

@mmusich
Copy link
Contributor

mmusich commented Aug 8, 2025

should I add a plain relvalRun4_trackingOnly or smth more compact like relvalRun4_trk ?

I don't have strong preferences. relvalRun4_trk sounds OK to me.

@slava77 slava77 force-pushed the CMSSW_15_1_0_pre4/lst010-HLT_trackingOnly branch from 62fa9ae to 162b643 Compare August 8, 2025 17:07
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48706/45744

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

Pull request #48706 was updated. @AdrianoDee, @Martin-Grunewald, @Moanwar, @cmsbuild, @DickyChant, @miquork, @mmusich, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Aug 8, 2025

test parameters:

  • enable = hlt_p2_integration
  • relvals_opt = --what upgrade
  • workflows = 29753.7501

@mmusich
Copy link
Contributor

mmusich commented Aug 8, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

-1

Failed Tests: UnitTests RelVals RelVals-INPUT HLTP2Integration
Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87afd1/47622/summary.html
COMMIT: 162b643
CMSSW: CMSSW_15_1_X_2025-08-08-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48706/47622/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_check_phase2_hlt_duplicates had ERRORS

RelVals

ValueError: Undefined workflows: 29753.7501

  • 29834.99929834.999_TTbar_14TeV+Run4D110PU_PMXS1S2PR/step3_TTbar_14TeV+Run4D110PU_PMXS1S2PR.log
  • 24834.91124834.911_TTbar_14TeV+Run4D98_DD4hep/step2_TTbar_14TeV+Run4D98_DD4hep.log
  • 29700.029700.0_CloseByPGun_CE_H_Coarse_Scint+Run4D110/step2_CloseByPGun_CE_H_Coarse_Scint+Run4D110.log
Expand to see more relval errors ...

RelVals-INPUT

  • 136.897136.897_RunCosmics2021CRUZET/step2_RunCosmics2021CRUZET.log

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87afd1/47694/summary.html
COMMIT: 2cec6f9
CMSSW: CMSSW_15_1_X_2025-08-12-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48706/47694/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 61
  • DQMHistoTests: Total histograms compared: 4381146
  • DQMHistoTests: Total failures: 92
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4381034
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 60 files compared)
  • Checked 254 log files, 215 edm output root files, 61 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Aug 12, 2025

I am ready to sign for hlt, I am just waiting for a resolution of #48706 (comment)

@mmusich
Copy link
Contributor

mmusich commented Aug 13, 2025

+hlt

@slava77
Copy link
Contributor Author

slava77 commented Aug 13, 2025

@cms-sw/tracking-pog-l2
I wanted to ask if just the tracking sequence is enough for MC_TRK:
where does the PV reco belong?

Currently the full vertexing enters as HLTVertexRecoSequence only via the HLTParticleFlowSequence.
This, however, depends on the calorimeter in the vertex sorting depending on calojets.

One option is to to keep hltUnsortedOfflinePrimaryVertices and hltFirstStepPrimaryVerticesUnsorted, which are tracking-specific (instances of PrimaryVertexProducer).
Since things are not particularly obvious and incremental wrt this PR, it seems like a topic for a follow up PR.

@slava77
Copy link
Contributor Author

slava77 commented Aug 15, 2025

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 your signatures are needed for this PR.
Please take a look. Thank you.

@Moanwar
Copy link
Contributor

Moanwar commented Aug 16, 2025

+Upgrade

@mmusich
Copy link
Contributor

mmusich commented Aug 18, 2025

@cms-sw/pdmv-l2 kind ping.

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants