Skip to content

Run 3 FastSim refinement for PUPPI jets #48587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+113 −8
Open

Run 3 FastSim refinement for PUPPI jets #48587

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bbff503
added mask to the refined jets to coincide with training cuts
sbein Jul 29, 2025
ac2d505
cleaned up a few lines
sbein Jul 29, 2025
1784c8f
making FastSim refinement default for Run 2 CHS jets should this ever…
Aug 2, 2025
98db2ef
updated onnx file name
sbein Aug 9, 2025
99542da
updated file name to match cms-data
sbein Aug 11, 2025
05acf83
updated weight file name after removing data file from history
sbein Nov 4, 2025
cb7069a
Fix refinement module by rebinding refined variables as userFloats to…
sbein Nov 8, 2025
564a992
implemented mask that sets occasional unrefined values as the default…
sbein Nov 10, 2025
2fc61b1
introduced max(x,-1) function in lieu of ?x>0?x:-1, which restores th…
sbein Nov 10, 2025
838fe01
updated warning comment to make it more chill
sbein Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 90 additions & 6 deletions PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,96 @@ def nanoAOD_addDeepInfoAK4(process,addParticleNet,addRobustParTAK4=False,addUnif
jetPuppiTable.variables.muonSubtrDeltaPhi = Var("userFloat('muonSubtrRawPhi') - phi()",float,doc="muon-subtracted raw phi - phi",precision=10)

jetPuppiForMETTask = cms.Task(basicJetsPuppiForMetForT1METNano,corrT1METJetPuppiTable)

#before cross linking
jetPuppiUserDataTask = cms.Task(hfJetPuppiShowerShapeforNanoAOD)

#before cross linking
jetPuppiTask = cms.Task(jetPuppiCorrFactorsNano,updatedJetsPuppi,jetPuppiUserDataTask,updatedJetsPuppiWithUserData,finalJetsPuppi)

#after cross linkining
jetPuppiTablesTask = cms.Task(jetPuppiTable)

from Configuration.Eras.Modifier_fastSim_cff import fastSim
from PhysicsTools.NanoAOD.common_cff import ExtVar

def nanoAOD_refineFastSim_puppiJet(process):
process.puppiJetRefineNN = cms.EDProducer(
"JetBaseMVAValueMapProducer",
backend = cms.string("ONNX"),
batch_eval = cms.bool(True),
disableONNXGraphOpt = cms.bool(True),
src = cms.InputTag("updatedJetsPuppi"), # <<< HERE
weightFile = cms.FileInPath("PhysicsTools/NanoAOD/data/model_fastsimrefine_puppi_31July2025.onnx"),
Copy link
Contributor

@kpedro88 kpedro88 Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the filename in cms-data/PhysicsTools-NanoAOD#20 is fastSimPuppiJetRefineNN_31July2025.onnx, which is not the same as the filename listed here.

Copy link
Contributor Author

@sbein sbein Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silly. Didn't catch it because the dev release was deprecated and I couldn't test. should be fine now.

name = cms.string("puppiJetRefineNN"),
variables = cms.VPSet(
cms.PSet(name=cms.string("GenJet_pt"), expr=cms.string("?genJetFwdRef().backRef().isNonnull()?genJetFwdRef().backRef().pt():pt")),
cms.PSet(name=cms.string("GenJet_eta"), expr=cms.string("?genJetFwdRef().backRef().isNonnull()?genJetFwdRef().backRef().eta():eta")),
cms.PSet(name=cms.string("Jet_hadronFlavour"), expr=cms.string("hadronFlavour()")),
cms.PSet(name=cms.string("Jet_pt"), expr=cms.string("pt()")),
cms.PSet(name=cms.string("Jet_btagDeepFlavB"), expr=cms.string("bDiscriminator('pfDeepFlavourJetTags:probb')+bDiscriminator('pfDeepFlavourJetTags:probbb')+bDiscriminator('pfDeepFlavourJetTags:problepb')")),
cms.PSet(name=cms.string("Jet_btagDeepFlavCvB"), expr=cms.string("?(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probb')+bDiscriminator('pfDeepFlavourJetTags:probbb')+bDiscriminator('pfDeepFlavourJetTags:problepb'))>0?bDiscriminator('pfDeepFlavourJetTags:probc')/(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probb')+bDiscriminator('pfDeepFlavourJetTags:probbb')+bDiscriminator('pfDeepFlavourJetTags:problepb')):-1")),
cms.PSet(name=cms.string("Jet_btagDeepFlavCvL"), expr=cms.string("?(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probuds')+bDiscriminator('pfDeepFlavourJetTags:probg'))>0?bDiscriminator('pfDeepFlavourJetTags:probc')/(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probuds')+bDiscriminator('pfDeepFlavourJetTags:probg')):-1")),
cms.PSet(name=cms.string("Jet_btagDeepFlavQG"), expr=cms.string("?(bDiscriminator('pfDeepFlavourJetTags:probg')+bDiscriminator('pfDeepFlavourJetTags:probuds'))>0?bDiscriminator('pfDeepFlavourJetTags:probg')/(bDiscriminator('pfDeepFlavourJetTags:probg')+bDiscriminator('pfDeepFlavourJetTags:probuds')):-1")),
cms.PSet(name=cms.string("Jet_btagUParTAK4B"), expr=cms.string("bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:BvsAll')")),
cms.PSet(name=cms.string("Jet_btagUParTAK4CvB"), expr=cms.string("?(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsB')>0)?bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsB'):-1")),
cms.PSet(name=cms.string("Jet_btagUParTAK4CvL"), expr=cms.string("?(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsL')>0)?bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsL'):-1")),
cms.PSet(name=cms.string("Jet_btagUParTAK4QvG"), expr=cms.string("?(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:QvsG')>0)?bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:QvsG'):-1")),
),
inputTensorName = cms.string("input"),
outputTensorName = cms.string("output"),
outputNames = cms.vstring([
"ptrefined","btagDeepFlavBrefined","btagDeepFlavCvBrefined","btagDeepFlavCvLrefined",
"btagDeepFlavQGrefined","btagUParTAK4Brefined","btagUParTAK4CvBrefined",
"btagUParTAK4CvLrefined","btagUParTAK4QvGrefined"
]),
outputFormulas = cms.vstring([f"at({i})" for i in range(9)]),
)

fastSim.toModify(process.jetPuppiTask, process.jetPuppiTask.add(process.puppiJetRefineNN))

# 1) now stuff the 9 refined scalars into the existing PATJetUserDataEmbedder
fastSim.toModify(process.updatedJetsPuppiWithUserData.userFloats,
ptRefined = cms.InputTag("puppiJetRefineNN","ptrefined"),
btagDeepFlavBrefined = cms.InputTag("puppiJetRefineNN","btagDeepFlavBrefined"),
btagDeepFlavCvBrefined = cms.InputTag("puppiJetRefineNN","btagDeepFlavCvBrefined"),
btagDeepFlavCvLrefined = cms.InputTag("puppiJetRefineNN","btagDeepFlavCvLrefined"),
btagDeepFlavQGrefined = cms.InputTag("puppiJetRefineNN","btagDeepFlavQGrefined"),
btagUParTAK4Brefined = cms.InputTag("puppiJetRefineNN","btagUParTAK4Brefined"),
btagUParTAK4CvBrefined = cms.InputTag("puppiJetRefineNN","btagUParTAK4CvBrefined"),
btagUParTAK4CvLrefined = cms.InputTag("puppiJetRefineNN","btagUParTAK4CvLrefined"),
btagUParTAK4QvGrefined = cms.InputTag("puppiJetRefineNN","btagUParTAK4QvGrefined"),
)

# 2) backup all 9 originals in the NanoAOD table as *_unrefined
fastSim.toModify(process.jetPuppiTable.variables,
pt_unrefined = process.jetPuppiTable.variables.pt.clone(),
btagDeepFlavB_unrefined = process.jetPuppiTable.variables.btagDeepFlavB.clone(),
btagDeepFlavCvB_unrefined = process.jetPuppiTable.variables.btagDeepFlavCvB.clone(),
btagDeepFlavCvL_unrefined = process.jetPuppiTable.variables.btagDeepFlavCvL.clone(),
btagDeepFlavQG_unrefined = process.jetPuppiTable.variables.btagDeepFlavQG.clone(),
btagUParTAK4B_unrefined = process.jetPuppiTable.variables.btagUParTAK4B.clone(),
btagUParTAK4CvB_unrefined = process.jetPuppiTable.variables.btagUParTAK4CvB.clone(),
btagUParTAK4CvL_unrefined = process.jetPuppiTable.variables.btagUParTAK4CvL.clone(),
btagUParTAK4QvG_unrefined = process.jetPuppiTable.variables.btagUParTAK4QvG.clone(),
)
# drop them so we can redefine
fastSim.toModify(process.jetPuppiTable.variables,
pt=None, btagDeepFlavB=None, btagDeepFlavCvB=None,
btagDeepFlavCvL=None, btagDeepFlavQG=None,
btagUParTAK4B=None, btagUParTAK4CvB=None,
btagUParTAK4CvL=None, btagUParTAK4QvG=None,
)

# 3) re‑define each branch with a FastSim‑only mask ternary
mask = "(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:BvsAll')>0)"

fastSim.toModify(process.jetPuppiTable.variables,
pt = Var(f"?{mask}?userFloat('ptRefined'):pt()", float, precision=10, doc="refined pT or original"),
btagDeepFlavB = Var(f"?{mask}?userFloat('btagDeepFlavBrefined'):(bDiscriminator('pfDeepFlavourJetTags:probb')+bDiscriminator('pfDeepFlavourJetTags:probbb')+bDiscriminator('pfDeepFlavourJetTags:problepb'))", float, precision=10),
btagDeepFlavCvB = Var(f"?{mask}?userFloat('btagDeepFlavCvBrefined'):(?(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probb')+bDiscriminator('pfDeepFlavourJetTags:probbb')+bDiscriminator('pfDeepFlavourJetTags:problepb'))>0?bDiscriminator('pfDeepFlavourJetTags:probc')/(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probb')+bDiscriminator('pfDeepFlavourJetTags:probbb')+bDiscriminator('pfDeepFlavourJetTags:problepb')):-1)", float, precision=10),
btagDeepFlavCvL = Var(f"?{mask}?userFloat('btagDeepFlavCvLrefined'):(?(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probuds')+bDiscriminator('pfDeepFlavourJetTags:probg'))>0?bDiscriminator('pfDeepFlavourJetTags:probc')/(bDiscriminator('pfDeepFlavourJetTags:probc')+bDiscriminator('pfDeepFlavourJetTags:probuds')+bDiscriminator('pfDeepFlavourJetTags:probg')):-1)", float, precision=10),
btagDeepFlavQG = Var(f"?{mask}?userFloat('btagDeepFlavQGrefined'):(?(bDiscriminator('pfDeepFlavourJetTags:probg')+bDiscriminator('pfDeepFlavourJetTags:probuds'))>0?bDiscriminator('pfDeepFlavourJetTags:probg')/(bDiscriminator('pfDeepFlavourJetTags:probg')+bDiscriminator('pfDeepFlavourJetTags:probuds')):-1)", float, precision=10),
btagUParTAK4B = Var(f"?{mask}?userFloat('btagUParTAK4Brefined'):(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:BvsAll'))", float, precision=10),
btagUParTAK4CvB = Var(f"?{mask}?userFloat('btagUParTAK4CvBrefined'):(?(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsB')>0)?bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsB'):-1)", float, precision=10),
btagUParTAK4CvL = Var(f"?{mask}?userFloat('btagUParTAK4CvLrefined'):(?(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsL')>0)?bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:CvsL'):-1)", float, precision=10),
btagUParTAK4QvG = Var(f"?{mask}?userFloat('btagUParTAK4QvGrefined'):(?(bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:QvsG')>0)?bDiscriminator('pfUnifiedParticleTransformerAK4DiscriminatorsJetTags:QvsG'):-1)", float, precision=10),
)

return process

nanoAOD_refineFastSim_puppiJet = nanoAOD_refineFastSim_puppiJet
6 changes: 4 additions & 2 deletions PhysicsTools/NanoAOD/python/nano_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,12 @@ def nanoAOD_customizeCommon(process):
nanoAOD_boostedTau_switch, idsToAdd=["boostedDeepTauRunIIv2p0"]
)
nanoAOD_addBoostedTauIds(process, nanoAOD_boostedTau_switch.idsToAdd.value())

# Add lepton time-life info

from PhysicsTools.NanoAOD.leptonTimeLifeInfo_common_cff import addTimeLifeInfoBase
process = addTimeLifeInfoBase(process)

process = nanoAOD_refineFastSim_puppiJet(process)
process = nanoAOD_refineFastSim_bTagDeepFlav(process)

return process

Expand Down