Skip to content

Conversation

@see-saw28
Copy link

PR description:

  • Remove EGM Scale and Smearing for Run2 reprocessing. The Scale and Smearing will be apply offline on the Ecal-Tracker combined energy (instead of the Ecal energy and redo the combination for electrons) as it is done in Run3.
  • Update EPcombination parameters used for combination when applying S&S on the Ecal energy. Not used anymore (see first bullet) but the wrong set of parameters was used.

PR validation:

Tested using #48176 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is backport of #48539 as is intended to be used for the Run2 reprocessing.

Paul Gaigne added 2 commits July 16, 2025 11:58
…n the reapplication of the scale and smearing in Mini and Nano)
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2025

A new Pull Request was created by @see-saw28 for CMSSW_15_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • RecoEgamma/EgammaTools (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @Sam-Harper, @a-kapoor, @afiqaize, @gpetruc, @jainshilpi, @lgray, @missirol, @ram1123, @sameasy, @sobhatta, @valsdav, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 16, 2025

cms-bot internal usage

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f812b0/47246/summary.html
COMMIT: c118e8c
CMSSW: CMSSW_15_0_X_2025-07-16-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48558/47246/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 125 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 370 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 88860
  • DQMHistoTests: Total failures: 513
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 88347
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 134 log files, 80 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul16v2 3.085 3.118 -0.034 ( -1.1% ) 3.56 3.90 -8.6% 2.257 2.616
2500.002_NANOmc106Xul17v2 3.144 3.177 -0.033 ( -1.0% ) 3.34 3.63 -8.2% 2.674 3.055
2500.003_NANOmc106Xul18v2 3.097 3.128 -0.031 ( -1.0% ) 3.39 3.68 -7.9% 2.699 3.059
2500.011_NANOdata106Xul16v2 1.539 1.560 -0.021 ( -1.3% ) 5.72 6.39 -10.4% 2.332 2.683
2500.012_NANOdata106Xul17v2 1.925 1.948 -0.023 ( -1.2% ) 3.88 4.27 -9.3% 2.449 2.860
2500.013_NANOdata106Xul18v2 1.890 1.914 -0.024 ( -1.3% ) 4.69 5.12 -8.4% 2.488 2.739
2500.021_NANOmcUL16APVreMINI 0.022 0.022 0.000 ( +0.0% ) 1.42 1.82 -21.9% 2.344 2.577
2500.022_NANOmcUL16reMINI 0.022 0.022 0.000 ( +0.0% ) 1.46 1.78 -18.1% 2.251 2.576
2500.023_NANOmcUL17reMINI 0.022 0.022 0.000 ( +0.0% ) 1.08 1.60 -32.1% 2.181 2.544
2500.024_NANOmcUL18reMINI 0.022 0.022 0.000 ( +0.0% ) 1.04 1.43 -27.0% 2.610 2.719
2500.031_NANOdataUL16APVreMINI 0.035 0.035 0.000 ( +0.0% ) 1.23 1.61 -23.3% 2.418 2.669
2500.032_NANOdataUL16reMINI 0.036 0.036 0.000 ( +0.0% ) 1.23 1.61 -23.8% 2.431 2.590
2500.033_NANOdataUL17reMINI 0.037 0.037 0.000 ( +0.1% ) 1.23 1.54 -20.5% 2.481 2.698
2500.034_NANOdataUL18reMINI 0.036 0.036 0.000 ( +0.0% ) 1.24 1.56 -20.3% 2.474 2.687
2500.101_NANOmc130X 3.220 3.220 0.000 ( +0.0% ) 4.06 4.45 -8.8% 2.502 3.066
2500.111_NANOdata130Xrun3 1.799 1.799 0.000 ( +0.0% ) 5.80 6.58 -11.8% 2.764 2.726
2500.131_ScoutingNANOdata130Xrun3 0.771 0.771 0.000 ( +0.0% ) 28.95 34.36 -15.8% 1.662 1.658
2500.221_muPOGNANOmc140X 2.065 2.065 0.000 ( +0.0% ) 4.85 5.74 -15.5% 2.234 2.089
2500.222_EGMNANOmc140X 3.876 3.876 0.000 ( +0.0% ) 3.46 4.08 -15.2% 2.603 2.380
2500.223_BTVNANOmc140X 10.607 10.607 0.000 ( +0.0% ) 2.26 2.60 -13.0% 2.810 2.533
2500.224_jmeNANOmc140X 6.666 6.666 0.000 ( +0.0% ) 1.02 1.17 -12.6% 2.667 2.405
2500.226_lepTrackInfoNANOmc140X 3.570 3.570 0.000 ( +0.0% ) 3.52 4.10 -14.2% 2.594 2.358
2500.227_ScoutingNANOmc140X 1.486 1.486 0.000 ( +0.0% ) 13.65 16.05 -15.0% 1.911 1.913
2500.228_ScoutingNANOwithPromptmc140X 4.474 4.474 0.000 ( +0.0% ) 3.25 3.45 -5.7% 2.904 2.639
2500.231_muPOGNANO140Xrun3 1.469 1.469 0.000 ( +0.0% ) 7.11 8.05 -11.7% 2.531 2.347
2500.232_EGMNANOdata140Xrun3 2.623 2.623 0.000 ( +0.0% ) 5.07 5.88 -13.7% 2.920 2.348
2500.233_BTVNANOdata140Xrun3 5.612 5.612 0.000 ( +0.0% ) 3.36 3.77 -10.9% 3.102 2.479
2500.234_jmeNANOdata140Xrun3 3.976 3.976 0.000 ( +0.0% ) 1.34 1.50 -11.1% 2.731 2.324
2500.236_lepTrackInfoNANOdata140Xrun3 2.413 2.413 0.000 ( +0.0% ) 5.19 5.91 -12.1% 2.898 2.292
2500.237_ScoutingNANOdata140Xrun3 1.101 1.101 0.000 ( +0.0% ) 26.75 29.90 -10.5% 1.648 1.313
2500.238_ScoutingNANOwithPromptdata140Xrun3 2.783 2.783 0.000 ( +0.0% ) 5.01 5.20 -3.6% 3.134 2.972
2500.241_l1DPGNANO140Xrun3 9.404 9.404 0.000 ( +0.0% ) 6.28 7.55 -16.8% 1.927 1.930
2500.242_muDPGNANO140Xrun3 10.331 10.331 0.000 ( +0.0% ) 1.52 1.72 -11.2% 1.725 1.729
2500.243_muDPGNANOBkg140Xrun3 2.712 2.712 0.000 ( +0.0% ) 13.54 16.21 -16.5% 1.058 1.065
2500.244_hcalDPGNANO140Xrun3 486.016 486.016 0.000 ( +0.0% ) 1.02 1.16 -11.5% 1.678 1.619
2500.245_hcalDPGCalibNANO140Xrun3 826.413 826.413 0.000 ( +0.0% ) 1.40 1.53 -8.7% 1.669 1.540
2500.251_hcalDPGMCNANO140Xrun3 645.333 645.333 0.000 ( +0.0% ) 1.51 1.68 -10.4% 1.782 1.781
2500.261_NANOmc2024reMINI 0.021 0.021 0.000 ( +0.0% ) 1.52 1.65 -8.0% 3.081 2.744
2500.271_NANOdata2024reMINI 0.036 0.036 0.000 ( +0.0% ) 1.54 1.67 -7.7% 2.885 2.679
2500.301_NANOmc150X 3.218 3.218 0.000 ( +0.0% ) 18.02 18.78 -4.0% 2.704 2.682
2500.311_NANOdata150X 2.144 2.144 0.000 ( +0.0% ) 33.50 36.50 -8.2% 2.380 2.218
2500.312_NANOdata150X 2.630 2.630 0.000 ( +0.0% ) 26.40 28.59 -7.7% 2.538 2.506
2500.321_muPOGNANOmc150X 2.255 2.255 0.000 ( +0.0% ) 16.35 16.89 -3.2% 2.593 2.379
2500.322_EGMNANOmc150X 4.110 4.110 0.000 ( +0.0% ) 14.92 14.14 +5.6% 2.691 2.418
2500.323_BTVNANOmc150X 10.551 10.551 0.000 ( +0.0% ) 5.05 5.05 +0.0% 2.916 2.687
2500.324_jmeNANOmc150X 6.760 6.760 0.000 ( +0.0% ) 1.38 1.39 -1.0% 2.820 2.605
2500.325_jmeNANOrePuppimc150X 6.762 6.762 0.000 ( +0.0% ) 1.30 1.32 -1.7% 3.147 3.141
2500.326_lepTrackInfoNANOmc150X 3.720 3.720 0.000 ( +0.0% ) 15.96 16.12 -1.0% 2.692 2.626
2500.327_ScoutingNANOmc150X 1.562 1.562 0.000 ( +0.0% ) 19.59 19.63 -0.2% 2.449 2.357
2500.328_ScoutingNANOwithPromptmc150X 4.773 4.773 0.000 ( +0.0% ) 10.65 10.80 -1.4% 2.932 2.678
2500.329_BPHNANOmc150X 4.108 4.108 0.000 ( +0.0% ) 17.38 17.80 -2.4% 2.616 2.533
2500.331_muPOGNANO150Xrun3 1.125 1.125 0.000 ( +0.0% ) 30.94 30.59 +1.1% 2.368 2.163
2500.332_EGMNANOdata150Xrun3 2.985 2.985 0.000 ( +0.0% ) 26.54 26.77 -0.9% 2.445 2.232
2500.333_BTVNANOdata150Xrun3 7.971 7.971 0.000 ( +0.0% ) 6.11 6.13 -0.4% 2.627 2.313
2500.334_jmeNANOdata150Xrun3 4.349 4.349 0.000 ( +0.0% ) 1.69 1.71 -1.2% 2.593 2.360
2500.335_jmeNANOrePuppidata150Xrun3 4.332 4.332 0.000 ( +0.0% ) 1.46 1.47 -0.4% 2.851 2.592
2500.336_lepTrackInfoNANOdata150Xrun3 2.625 2.625 0.000 ( +0.0% ) 27.67 27.85 -0.7% 2.402 2.111
2500.337_ScoutingNANOdata150Xrun3 1.737 1.737 0.000 ( +0.0% ) 31.68 31.94 -0.8% 1.543 1.479
2500.338_ScoutingNANOwithPromptdata150Xrun3 2.601 2.601 0.000 ( +0.0% ) 18.22 18.37 -0.8% 2.594 2.483
2500.339_BPHNANOdata150Xrun3 2.604 2.604 0.000 ( +0.0% ) 35.07 35.84 -2.1% 2.487 2.453
2500.901_TTbarMINIAOD10.6_UL18v2 1.819 1.819 0.000 ( +0.0% ) 34.65 34.30 +1.0% 1.876 1.844
2500.902_TTbarMINIAOD14.0 1.665 1.665 0.000 ( +0.0% ) 32.48 33.27 -2.4% 1.459 1.385
2500.911_DYToLL_M-50_13TeV_pythia8 14.345 14.345 0.000 ( +0.0% ) 8.30 8.38 -1.0% 1.095 1.094
2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 0.150 0.310 -0.160 ( -51.6% ) 3.25 2.94 +10.5% 0.849 0.848
2500.913_TTbar_Pow_LHE_13TeV 0.110 0.110 0.000 ( +0.0% ) 2.63 2.72 -3.3% 0.850 0.851

@jfernan2
Copy link
Contributor

+1

@valsdav
Copy link
Contributor

valsdav commented Jul 17, 2025

type egamma

@valsdav
Copy link
Contributor

valsdav commented Aug 6, 2025

Hi @hqucms @ftorrresd I guess we can also merge the backport. Thanks!

@hqucms
Copy link
Contributor

hqucms commented Aug 8, 2025

+1

As discussed in #48539 (comment), the diffs observed in the Run3 2024 reMINI workflows 2500.2601,2500.2701 are due to the misuse of the procModifier run2_miniAOD_UL_preSummer20 in these relval wfs (which will be fixed by #48686 and backported to 15_0_X too). The procModifier is not used in any Run3 production workflows, therefore no changes are expected for the ongoing production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@hqucms
Copy link
Contributor

hqucms commented Aug 8, 2025

backport of #48539

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6b66d84 into cms-sw:CMSSW_15_0_X Aug 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants