Skip to content

Fix for n_layers Check in CAHitNtupletAlpaka::globalBeginRun #48477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Jul 4, 2025
Merged

Fix for n_layers Check in CAHitNtupletAlpaka::globalBeginRun #48477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtuplet.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
#endif

auto oldLayer = 0u;
auto layerCount = 0;
auto layerCount = 0u;

std::vector<int> layerStarts(n_layers + 1);
//^ why n_layers + 1? This is a cumulative sum of the number
Expand All @@ -162,7 +162,7 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
if (layer != oldLayer) {
layerStarts[layerCount++] = n_modules;

if (layerCount > n_layers + 1)
if (layerCount >= layerStarts.size())
break;

oldLayer = layer;
Expand Down