Migrate LST outputs to Portable SoAs

[ariostas]

This PR refactors the LST outputs so that Portable SoAs are used as much as possible. The output of the LST Producer is now a device collection, and the framework takes care of copying it to the host.

This continues the work from #47793, now on the outputs side, and completes the tasks related to CMSSW-LST interfacing in #46746.

c.c. @slava77

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48409/45307

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/Common/src/classes_def.xml modified in PR(s): SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU #47629
  • File RecoTracker/LSTCore/src/alpaka/LST.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377
  • File RecoTracker/LSTCore/src/alpaka/LSTEvent.dev.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377

[cmsbuild]

A new Pull Request was created by @ariostas for master.

It involves the following packages:

• DataFormats/Common (core)
• RecoTracker/LST (reconstruction)
• RecoTracker/LSTCore (reconstruction)

@Dr15Jones, @cmsbuild, @jfernan2, @makortel, @mandrenguyen, @smuzaffar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @mtosi, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[slava77]

test parameters:

• enable_tests = gpu
• workflows_gpu = 29634.704,29834.704
• workflows = 29634.703,29834.703,29834.755,29634.757,29834.757
• relvals_opt = -w upgrade,standard
• relvals_opt_gpu = -w upgrade,standard

[slava77]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c9102/46917/summary.html
COMMIT: 21a525e
CMSSW: CMSSW_15_1_X_2025-06-25-1100/el8_amd64_gcc12
Additional Tests: CUDA,ROCM
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48409/46917/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a': No such file or directory
cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a] Error 1
>> Deleted: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a] Error 1
@@@@ Checking for missing symbols was SKIPPED due to NO_LIB_CHECKING flag in BuildFile: libUtilitiesStaticAnalyzers.so
Unknow target lib/el8_amd64_gcc12/RecoTrackerLSTCore_xr.rootmap
Unknow target lib/el8_amd64_gcc12/RecoTrackerLST_xr.rootmap


[ariostas]

Sorry about that, that header was deleted by mistake.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48409/45311

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/Common/src/classes_def.xml modified in PR(s): SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU #47629
  • File RecoTracker/LSTCore/src/alpaka/LST.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377
  • File RecoTracker/LSTCore/src/alpaka/LSTEvent.dev.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377

[ariostas]

did you resolve through the web interface?

Yeah, I did. Maybe that was the issue.

I rebased and squashed the commits. Seems like it's good now, but we have to collect signatures again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48409/45626

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoTracker/LSTCore/src/alpaka/LST.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377
  • File RecoTracker/LSTCore/src/alpaka/LSTEvent.dev.cc modified in PR(s): Updated SoA View accessors from raw pointers to span #48377

[cmsbuild]

Pull request #48409 was updated. @Dr15Jones, @cmsbuild, @fwyzard, @makortel, @smuzaffar can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c9102/47424/summary.html
COMMIT: 01ce3e0
CMSSW: CMSSW_15_1_X_2025-07-28-1100/el8_amd64_gcc12
Additional Tests: CUDA,ROCM
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48409/47424/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 8
• DQMHistoTests: Total histograms compared: 381070
• DQMHistoTests: Total failures: 3472
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 377587
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 7 files compared)
• Checked 25 log files, 22 edm output root files, 8 DQM output files
• TriggerResults: no differences found

CUDA Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 215 differences found in the comparisons
• DQMHistoTests: Total files compared: 9
• DQMHistoTests: Total histograms compared: 117859
• DQMHistoTests: Total failures: 8905
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 108954
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
• Checked 32 log files, 36 edm output root files, 9 DQM output files
• TriggerResults: no differences found

ROCM Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 175 differences found in the comparisons
• DQMHistoTests: Total files compared: 9
• DQMHistoTests: Total histograms compared: 117859
• DQMHistoTests: Total failures: 8071
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 109788
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
• Checked 32 log files, 36 edm output root files, 9 DQM output files
• TriggerResults: no differences found

[fwyzard]

+heterogeneous

[slava77]

@cms-sw/core-l2 your updated signature is needed, after a rebase following a conflict resolution in DataFormats/Common/src/classes_def.xml .
Please check.
Thank you.

[makortel]

+core

Thanks for the ping

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1