Fix for PR #47067

[tschuh]

This PR includes a missing data member initialization accidentally introduced during review. Additionally I added a check during TTBV construction for nonsensical bit widths. That will prevent invalid array indices currently seen as UBSAN runtime errors.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48247/45054

[cmsbuild]

A new Pull Request was created by @tschuh for master.

It involves the following packages:

• DataFormats/L1TrackTrigger (upgrade, l1)
• L1Trigger/TrackTrigger (upgrade, l1)

@BenjaminRS, @Moanwar, @cmsbuild, @quinnanm, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @missirol, @mmusich, @rovere, @skinnari, @sviret this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[quinnanm]

test parameters:

workflow = 29634.78
relvals_opt = --what upgrade

[quinnanm]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-521adc/46547/summary.html
COMMIT: 027b6cb
CMSSW: CMSSW_15_1_X_2025-06-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48247/46547/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @SegmentLinking Fix ROCm compilation of standalone LST #48236

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-521adc/46547/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-521adc/46547/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

RelVals

• 29634.75

----- Begin Fatal Exception 04-Jun-2025 19:38:27 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
Exception Message:
TTBV constructor called with bad bit width (0).
----- End Fatal Exception -------------------------------------------------

• 29834.999

----- Begin Fatal Exception 04-Jun-2025 19:43:17 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
Exception Message:
TTBV constructor called with bad bit width (0).
----- End Fatal Exception -------------------------------------------------

• 29634.78

----- Begin Fatal Exception 04-Jun-2025 19:55:18 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
Exception Message:
TTBV constructor called with bad bit width (0).
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 24834.911
• 29634.911
• 29634.0

[Dr15Jones]

@tschuh any estimates on when you might be able to address the issues found while testing this PR?

[tschuh]

will happen today

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48247/45067

[BenjaminRS]

@cms-sw/core-l2 can you please shed some light on how to run the specific tests which failed previously please?

[makortel]

please test workflow 34434.0 for CMSSW_15_1_UBSAN_X

[makortel]

Hmh, I think that should have been the right syntax, but the bot says nevertheless

Unable to find CMSSW IB for CMSSW_15_1_UBSAN_X.

[makortel]

test parameters:

• workflow = 34434.0
• release = CMSSW_15_1_UBSAN_X

[makortel]

@cmsbuild, please test

[BenjaminRS]

Indeed I had the same error when I ran it here 🙁

[makortel]

@cms-sw/externals-l2 Could you take a look on what is going on with the tests here?

[smuzaffar]

please test workflow 34434.0 for CMSSW_15_1_UBSAN_X

[smuzaffar]

@cms-sw/externals-l2 Could you take a look on what is going on with the tests here?

@makortel , there were multiple UBSAN IBs and bot could not decide which one to use. I have update bot configuration to use the el8_amd64_gcc12 one as default.

[makortel]

Thanks!

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-521adc/46580/summary.html
COMMIT: 0fabb3e
CMSSW: CMSSW_15_1_UBSAN_X_2025-06-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48247/46580/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

[BenjaminRS]

please test workflow 34434.0 for CMSSW_15_1_UBSAN_X
At least one previous error looked to be temporary: [ERROR] Socket error: resource temporarily unavailable

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-521adc/46603/summary.html
COMMIT: 0fabb3e
CMSSW: CMSSW_15_1_UBSAN_X_2025-06-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48247/46603/install.sh to create a dev area with all the needed externals and cmssw changes.

[BenjaminRS]

+l1

[mandrenguyen]

@cms-sw/upgrade-l2 please have a look

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1