Skip to content

Conversation

@missirol
Copy link
Contributor

backport of #48045

PR description:

From the description of #48045

This PR updates the kBMTF inputs in L1REPACK:Full, making use of the unpacked BMTF data rather than the re-emulated trigger primitives. This follows what is done here in customiseReEmul.L1TReEmulFromRAW. For more context, see #47925 (comment).

PR validation:

None beyond the validation done for #48045 (which was done using CMSSW_15_0_5).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#48045

Bugfix, useful to integrate in the production cycle for offline trigger studies (it has no direct impact on data-taking operations).

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2025

A new Pull Request was created by @missirol for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2025

cms-bot internal usage

@missirol
Copy link
Contributor Author

Just asking the review of @cms-sw/l1-l2, like in #48045 (comment).

@mmusich
Copy link
Contributor

mmusich commented May 13, 2025

assign l1

@cmsbuild
Copy link
Contributor

New categories assigned: l1

@BenjaminRS,@quinnanm you have been requested to review this Pull request/Issue and eventually sign? Thanks

@quinnanm
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de9b6a/46101/summary.html
COMMIT: c688ce7
CMSSW: CMSSW_15_0_X_2025-05-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48072/46101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4012822
  • DQMHistoTests: Total failures: 19371
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3993431
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 48 workflows

@quinnanm
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e2003a6 into cms-sw:CMSSW_15_0_X May 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants