-
Notifications
You must be signed in to change notification settings - Fork 4.6k
LST pixelSeeds Eta Name Correction #48048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48048/44768 |
|
A new Pull Request was created by @GNiendorf for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
urgent |
|
test parameters:
|
|
please test |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
@cms-sw/orp-l2 , this looks good now. Please merge it so that I can trigger a new IB which can be used for PR tests |
|
+1 |
should we just merge it now, or let the tests finish? If you want to go ahead with an urgent fix feel free to merge. |
|
@mandrenguyen , I would suggest to merge it now. IB is broken anyway so comparison job will not show any thing meaning full |
|
merge |
|
@smuzaffar how did the previous PR get merged with an untested changed commit? |
|
@Dr15Jones , If I understand correctly, there were two PR #47995 and #47793 which were tested separately but had touched same code. that is why PR tests did not catch this. |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
PR description:
Small naming correction PR to (#47995) since (#47793) was merged in shortly before my PR and changed eta to the pixelSeeds SoA from the pixelSegments SoA.
PR validation:
I verified that this PR fixes a compilation error for LST that says pixelSegments does not have a field eta due to a naming change in a previous PR. The code compiles in the standalone config now and runs as expected.