Silence Wdangling-reference in RecoLocalCalo/EcalRecProducers alpaka plugin

[iarspider]

PR description:

As suggested by @fwyzard in #47945 (comment)

PR validation:

Bot tests

[iarspider]

please test for el8_amd64_gcc14

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48041/44758

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• RecoLocalCalo/EcalRecProducers (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @denizsun, @missirol, @rchatter, @salimcerci, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for el8_amd64_gcc14

[smuzaffar]

should we apply this flag only for RecoLocalCalo/EcalRecProducers/plugins/alpaka/EcalUncalibRecHitPhase2WeightsAlgoPortable.dev.cc file? and may be only when compiler if gcc version 14?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48041/44759

[cmsbuild]

Pull request #48041 was updated. @jfernan2, @mandrenguyen can you please check and sign again.

[iarspider]

should we apply this flag only for RecoLocalCalo/EcalRecProducers/plugins/alpaka/EcalUncalibRecHitPhase2WeightsAlgoPortable.dev.cc file? and may be only when compiler if gcc version 14?

I couldn't find any example of doing it. As far as I understand #pragma warnings don't work in our code because of LTO - or it only applies to some warnings?

[smuzaffar]

should we apply this flag only for RecoLocalCalo/EcalRecProducers/plugins/alpaka/EcalUncalibRecHitPhase2WeightsAlgoPortable.dev.cc file? and may be only when compiler if gcc version 14?

I couldn't find any example of doing it. As far as I understand #pragma warnings don't work in our code because of LTO - or it only applies to some warnings?

@iarspider , try something like the following

<iftool name="gcc-cxxcompiler" version="14[.]">
   <flags CXXFLAGS="-Wno-dangling-reference" file="EcalUncalibRecHitPhase2WeightsAlgoPortable.dev.cc"/>
</iftool>

[iarspider]

@smuzaffar thanks!

[iarspider]

please test for el8_amd64_gcc14

[iarspider]

@iarspider , can you please squash the changes here

done

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48041/44793

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/EcalRecProducers/plugins/alpaka/EcalUncalibRecHitPhase2WeightsAlgoPortable.dev.cc modified in PR(s): [Do not merge] Testing build command #48061

[cmsbuild]

Pull request #48041 was updated. @cmsbuild can you please check and sign again.

[smuzaffar]

please test

[smuzaffar]

please test for el8_amd64_gcc14

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497a37/46088/summary.html
COMMIT: 75e6a3d
CMSSW: CMSSW_15_1_X_2025-05-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48041/46088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4038163
• DQMHistoTests: Total failures: 60
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4038083
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497a37/46092/summary.html
COMMIT: 75e6a3d
CMSSW: CMSSW_15_1_X_2025-05-12-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48041/46092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 758 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 100501 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4038163
• DQMHistoTests: Total failures: 568334
• DQMHistoTests: Total nulls: 463
• DQMHistoTests: Total successes: 3469346
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.7439999999999993 KiB( 49 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.054 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): -0.596 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 140.045,... ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.043 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.014 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.408 ): -0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.5 ): 0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.604 ): 0.090 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.713 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 17034.0 ): -1.074 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): ...
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: found differences in 22 / 48 workflows

[smuzaffar]

@iarspider , if this is ready then please unhold it

[iarspider]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1