-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[15.0] Fix missing CaloParticles from pileup
#47771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @AuroraPerego for CMSSW_15_0_X. It involves the following packages:
@AdrianoDee, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
test parameters: |
|
please test |
|
-1 Failed Tests: RelVals |
|
test parameters: |
|
please test |
|
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
|
+simulation |
|
+Upgrade |
|
type bug-fix |
|
@cms-sw/pdmv-l2 kind ping. |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
@cms-sw/orp-l2 please merge this fix |
|
+1 |
PR description:
Since CMSSW_15_0_0_pre2, there are no CaloParticles from pileup due to a wrong ioread rule that led to misreading the pileup files. This PR fixes the ioread rule for ClassVersion 12 and below (the
crossedBoundary_variable was introduced with ClassVersion 12, requiring two different rules).In addition, a processModifier to consider also CaloParticles from pileup in the associators (leading to the creation of tracksters from pileup) has been added.
PR validation:
to be tested with 29888.208 and 301.0
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
backport of #47682 and #47765, to fix #46979