Skip to content

Conversation

@AuroraPerego
Copy link
Contributor

@AuroraPerego AuroraPerego commented Apr 3, 2025

PR description:

Since CMSSW_15_0_0_pre2, there are no CaloParticles from pileup due to a wrong ioread rule that led to misreading the pileup files. This PR fixes the ioread rule for ClassVersion 12 and below (the crossedBoundary_ variable was introduced with ClassVersion 12, requiring two different rules).

In addition, a processModifier to consider also CaloParticles from pileup in the associators (leading to the creation of tracksters from pileup) has been added.

PR validation:

to be tested with 29888.208 and 301.0

workflow = 29888.208,301.0
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #47682 and #47765, to fix #46979

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2025

A new Pull Request was created by @AuroraPerego for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • SimCalorimetry/HGCalSimProducers (simulation, upgrade)
  • SimDataFormats/Track (simulation)

@AdrianoDee, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @VinInn, @VourMa, @apsallid, @bsunanda, @cseez, @denizsun, @fabiocos, @hatakeyamak, @lgray, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @slomeo, @vandreev11, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2025

cms-bot internal usage

@Moanwar
Copy link
Contributor

Moanwar commented Apr 3, 2025

test parameters:
workflow_opts = -w upgrade
workflows = 29888.208, 301.0

@Moanwar
Copy link
Contributor

Moanwar commented Apr 3, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2025

-1

Failed Tests: RelVals
Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2785d7/45357/summary.html
COMMIT: e6cb5ed
CMSSW: CMSSW_15_0_X_2025-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47771/45357/install.sh to create a dev area with all the needed externals and cmssw changes.

@Moanwar
Copy link
Contributor

Moanwar commented Apr 3, 2025

test parameters:
workflow = 29888.208,301.0
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@Moanwar
Copy link
Contributor

Moanwar commented Apr 3, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2025

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2785d7/45361/summary.html
COMMIT: e6cb5ed
CMSSW: CMSSW_15_0_X_2025-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47771/45361/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3999716
  • DQMHistoTests: Total failures: 84
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3999612
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 3, 2025

backport of #47682
(combined w/ #47765)

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 3, 2025

+simulation

@Moanwar
Copy link
Contributor

Moanwar commented Apr 3, 2025

+Upgrade

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2025

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2025

@cms-sw/pdmv-l2 kind ping.

@AdrianoDee
Copy link
Contributor

+pdmv
(apologies!)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

@cms-sw/orp-l2 please merge this fix

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit af4388f into cms-sw:CMSSW_15_0_X Apr 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants