Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 29, 2025

PR description:

Remove legacy CUDA modules for HCAL local reconstruction.
The alpaka version has been commissioned and used in production.

Remove legacy CUDA modules for HCAL unpacker.
The outcome of the discussion with the HCAL DPG is that:

  • for Run 3 we should use the legacy cpu unpacker, and the alpaka version of the legacy-to-SoA converter;
  • for Phase 2 the decision can be revisited once the final raw and digi formats are defined.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Backport of #46004 to 15.0.x to clean up the code base.

fwyzard added 2 commits March 29, 2025 15:14
The outcome of the discussion with the HCAL DPG is that
  - for Run 3 we should use the legacy cpu unpacker, and the alpaka
    version of the legacy-to-SoA converter;
  - for Phase 2 the decision can be revisited once the final raw and
    digi formats are defined.
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 29, 2025

backport #46004

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 29, 2025

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 29, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2025

A new Pull Request was created by @fwyzard for CMSSW_15_0_X.

It involves the following packages:

  • CUDADataFormats/HcalDigi (reconstruction, heterogeneous)
  • CUDADataFormats/HcalRecHitSoA (reconstruction, heterogeneous)
  • CondFormats/DataRecord (db, alca)
  • CondFormats/HcalObjects (db, alca)
  • EventFilter/HcalRawToDigi (reconstruction)
  • RecoLocalCalo/Configuration (reconstruction)
  • RecoLocalCalo/HcalRecAlgos (reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)
  • Validation/Configuration (simulation, dqm)

@antoniovagnerini, @atpathak, @civanch, @consuegs, @francescobrivio, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @rseidita can you please review it and eventually sign? Thanks.
@JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @denizsun, @mariadalfonso, @missirol, @mmusich, @rchatter, @rovere, @rsreds, @salimcerci, @sameasy, @seemasharmafnal, @thomreis, @tocheng, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c346da/45282/summary.html
COMMIT: 92e5d86
CMSSW: CMSSW_15_0_X_2025-03-29-1100/el8_amd64_gcc12
Additional Tests: CUDA,ROCM
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47733/45282/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 312 lines from the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3999716
  • DQMHistoTests: Total failures: 64
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 3999623
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.41600000000000026 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): -0.008 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 11634.0,... ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 11634.0,... ): -0.004 KiB MessageLogger/Warnings
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

CUDA Comparison Summary

Summary:

ROCM Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53071
  • DQMHistoTests: Total failures: 906
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52165
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files

@perrotta
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Mar 31, 2025

+1

@antoniovagnerini
Copy link

+dqm

@jfernan2
Copy link
Contributor

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 1, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ac2837d into cms-sw:CMSSW_15_0_X Apr 2, 2025
15 checks passed
@fwyzard fwyzard deleted the remove_legacy_cuda_modules_HCAL_150x branch August 13, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants