-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Include the possibility of combining four objects in the "CandViewShallowCloneCombiner" producer #47691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Simply add `&& lists != 4` in: ``` if (lists != 2 && lists != 3) ```
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47691/44239 |
|
A new Pull Request was created by @Ma128-bit for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Size: This PR adds an extra 20KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Included the possibility of using the producer “CandViewShallowCloneCombiner” to create combinations of four objects, I simply added
&& lists != 4in:PR validation:
The producer has been used with this modification to generate combinations of four muons without apparent issues in the B→4μ analysis.
P.S. This modification will not have any impact on combinations of two or three objects.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Will backport to 15_1_X and 15_0_X.
If it is possible also to: 14_2_X, 14_1_X and 14_0_X