-
Notifications
You must be signed in to change notification settings - Fork 4.6k
AlpakaServiceSerialSync should always be available
#47672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlpakaServiceSerialSync should always be available
#47672
Conversation
The AlpakaServiceSerialSync should always be available, even if the "cpu" accelerator is not listed in process.options.accelerators.
|
type bugfix |
|
cms-bot internal usage |
|
fixes #43780 |
|
enable gpu |
|
please test with #47377 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47672/44208 |
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
AlpakaServiceSerialSync should always be available
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
CUDA Comparison SummarySummary:
ROCM Comparison SummarySummary:
|
|
test parameters:
|
|
please test |
|
141.044407 and 141.044483 fail in the GPU IBs because they don't find the These changes should fix that. |
|
-1 Failed Tests: RelVals-ROCM RelVals-ROCM
Comparison SummarySummary:
CUDA Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
|
141.044407 and 141.044483 now pass: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faa1f9/45178/runTheMatrixCUDA-results/runall-report-step123-.log . |
|
+heterogeneous |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
ignore tests-rejected with ib-failure |
|
+1 |
PR description:
The
AlpakaServiceSerialSyncshould always be available, even if the"cpu"accelerator is not listed inprocess.options.accelerators.PR validation:
The workflows 141.044407 and 141.044483 were failing due to the missing
AlpakaServiceSerialSyncin step3.With these changes they run successfully.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 15.0.x for data taking.