Skip to content

Follow-up to add HLT tracking monitoring in cosmics #47663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 3 commits into from
Mar 25, 2025
Merged

Follow-up to add HLT tracking monitoring in cosmics #47663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9777ad5
Include HLTMonitoring sequences for Cosmics
mmusich Mar 22, 2025
9040eee
update workflow 7.25
mmusich Mar 22, 2025
40b7674
Adapt TrackToTrackComparisonHists to run in cosmics mode
mmusich Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Configuration/PyReleaseValidation/python/relval_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3164,7 +3164,7 @@ def gen2024HiMix(fragment,howMuch):
steps['RECOCOS_UP21_0T']=merge([{'--magField':'0T','--conditions':'auto:phase1_2022_cosmics_0T'},steps['RECOCOS_UP21']])
steps['RECOCOSPEAK_UP17']=merge([{'--conditions':'auto:phase1_2017_cosmics_peak','-s':'RAW2DIGI,L1Reco,RECO,ALCA:MuAlGlobalCosmics,DQM','--scenario':'cosmics','--era':'Run2_2017'},step3Up2015Hal])
steps['RECOCOSPEAK_UP18']=merge([{'--conditions':'auto:phase1_2018_cosmics_peak','-s':'RAW2DIGI,L1Reco,RECO,ALCA:MuAlGlobalCosmics,DQM','--scenario':'cosmics','--era':'Run2_2018'},step3Up2015Hal])
steps['RECOCOS_UP25']=merge([{'--conditions':'auto:phase1_2025_cosmics','-s':'RAW2DIGI,L1Reco,RECO,ALCA:MuAlGlobalCosmics,DQM','--scenario':'cosmics','--era':'Run3_2025'},step3Up2015Hal])
steps['RECOCOS_UP25']=merge([{'--conditions':'auto:phase1_2025_cosmics','-s':'RAW2DIGI,L1Reco,RECO,ALCA:MuAlGlobalCosmics,DQM:@HLTMon','--scenario':'cosmics','--era':'Run3_2025'},step3Up2015Hal])

steps['RECOCOS_Phase2']=merge([{'--conditions': phase2CosInfo['GT'],
'-s':'RAW2DIGI,L1Reco,RECO,ALCA:MuAlGlobalCosmics',
Expand Down Expand Up @@ -4147,7 +4147,7 @@ def gen2024HiMix(fragment,howMuch):
'--era' : 'Run3'
}

steps['HARVESTCOS_UP25']={'-s' :'HARVESTING:dqmHarvesting',
steps['HARVESTCOS_UP25']={'-s' :'HARVESTING:@HLTMon',
'--conditions':'auto:phase1_2024_cosmics',
'--mc' :'',
'--filein' :'file:step3_inDQM.root',
Expand Down
1 change: 1 addition & 0 deletions DQM/TrackingMonitorSource/interface/TrackToTrackComparisonHists.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ class TrackToTrackComparisonHists : public DQMEDAnalyzer {

private:
// edm::ParameterSet conf_;
const bool isCosmics_;
std::string topDirName_;
double dRmin_;
double pTCutForPlateau_;
Expand Down
21 changes: 14 additions & 7 deletions DQM/TrackingMonitorSource/src/TrackToTrackComparisonHists.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
TrackToTrackComparisonHists::TrackToTrackComparisonHists(const edm::ParameterSet& iConfig)
: monitoredTrackInputTag_(iConfig.getParameter<edm::InputTag>("monitoredTrack")),
referenceTrackInputTag_(iConfig.getParameter<edm::InputTag>("referenceTrack")),
isCosmics_(iConfig.getParameter<bool>("isCosmics")),
topDirName_(iConfig.getParameter<std::string>("topDirName")),
dRmin_(iConfig.getParameter<double>("dRmin")),
pTCutForPlateau_(iConfig.getParameter<double>("pTCutForPlateau")),
Expand Down Expand Up @@ -119,15 +120,17 @@ void TrackToTrackComparisonHists::analyze(const edm::Event& iEvent, const edm::E

edm::Handle<reco::VertexCollection> referencePVHandle;
iEvent.getByToken(referencePVToken_, referencePVHandle);
if (!referencePVHandle.isValid()) {
if (!referencePVHandle.isValid() && !isCosmics_) {
edm::LogError("TrackToTrackComparisonHists") << "referencePVHandle not found, skipping event";
return;
}
if (referencePVHandle->empty()) {
if (referencePVHandle->empty() && !isCosmics_) {
edm::LogInfo("TrackToTrackComparisonHists") << "referencePVHandle->size is 0 ";
return;
}
reco::Vertex referencePV = referencePVHandle->at(0);
reco::Vertex referencePV = isCosmics_
? reco::Vertex(referenceBS.position(), referenceBS.rotatedCovariance3D(), 0., 0., 0)
: referencePVHandle->at(0);

//
// Get Monitored Track Info
Expand All @@ -151,15 +154,18 @@ void TrackToTrackComparisonHists::analyze(const edm::Event& iEvent, const edm::E

edm::Handle<reco::VertexCollection> monitoredPVHandle;
iEvent.getByToken(monitoredPVToken_, monitoredPVHandle);
if (!monitoredPVHandle.isValid()) {
edm::LogError("TrackToTrackComparisonHists") << "monitoredPVHandle not found, skipping event";
if (!monitoredPVHandle.isValid() && !isCosmics_) {
edm::LogError("TrackToTrackComparisonHists")
<< "monitoredPVHandle not found, skipping event isCosmics value:" << isCosmics_;
return;
}
if (monitoredPVHandle->empty()) {
if (monitoredPVHandle->empty() && !isCosmics_) {
edm::LogInfo("TrackToTrackComparisonHists") << "monitoredPVHandle->size is 0 ";
return;
}
reco::Vertex monitoredPV = monitoredPVHandle->at(0);
reco::Vertex monitoredPV = isCosmics_
? reco::Vertex(monitoredBS.position(), monitoredBS.rotatedCovariance3D(), 0., 0., 0)
: monitoredPVHandle->at(0);

edm::LogInfo("TrackToTrackComparisonHists")
<< "analyzing " << monitoredTrackInputTag_.process() << ":" << monitoredTrackInputTag_.label() << ":"
Expand Down Expand Up @@ -306,6 +312,7 @@ void TrackToTrackComparisonHists::fillDescriptions(edm::ConfigurationDescription
edm::ParameterSetDescription desc;

desc.add<bool>("requireValidHLTPaths", true);
desc.add<bool>("isCosmics", false);

desc.add<edm::InputTag>("monitoredTrack", edm::InputTag("hltMergedTracks"));
desc.add<edm::InputTag>("monitoredBeamSpot", edm::InputTag("hltOnlineBeamSpot"));
Expand Down
3 changes: 3 additions & 0 deletions DQMOffline/Configuration/python/DQMOfflineCosmics_SecondStep_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,6 @@
DQMOfflineCosmics_SecondStep_FakeHLT = cms.Sequence(DQMOfflineCosmics_SecondStep )
DQMOfflineCosmics_SecondStep_FakeHLT.remove( DQMOfflineCosmics_SecondStepTrigger )

from DQMOffline.Trigger.TrackingMonitoringCosmics_Client_cff import *

HLTMonitoringClient = cms.Sequence(trackingMonitorCosmicsClientHLT * trackEfficiencyMonitoringCosmicsClientHLT )
2 changes: 2 additions & 0 deletions DQMOffline/Configuration/python/DQMOfflineCosmics_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,6 @@
DQMOfflineCosmicsPrePOG *
DQMMessageLogger )

HLTMonitoring = cms.Sequence( OfflineHLTMonitoring )

PostDQMOffline = cms.Sequence()
6 changes: 6 additions & 0 deletions DQMOffline/Trigger/python/DQMOffline_Trigger_cosmics_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,9 @@

#triggerCosmicOfflineDQMSource = cms.Sequence(onlineHLTSource*offlineHLTSource)
triggerCosmicOfflineDQMSource = cms.Sequence(offlineHLTSource)

# sequences run @tier0 on CosmicHLTMonitor PD
OfflineHLTMonitoring = cms.Sequence(
cosmicTrackingMonitorHLT *
hltToOfflineCosmicsTrackValidatorSequence
)
12 changes: 11 additions & 1 deletion DQMOffline/Trigger/python/TrackToTrackMonitoringCosmics_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,17 @@
referenceBeamSpot = "offlineBeamSpot",
topDirName = "HLT/Tracking/ValidationWRTOffline/hltCtfWithMaterialTracksP5",
referencePrimaryVertices = "offlinePrimaryVertices",
monitoredPrimaryVertices = "hltVerticesPFSelector"
monitoredPrimaryVertices = "hltPixelVertices",
isCosmics = cms.bool(True),
dxyCutForPlateau = 1e6,
histoPSet = dict(
Dxy_rangeMin = -60,
Dxy_rangeMax = 60,
Dxy_nbin = 120,
Dz_rangeMin = -250,
Dz_rangeMax = 250,
Dz_nbin = 250,
)
)

hltToOfflineCosmicsTrackValidatorSequence = cms.Sequence(hltCtfWithMaterialTracksP5_2_ctfWithMaterialTracksP5)
48 changes: 48 additions & 0 deletions DQMOffline/Trigger/python/TrackingMonitoringCosmics_Client_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import FWCore.ParameterSet.Config as cms

from DQMServices.Core.DQMEDHarvester import DQMEDHarvester

from DQM.TrackingMonitorClient.TrackingEffFromHitPatternClientConfig_cff import trackingEffFromHitPattern

trackingCosmicsEffFromHitPatternHLT = trackingEffFromHitPattern.clone(
subDirs = ["HLT/Tracking/hltCtfWithMaterialTracksP5/HitEffFromHitPattern*"]
)
# Sequence
trackingMonitorCosmicsClientHLT = cms.Sequence(
trackingCosmicsEffFromHitPatternHLT
)

CosmicsTrackToTrackEfficiencies = DQMEDHarvester("DQMGenericClient",
subDirs = cms.untracked.vstring(
"HLT/Tracking/ValidationWRTOffline/hltCtfWithMaterialTracksP5",
),
verbose = cms.untracked.uint32(0),
resolution = cms.vstring(),
efficiency = cms.vstring(
"Eff_pt 'Relative Efficiency vs Pt;#P_T;relative efficiency' ref_matched_pt ref_pt eff",
"Eff_eta 'Relative Efficiency vs Eta;#eta;relative efficiency' ref_matched_eta ref_eta eff",
"Eff_phi 'Relative Efficiency vs Phi;#phi;relative efficiency' ref_matched_phi ref_phi eff",
"Eff_dxy 'Relative Efficiency vs dxy;d_{xy};relative efficiency' ref_matched_dxy ref_dxy eff",
"Eff_dz 'Relative Efficiency vs dz;d_{z};relative efficiency' ref_matched_dz ref_dz eff",
"Eff_dxyWRTpv 'Relative Efficiency vs dxyWRTpv;d_{xy};relative efficiency' ref_matched_dxyWRTpv ref_dxyWRTpv eff",
"Eff_dzWRTpv 'Relative Efficiency vs dzWRTpv;d_{z};relative efficiency' ref_matched_dzWRTpv ref_dzWRTpv eff",
"Eff_charge 'Relative Efficiency vs charge;charge;relative efficiency' ref_matched_charge ref_charge eff",
"Eff_hits 'Relative Efficiency vs hits;number of hits;relative efficiency' ref_matched_hits ref_hits eff",
"Eff_LS 'Relative Efficiency vs LS;LS;relative efficiency' ref_matched_ls ref_ls eff",

"FakeRate_pt 'Relative Fake Rate vs Pt;#P_T;relative fake rate' mon_unMatched_pt mon_pt eff",
"FakeRate_eta 'Relative Fake Rate vs Eta;#eta;relative fake rate' mon_unMatched_eta mon_eta eff",
"FakeRate_phi 'Relative Fake Rate vs Phi;#phi;relative fake rate' mon_unMatched_phi mon_phi eff",
"FakeRate_dxy 'Relative Fake Rate vs dxy;d_{xy};relative fake rate' mon_unMatched_dxy mon_dxy eff",
"FakeRate_dz 'Relative Fake Rate vs dz;d_{z};relative fake rate' mon_unMatched_dz mon_dz eff",
"FakeRate_dxyWRTpv 'Relative Fake Rate vs dxyWRTpv;d_{xy};relative fake rate' mon_unMatched_dxyWRTpv mon_dxyWRTpv eff",
"FakeRate_dzWRTpv 'Relative Fake Rate vs dzWRTpv;d_{z};relative fake rate' mon_unMatched_dzWRTpv mon_dzWRTpv eff",
"FakeRate_charge 'Relative Fake Rate vs charge;charge;relative fake rate' mon_unMatched_charge mon_charge eff",
"FakeRate_hits 'Relative Fake Rate vs hits;number of hits;relative fake rate' mon_unMatched_hits mon_hits eff",
"FakeRate_LS 'Relative Fake Rate vs LS;LS;relative fake rate' mon_unMatched_ls mon_ls eff",
),
)

trackEfficiencyMonitoringCosmicsClientHLT = cms.Sequence(
CosmicsTrackToTrackEfficiencies
)
4 changes: 2 additions & 2 deletions DQMOffline/Trigger/python/TrackingMonitoringCosmics_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
from DQM.TrackingMonitor.TrackerCosmicsTrackingMonitor_cfi import *
TrackMon_cosmicTkHLT = TrackerCosmicTrackMon.clone(
TrackProducer = 'hltCtfWithMaterialTracksP5',
AlgoName = 'CKFTk',
FolderName = 'HLT/Tracking/TrackParameters',
AlgoName = 'CtfWithMaterialTracksP5',
FolderName = 'HLT/Tracking/hltCtfWithMaterialTracksP5',
doSeedParameterHistos = True
)

Expand Down