Integrating Particle Flow Network (PFN) Models into TICLv5 #47550

Moanwar · 2025-03-10T21:28:33Z

This PR introduces Particle Flow Network (PFN) models trained using TICLv5 reconstruction data through a simple CNN/DNN-based approach. Two separate models were developed: one for trackster energy regression and another for particle identification. These models are integrated into different reconstruction steps, specifically CLU3D (pattern recognition) and trackster linking. To optimize processing time, the models are saved in ONNX format.

Additionally, a new inference plugin has been implemented to run these models, now serving as the default for TICLv5.

-This PR needs to be tested with the following cms-data PR: cms-data/RecoHGCal-TICL#8

-Additionally, this PR should be tested on the .203 workflow :

-test parameters:
workflow_opts= -w upgrade
workflow = 29888.203,29688.203

Tagging @felicepantaleo @waredjeb @hatakeyamak

cmsbuild · 2025-03-10T21:29:01Z

cms-bot internal usage

cmsbuild · 2025-03-10T21:31:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47550/44025

Moanwar · 2025-03-10T21:31:37Z

test parameters:
pull_request = cms-data/RecoHGCal-TICL#8
workflow_opts = -w upgrade
workflows = 29888.203,29688.203

cmsbuild · 2025-03-10T21:31:59Z

A new Pull Request was created by @Moanwar for master.

It involves the following packages:

HLTrigger/Configuration (hlt)
RecoHGCal/TICL (upgrade, reconstruction)

@Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @apsallid, @denizsun, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @mmusich, @rovere, @salimcerci, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Moanwar · 2025-03-10T21:34:00Z

@cmsbuild, please test

cmsbuild · 2025-03-10T22:55:55Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a8859/44900/summary.html
COMMIT: ab16f49
CMSSW: CMSSW_15_1_X_2025-03-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

29634.75

----- Begin Fatal Exception 10-Mar-2025 23:35:47 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=TrackstersProducer label='hltTiclTrackstersCLUE3DHigh'
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/ticlv5/onnx_models/patternrecognition/id_v0.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02880/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-03-10-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02880/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-03-10-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29634.75_TTbar_14TeV+Run4D110_HLT75e33Timing
----- End Fatal Exception -------------------------------------------------

29834.999

----- Begin Fatal Exception 10-Mar-2025 23:40:23 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=TrackstersProducer label='hltTiclTrackstersCLUE3DHigh'
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/ticlv5/onnx_models/patternrecognition/id_v0.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02880/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-03-10-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02880/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-03-10-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29834.999_TTbar_14TeV+Run4D110PU_PMXS1S2PR
----- End Fatal Exception -------------------------------------------------

24834.911

----- Begin Fatal Exception 10-Mar-2025 23:39:54 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=TrackstersProducer label='hltTiclTrackstersCLUE3DHigh'
Exception Message:
edm::FileInPath unable to find file RecoHGCal/TICL/data/ticlv5/onnx_models/patternrecognition/id_v0.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44900/CMSSW_15_1_X_2025-03-10-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02880/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-03-10-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02880/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-03-10-1100/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24834.911_TTbar_14TeV+Run4D98_DD4hep
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

cmsbuild · 2025-03-10T23:41:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47550/44027

jfernan2 · 2025-03-11T15:25:18Z

+1

mmusich · 2025-03-11T16:57:29Z

test parameters:

pull_request = Added PFN models and reorganized the repository structure cms-data/RecoHGCal-TICL#8
workflow_opts= -w upgrade
workflows = 29634.75, 29634.751, 29634.752, 29634.753, 29634.754, 29634.755, 29634.77, 29888.203, 29688.203

mmusich · 2025-03-11T16:57:52Z

+hlt

last round of tests will automatically sign the PR

mmusich · 2025-03-11T16:58:00Z

@cmsbuild, please test

cmsbuild · 2025-03-11T19:04:44Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a8859/44925/summary.html
COMMIT: bafa98a
CMSSW: CMSSW_15_1_X_2025-03-11-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47550/44925/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

29634.7729634.77_TTbar_14TeV+Run4D110_NGTScouting/step2_TTbar_14TeV+Run4D110_NGTScouting.log

HLT P2 Timing: chart

mmusich · 2025-03-12T07:55:43Z

ModuleNotFoundError: No module named 'HLTrigger.Configuration.HLT_75e33.eventsetup.hltOnlineBeamSpotESProducer_cfi'

OK, this is due to #47378, will fix shortly.

Moanwar · 2025-03-12T09:57:38Z

+Upgrade

cmsbuild · 2025-03-12T09:58:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/RecoHGCal-TICL#8

mmusich · 2025-03-12T10:25:30Z

ignore tests-rejected with external-failure

mandrenguyen · 2025-03-14T06:16:34Z

+1

Moanwar added 2 commits March 5, 2025 16:39

Add new plugins for PFN models

46e6df9

code check fomate

ab16f49

cmsbuild added this to the CMSSW_15_1_X milestone Mar 10, 2025

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Mar 10, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 10, 2025

cmsbuild added the requires-external label Mar 10, 2025

cmsbuild added tests-started and removed tests-pending labels Mar 10, 2025

cmsbuild added tests-rejected and removed tests-started labels Mar 10, 2025

fix the new path of DNN old models

bafa98a

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Mar 10, 2025

cmsbuild removed the code-checks-pending label Mar 10, 2025

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 11, 2025

cmsbuild added hlt-approved tests-started and removed hlt-pending tests-approved labels Mar 11, 2025

cmsbuild added tests-rejected and removed tests-started labels Mar 11, 2025

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Mar 12, 2025

cmsbuild mentioned this pull request Mar 12, 2025

Added PFN models and reorganized the repository structure cms-data/RecoHGCal-TICL#8

Merged

cmsbuild added tests-approved tests-external-failure and removed tests-rejected labels Mar 12, 2025

cmsbuild added orp-approved and removed orp-pending labels Mar 14, 2025

cmsbuild merged commit d95f5aa into cms-sw:master Mar 14, 2025
13 of 14 checks passed

waredjeb mentioned this pull request Mar 18, 2025

Fix TICL Energy Regression and PID Model Loading #47616

Merged

Integrating Particle Flow Network (PFN) Models into TICLv5 #47550

Integrating Particle Flow Network (PFN) Models into TICLv5 #47550

Uh oh!

Conversation

Moanwar commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 10, 2025

Uh oh!

Moanwar commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 10, 2025

Uh oh!

Moanwar commented Mar 10, 2025

Uh oh!

cmsbuild commented Mar 10, 2025

RelVals

Uh oh!

cmsbuild commented Mar 10, 2025

Uh oh!

jfernan2 commented Mar 11, 2025

Uh oh!

mmusich commented Mar 11, 2025

Uh oh!

mmusich commented Mar 11, 2025

Uh oh!

mmusich commented Mar 11, 2025

Uh oh!

cmsbuild commented Mar 11, 2025

RelVals

Uh oh!

mmusich commented Mar 12, 2025

Uh oh!

Moanwar commented Mar 12, 2025

Uh oh!

cmsbuild commented Mar 12, 2025

Uh oh!

mmusich commented Mar 12, 2025

Uh oh!

mandrenguyen commented Mar 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Moanwar commented Mar 10, 2025 •

edited

Loading

cmsbuild commented Mar 10, 2025 •

edited

Loading

Moanwar commented Mar 10, 2025 •

edited

Loading